Re: [PATCH 0/9] prometheus: health check as labels + cleanup

2021-02-01 Thread Christopher Faulet
Le 30/01/2021 à 16:21, William Dauchy a écrit : Hi Christopher, Sorry for this long series but I believe this one is fairly easy to review: - the major change is for health checks on prometheus side, there are more details in the commit message; this is something I wanted early so people

[PATCH 1/2] BUG/MINOR: cli: fix set server addr/port coherency with health checks

2021-02-01 Thread William Dauchy
while reading `update_server_addr_port` I found out some things which can be seen as incoherency. I hope I did not overlooked anything: - one comment is stating check's address should be updated if it uses the server one; however the condition checks if `SRV_F_CHECKADDR` is set; this flag is

RE: [PATCH 1/9] MAJOR: contrib/prometheus-exporter: move health check status to labels

2021-02-01 Thread Pierre Cheynier
De : William Dauchy Envoyé : samedi 30 janvier 2021 16:21 > this is a follow up of commit c6464591a365bfcf509b322bdaa4d608c9395d75 > ("MAJOR: contrib/prometheus-exporter: move ftd/bkd/srv states to > labels"). The main goal being to be better aligned with prometheus use > cases in terms of

[PATCH 2/2] BUG/MINOR: cli: set server check-port missing flag

2021-02-01 Thread William Dauchy
when we set check port flag, we need to set a flag on server. this is missing since the origin of the feature: commit 5094656a67fa1b56f30cd2316adb675ca9d2a79a ("MINOR: cli: change a server health check port through the stats socket"). So it can potentially be backport up to v1.8. Signed-off-by:

Re: [PATCH 0/9] prometheus: health check as labels + cleanup

2021-02-01 Thread William Dauchy
On Mon, Feb 01, 2021 at 11:30:18AM +0100, Christopher Faulet wrote: > Don't be sorry to send patches ! If you think the number of labels for the > check_status metric is not a problem, even for huge configurations, I trust > you. > And I guess we can reduce this number to 16 status only, removing

lua: Add missed lua 5.4 references

2021-02-01 Thread Callum Farmer
Add missed lua 5.4 references Missed in INSTALL and Makefile Lua 5.4 support has already been added (needs backport to 2.0) --- a/INSTALL +++ b/INSTALL @@ -295,9 +295,9 @@ Lua is an embedded programming language supported by HAProxy to provide more advanced scripting capabilities. Only versions

Introducing Myself + Potential Article Idea for Haproxy

2021-02-01 Thread David Smith
Hi there, I wanted to get in touch about contributing an article to Haproxy.  A few areas that I'd be qualified to pontificate on are current trends in infosec, payment systems and platforms, and IoT security. I also love anything related to eCommerce as I run a few Shopify sites on the side. I

Re: [PATCH 1/9] MAJOR: contrib/prometheus-exporter: move health check status to labels

2021-02-01 Thread William Dauchy
On Mon, Feb 1, 2021 at 12:05 PM Pierre Cheynier wrote: > In addition to this update, I would add some recommendations about the user > setup in the README ("how do I prevent my prometheus instance to explode > when scrapping this endpoint?"). > For server-template users: > - > params: >