[PATCH] MINOR: lua: allow changing port with set_addr

2020-05-04 Thread Joseph C. Sible
Add an optional port parameter, which can be either a number or a string (to support '+' and '-' for port mapping). This fixes issue #586. --- doc/lua-api/index.rst | 2 +- src/hlua_fcn.c| 7 ++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/doc/lua-api/index.rst

Re: Question about connection settings proto fcgi check maxconn 9 minconn 5 maxqueue 0

2020-05-04 Thread Aleksandar Lazic
Hi Christopher. On 04.05.20 11:28, Christopher Faulet wrote: > Le 03/05/2020 à 09:52, Aleksandar Lazic a écrit : >> Hi. >> >> I play a little bit with proto fcgi and see something what I don't >> understand. >> >> Hopefully someone can explain it a bit. >> >> My php-fpm have the following

Re: [PATCH] CLEANUP: connections: align function declaration

2020-05-04 Thread Olivier Houchard
Hi William, On Mon, May 04, 2020 at 02:08:54PM +0200, William Dauchy wrote: > On Mon, May 04, 2020 at 01:56:10PM +0200, William Dauchy wrote: > > Sorry for this one, I originally did update the server.h file, but I > > don't know why I forgot to add it in my patch submission :/ > > then I saw you

Feature for ModSecurity: Real IP

2020-05-04 Thread Jaime Brunicardi Esteban
Hi, Just to let you know I have added a feature to the modsecurity contrib to enable it to get the client Real IP Address through an extra param in the SPOE template. This way, standalone modsecurity has access to the REAL IP and you can enable features relying on the client real IP (DDOS,

Re: [PATCH] CLEANUP: connections: align function declaration

2020-05-04 Thread William Dauchy
On Mon, May 04, 2020 at 01:56:10PM +0200, William Dauchy wrote: > Sorry for this one, I originally did update the server.h file, but I > don't know why I forgot to add it in my patch submission :/ > then I saw you fixed it while pushing my commit, thank you for this. I'm talking too fast, the .h

Re: [PATCH] CLEANUP: connections: align function declaration

2020-05-04 Thread William Dauchy
Hello Olivier, Sorry for this one, I originally did update the server.h file, but I don't know why I forgot to add it in my patch submission :/ then I saw you fixed it while pushing my commit, thank you for this. On Mon, May 04, 2020 at 01:52:40PM +0200, William Dauchy wrote: > this patch should

[PATCH] CLEANUP: connections: align function declaration

2020-05-04 Thread William Dauchy
this patch should be backported where commit 6318d33ce625 ("BUG/MEDIUM: connections: force connections cleanup on server changes") will be backported, that is to say v1.9 to v2.1. Fixes: 6318d33ce625 ("BUG/MEDIUM: connections: force connections cleanup on server changes") Signed-off-by: William

Re: Question about connection settings proto fcgi check maxconn 9 minconn 5 maxqueue 0

2020-05-04 Thread Christopher Faulet
Le 03/05/2020 à 09:52, Aleksandar Lazic a écrit : Hi. I play a little bit with proto fcgi and see something what I don't understand. Hopefully someone can explain it a bit. My php-fpm have the following settings. ``` pm = dynamic pm.max_children = 10 pm.min_spare_servers = 4 pm.start_servers

Re: [PATCH] guard tests that require pcre

2020-05-04 Thread Илья Шипицин
пн, 4 мая 2020 г. в 13:06, Christopher Faulet : > Le 04/05/2020 à 08:57, Christopher Faulet a écrit : > > Le 04/05/2020 à 07:46, William Lallemand a écrit : > >> On Fri, May 01, 2020 at 12:57:06PM +0500, Илья Шипицин wrote: > >>> > >>> The following tests require pcre support: > >>> > >>>

Re: [RFC] Changing server port via Lua

2020-05-04 Thread Christopher Faulet
Le 03/05/2020 à 20:33, Joseph C. Sible a écrit : A question was recently asked on Stack Overflow about how to change a server's port via Lua [1]. The Lua function Server.set_addr currently says "See the management socket documentation for more information about the format of the string."

Re: [PATCH] guard tests that require pcre

2020-05-04 Thread Christopher Faulet
Le 04/05/2020 à 08:57, Christopher Faulet a écrit : Le 04/05/2020 à 07:46, William Lallemand a écrit : On Fri, May 01, 2020 at 12:57:06PM +0500, Илья Шипицин wrote: The following tests require pcre support: reg-tests/checks/4be_1srv_smtpchk_httpchk_layer47errors.vtc

Re: [PATCH] guard tests that require pcre

2020-05-04 Thread Christopher Faulet
Le 04/05/2020 à 07:46, William Lallemand a écrit : On Fri, May 01, 2020 at 12:57:06PM +0500, Илья Шипицин wrote: The following tests require pcre support: reg-tests/checks/4be_1srv_smtpchk_httpchk_layer47errors.vtc reg-tests/checks/tls_health_checks.vtc Hello Ilya, I'm surprised because I