Re: DOC: Update documentation / comments to be gender neutral

2020-07-26 Thread Willy Tarreau
On Mon, Jul 27, 2020 at 12:10:02AM +0200, Tim Düsterhus wrote: > Willy, > > Am 26.07.20 um 22:34 schrieb Willy Tarreau: > > Just a small point, Jackie, as I noticed you fixed several bad constructs > > of "he" instead of "it", it's worth noting that in some latin languages > > (like French or

Re: DOC: Update documentation / comments to be gender neutral

2020-07-26 Thread Tim Düsterhus
Willy, Am 26.07.20 um 22:34 schrieb Willy Tarreau: > Just a small point, Jackie, as I noticed you fixed several bad constructs > of "he" instead of "it", it's worth noting that in some latin languages > (like French or Spanish), a number of common words are arbitrarily male > or female. A car is

Re: SRV records resolution failure if Authority section is present

2020-07-26 Thread Willy Tarreau
Thanks Jérôme, CCing Baptiste for approval (in case we've missed anything, I'm clueless about DNS). Willy On Sun, Jul 26, 2020 at 06:04:38PM +0200, Jerome Magnin wrote: > Hi Tim, > > On Sun, Jul 26, 2020 at 05:47:00PM +0200, Tim Düsterhus wrote: > > Jerome, > > > > Regarding the commit

Re: DOC: Update documentation / comments to be gender neutral

2020-07-26 Thread Willy Tarreau
Hi, On Sun, Jul 26, 2020 at 07:54:17PM +0200, Tim Düsterhus wrote: > Jackie, > > Am 26.07.20 um 19:02 schrieb Jackie Tapia: > > Thanks for the suggestion, Tim. > > > > That commit message sounds good to me. > > > > Your patch looks good to me now. I've put Willy into Cc to perform the > final

Re: DOC: Update documentation / comments to be gender neutral

2020-07-26 Thread Tim Düsterhus
Jackie, Am 26.07.20 um 19:02 schrieb Jackie Tapia: > Thanks for the suggestion, Tim. > > That commit message sounds good to me. > Your patch looks good to me now. I've put Willy into Cc to perform the final review and commit the patch. Best regards Tim Düsterhus

Re: DOC: Update documentation / comments to be gender neutral

2020-07-26 Thread Jackie Tapia
Thanks for the suggestion, Tim. That commit message sounds good to me. On Sun, Jul 26, 2020 at 11:49 AM Tim Düsterhus wrote: > Jackie, > > Am 26.07.20 um 18:36 schrieb Jackie Tapia: > > I've attached an updated patch. > > > Thank you, the Diff LGTM now (however I did not check whether you

Re: DOC: Update documentation / comments to be gender neutral

2020-07-26 Thread Tim Düsterhus
Jackie, Am 26.07.20 um 18:36 schrieb Jackie Tapia: > I've attached an updated patch. > Thank you, the Diff LGTM now (however I did not check whether you missed any gendered phrasing). Unfortunately it appears that you missed by remark regarding the missing commit message body. Please make sure

Re: DOC: Update documentation / comments to be gender neutral

2020-07-26 Thread Jackie Tapia
I've attached an updated patch. Thanks! On Sun, Jul 26, 2020 at 10:58 AM Jackie Tapia wrote: > Thank you for the feedback! I'll make those changes. > > On Thu, Jul 23, 2020 at 2:14 AM Tim Düsterhus wrote: > >> Jackie, >> >> First: I'm a community contributor, so my review might not

Re: SRV records resolution failure if Authority section is present

2020-07-26 Thread Jerome Magnin
Hi Tim, On Sun, Jul 26, 2020 at 05:47:00PM +0200, Tim Düsterhus wrote: > Jerome, > > Regarding the commit message: Please add backporting information to the > end of the commit message body (I believe it should be 2.2+). You're right the commit I mentionned in the message was indeed introduced

Re: DOC: Update documentation / comments to be gender neutral

2020-07-26 Thread Jackie Tapia
Thank you for the feedback! I'll make those changes. On Thu, Jul 23, 2020 at 2:14 AM Tim Düsterhus wrote: > Jackie, > > First: I'm a community contributor, so my review might not necessarily > reflect that of the HAProxy project. I'm also not a native English speaker. > > Regarding your patch I

Re: SRV records resolution failure if Authority section is present

2020-07-26 Thread Tim Düsterhus
Jerome, Am 26.07.20 um 17:25 schrieb Jerome Magnin: > Please find a proper fix attached. We already know if we have entries in > the Authority section (dns_p->header.nscount > 0), so just skip them > when they are present and only use the Additional records. Regarding the commit message: Please

SRV records resolution failure if Authority section is present

2020-07-26 Thread Jerome Magnin
On Sun, Jul 26, 2020 at 01:21:45PM +0200, Jerome Magnin wrote: > as I was trying to reproduce the issue with DNS Service Discovery with > SRV records reported in issue #775 I encountered a different issue. > > I am using bind as a dns server, and its answers contain an Authority > field before

haproxy@formilux.org

2020-07-26 Thread Jerome Magnin
Hi, as I was trying to reproduce the issue with DNS Service Discovery with SRV records reported in issue #775 I encountered a different issue. I am using bind as a dns server, and its answers contain an Authority field before the Additional records that can be made use of since 13a9232eb

[PATCH] suppress "return value is not checked" warnings

2020-07-26 Thread Илья Шипицин
Hello, cleanup patch attached. Ilya Shipitcin From e5a49969d374e3e8e9da695dca48cb6fa82ca13d Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sun, 26 Jul 2020 15:01:10 +0500 Subject: [PATCH] CLEANUP: suppress coverity warnings Coverity is not happy when return value is not examined. Those

QUIC-LB: Generating Routable QUIC Connection IDs

2020-07-26 Thread Aleksandar Lazic
Hi. Have you seen this Draft? https://datatracker.ietf.org/doc/draft-ietf-quic-load-balancers/ Because there are a lot of QUIC Drafts there and 2.2 is released it would be nice to get some update about the QUIC state in HAProxy ;-). https://datatracker.ietf.org/doc/search/?name=QUIC=on=on