[PATCH] unveal the power of BoringSSL by setting its own version back to 1.1.1

2020-11-21 Thread Илья Шипицин
hopefully final BoringSSL patches this week. Ilya From bebe09e8e1aaf89f12394322fa6a0387d4232f0a Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 21 Nov 2020 23:10:04 +0500 Subject: [PATCH 1/3] CLEANUP: remove unused function "ssl_sock_is_ckch_valid" "ssl_sock_is_ckch_valid" is not used a

Re: [PATCH 3/3] CI: Set DEBUG=-DDEBUG_STRICT=1 in GitHub Actions

2020-11-21 Thread Willy Tarreau
On Sat, Nov 21, 2020 at 06:52:52PM +0100, Tim Düsterhus wrote: > Willy, > > Am 21.11.20 um 18:49 schrieb Willy Tarreau: > > On Sat, Nov 21, 2020 at 06:46:46PM +0100, Tim Düsterhus wrote: > >>> 2) make DEBUG_STRICT=1 default and only option > >> > >> This is what I did. Anything crashing by using D

Re: [PATCH 3/3] CI: Set DEBUG=-DDEBUG_STRICT=1 in GitHub Actions

2020-11-21 Thread Илья Шипицин
сб, 21 нояб. 2020 г. в 22:55, Tim Düsterhus : > Ilya, > > Am 21.11.20 um 18:51 schrieb Илья Шипицин: > >>> there's single job configuration without strict debug > >>> https://github.com/haproxy/haproxy/blob/master/.travis.yml#L66 > >>> > >>> I think there are couple of options available > >>> > >>

Re: [PATCH 3/3] CI: Set DEBUG=-DDEBUG_STRICT=1 in GitHub Actions

2020-11-21 Thread Tim Düsterhus
Ilya, Am 21.11.20 um 18:51 schrieb Илья Шипицин: >>> there's single job configuration without strict debug >>> https://github.com/haproxy/haproxy/blob/master/.travis.yml#L66 >>> >>> I think there are couple of options available >>> >>> 1) add similar job definition to github actions >>> >>> 2) mak

Re: [PATCH 3/3] CI: Set DEBUG=-DDEBUG_STRICT=1 in GitHub Actions

2020-11-21 Thread Tim Düsterhus
Willy, Am 21.11.20 um 18:49 schrieb Willy Tarreau: > On Sat, Nov 21, 2020 at 06:46:46PM +0100, Tim Düsterhus wrote: >>> 2) make DEBUG_STRICT=1 default and only option >> >> This is what I did. Anything crashing by using DEBUG_STRICT is a bug by >> definition (compared to ASAN which might or might

Re: [PATCH 3/3] CI: Set DEBUG=-DDEBUG_STRICT=1 in GitHub Actions

2020-11-21 Thread Илья Шипицин
сб, 21 нояб. 2020 г. в 22:46, Tim Düsterhus : > Ilya, > > Am 21.11.20 um 18:38 schrieb Илья Шипицин: > > there's single job configuration without strict debug > > https://github.com/haproxy/haproxy/blob/master/.travis.yml#L66 > > > > I think there are couple of options available > > > > 1) add sim

Re: [PATCH 3/3] CI: Set DEBUG=-DDEBUG_STRICT=1 in GitHub Actions

2020-11-21 Thread Willy Tarreau
On Sat, Nov 21, 2020 at 06:46:46PM +0100, Tim Düsterhus wrote: > > 2) make DEBUG_STRICT=1 default and only option > > This is what I did. Anything crashing by using DEBUG_STRICT is a bug by > definition (compared to ASAN which might or might not be a bug). It's > either a real bug or an incorrect

Re: [PATCH 3/3] CI: Set DEBUG=-DDEBUG_STRICT=1 in GitHub Actions

2020-11-21 Thread Tim Düsterhus
Ilya, Am 21.11.20 um 18:38 schrieb Илья Шипицин: > there's single job configuration without strict debug > https://github.com/haproxy/haproxy/blob/master/.travis.yml#L66 > > I think there are couple of options available > > 1) add similar job definition to github actions > > 2) make DEBUG_STRIC

Re: [PATCH 3/3] CI: Set DEBUG=-DDEBUG_STRICT=1 in GitHub Actions

2020-11-21 Thread Илья Шипицин
there's single job configuration without strict debug https://github.com/haproxy/haproxy/blob/master/.travis.yml#L66 I think there are couple of options available 1) add similar job definition to github actions 2) make DEBUG_STRICT=1 default and only option also, we run ERR=1 for a while for v

Re: [PATCH 1/3] BUILD: Make DEBUG part of .build_opts

2020-11-21 Thread Willy Tarreau
On Sat, Nov 21, 2020 at 06:07:58PM +0100, Tim Duesterhus wrote: > This forces a recompilation if the value of DEBUG= changes. I thought it was the case, thanks for catching this! All 3 patches merged now. Willy

[PATCH 3/3] CI: Set DEBUG=-DDEBUG_STRICT=1 in GitHub Actions

2020-11-21 Thread Tim Duesterhus
This was missing when migrating from Travis. --- .github/workflows/compliance.yml | 1 + .github/workflows/vtest.yml | 1 + .github/workflows/windows.yml| 1 + 3 files changed, 3 insertions(+) diff --git a/.github/workflows/compliance.yml b/.github/workflows/compliance.yml index d778ee42

[PATCH 2/3] BUILD: Show the value of DEBUG= in haproxy -vv

2020-11-21 Thread Tim Duesterhus
Previously this was not visible after building. --- Makefile | 1 + src/haproxy.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/Makefile b/Makefile index ff2084dd1..dd85e51a2 100644 --- a/Makefile +++ b/Makefile @@ -919,6 +919,7 @@ src/haproxy.o: src/haproxy.c $(DEP)

[PATCH 1/3] BUILD: Make DEBUG part of .build_opts

2020-11-21 Thread Tim Duesterhus
This forces a recompilation if the value of DEBUG= changes. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index b93b0a872..ff2084dd1 100644 --- a/Makefile +++ b/Makefile @@ -878,7 +878,7 @@ help: # Used only to force a rebuild if some build o

[ANNOUNCE] haproxy-2.4-dev1

2020-11-21 Thread Willy Tarreau
Hi, HAProxy 2.4-dev1 was released on 2020/11/21. It added 107 new commits after version 2.4-dev0. Let me say that despite having spent quite some time recently on a few really irritating bugs, I'm quite happy to see that the new development cycle starts to pay off. It's probably the first ever ne

Re: [PATCH] DOC: clarify how to create a fallback crt

2020-11-21 Thread Joao Morais
> Em 21 de nov de 2020, à(s) 12:00, William Lallemand > escreveu: > > On Sat, Nov 21, 2020 at 07:48:48AM -0300, Joao Morais wrote: >> >> The attached patch adds some clarification on how one can declare a >> proper fallback certificate using crt-list. Feel free to ask me to >> tune verbosity

Re: [PATCH] DOC: clarify how to create a fallback crt

2020-11-21 Thread William Lallemand
On Sat, Nov 21, 2020 at 07:48:48AM -0300, Joao Morais wrote: > > The attached patch adds some clarification on how one can declare a > proper fallback certificate using crt-list. Feel free to ask me to > tune verbosity to a higher or lower level. > That's actually a bit confusing, because the fi

Re: [PATCH] DOC: clarify how to create a fallback crt

2020-11-21 Thread William Lallemand
On Sat, Nov 21, 2020 at 07:48:48AM -0300, Joao Morais wrote: -- William Lallemand 0001-DOC-clarify-how-to-create-a-fallback-crt.patch Description: Binary data

Re: [PATCH] minor bug + http-request del-header supporting -m flag

2020-11-21 Thread Willy Tarreau
Hi Maciej, On Sat, Nov 21, 2020 at 03:29:51PM +0100, Maciej Zdeb wrote: > Hi, > > Willy thanks for clarification about lfs_file, I've removed it from patch. > As Christopher mentioned, when developing the patch I've noticed the > comment that when "action_ptr" is set, "action" can be set to any >

Re: [2.2.5] High cpu usage after switch to threads

2020-11-21 Thread Maciej Zdeb
sob., 21 lis 2020 o 07:13 Willy Tarreau napisał(a): > So I guess we'll use you as a beta tester once we're starting to see > promising solutions ;-) > I'll test it happily :)

Re: [PATCH] minor bug + http-request del-header supporting -m flag

2020-11-21 Thread Maciej Zdeb
Hi, Willy thanks for clarification about lfs_file, I've removed it from patch. As Christopher mentioned, when developing the patch I've noticed the comment that when "action_ptr" is set, "action" can be set to any meaningful value. However, I also had doubts about it. :) Christopher I fixed the p

Re: [PATCH] DOC: clarify how to create a fallback crt

2020-11-21 Thread Willy Tarreau
On Sat, Nov 21, 2020 at 07:48:48AM -0300, Joao Morais wrote: > > The attached patch adds some clarification on how one can declare a proper > fallback certificate using crt-list. Feel free to ask me to tune verbosity to > a higher or lower level. Applied, thank you Joao! Willy

Re: [PATCH] run "apt-get update" during github actions CI

2020-11-21 Thread Илья Шипицин
I planned to have a look whether dedicated github action "install and cache locally" exists for ubuntu "apt-get update" and install itself add internet calls. we lose time on that. сб, 21 нояб. 2020 г. в 17:53, Tim Düsterhus : > Ilya, > Willy, > > Am 21.11.20 um 10:47 schrieb Willy Tarreau: > >

Re: [PATCH] run "apt-get update" during github actions CI

2020-11-21 Thread Tim Düsterhus
Ilya, Willy, Am 21.11.20 um 10:47 schrieb Willy Tarreau: > Hi Ilya, > > On Sat, Nov 21, 2020 at 02:05:01PM +0500, ??? wrote: >> Hello, >> >> ubuntu somehow needs it, no idea why does not apt-get do it itself. > > Thanks, I took it, but please, please, the justification you provide > abo

[PATCH] DOC: clarify how to create a fallback crt

2020-11-21 Thread Joao Morais
The attached patch adds some clarification on how one can declare a proper fallback certificate using crt-list. Feel free to ask me to tune verbosity to a higher or lower level. 0001-DOC-clarify-how-to-create-a-fallback-crt.patch Description: Binary data

Re: discuss, how better guard SSL_CTX_set_ciphersuites ?

2020-11-21 Thread Willy Tarreau
On Sat, Nov 21, 2020 at 02:53:05PM +0500, ??? wrote: > here we go! Merged, thank you! Willy

Re: [PATCH 0/2] CI Updates

2020-11-21 Thread Willy Tarreau
On Sat, Nov 21, 2020 at 02:55:58PM +0500, ??? wrote: > > Based on this, Ilya, do you have all the info you need and should I > > take this or does this need more discussion ? > > > > yes, I clarified it for myself Perfect, now merged, thanks all! Willy

Re: [PATCH 0/2] CI Updates

2020-11-21 Thread Илья Шипицин
сб, 21 нояб. 2020 г. в 14:48, Willy Tarreau : > On Fri, Nov 20, 2020 at 12:38:02PM +0100, Tim Düsterhus wrote: > > > yes, I wonder how it is supposed to work. > > > first, GH actions is supposed to run matrix.py in order to generate > some > > > scheduled jobs. > > > > It's simple, this part of th

Re: discuss, how better guard SSL_CTX_set_ciphersuites ?

2020-11-21 Thread Илья Шипицин
here we go! сб, 21 нояб. 2020 г. в 14:40, Willy Tarreau : > On Sat, Nov 21, 2020 at 02:16:21PM +0500, ??? wrote: > > ??, 21 . 2020 ?. ? 10:18, Willy Tarreau : > > > > > On Fri, Nov 20, 2020 at 02:10:33AM +0500, ??? wrote: > > > > I'd like to get rid of OPENSSL_VERSION as muc

Re: [PATCH 0/2] CI Updates

2020-11-21 Thread Willy Tarreau
On Fri, Nov 20, 2020 at 12:38:02PM +0100, Tim Düsterhus wrote: > > yes, I wonder how it is supposed to work. > > first, GH actions is supposed to run matrix.py in order to generate some > > scheduled jobs. > > It's simple, this part of the patch is responsible for that: > > -run: python3

Re: [PATCH] run "apt-get update" during github actions CI

2020-11-21 Thread Willy Tarreau
Hi Ilya, On Sat, Nov 21, 2020 at 02:05:01PM +0500, ??? wrote: > Hello, > > ubuntu somehow needs it, no idea why does not apt-get do it itself. Thanks, I took it, but please, please, the justification you provide above is the essential part of your change and belongs to the commit messag

Re: [PATCH] minor bug + http-request del-header supporting -m flag

2020-11-21 Thread Willy Tarreau
On Sat, Nov 21, 2020 at 09:42:32AM +0100, Christopher Faulet wrote: > ..Le 21/11/2020 à 06:15, Willy Tarreau a écrit : > > I looked at the patch, it's OK regarding this and most of the other > > stuff, except one thing, it mixes ACT_HTTP_* and PAT_MATCH_* and there > > is some breakage there, becau

Re: discuss, how better guard SSL_CTX_set_ciphersuites ?

2020-11-21 Thread Willy Tarreau
On Sat, Nov 21, 2020 at 02:16:21PM +0500, ??? wrote: > ??, 21 . 2020 ?. ? 10:18, Willy Tarreau : > > > On Fri, Nov 20, 2020 at 02:10:33AM +0500, ??? wrote: > > > I'd like to get rid of OPENSSL_VERSION as much as possible. > > > what would be better for guarding TLS13 ciphers

Re: discuss, how better guard SSL_CTX_set_ciphersuites ?

2020-11-21 Thread Илья Шипицин
сб, 21 нояб. 2020 г. в 10:18, Willy Tarreau : > On Fri, Nov 20, 2020 at 02:10:33AM +0500, ??? wrote: > > I'd like to get rid of OPENSSL_VERSION as much as possible. > > what would be better for guarding TLS13 ciphers manipulation ? > > > > approach 1 (macro defined in openssl-compat.h) >

[PATCH] run "apt-get update" during github actions CI

2020-11-21 Thread Илья Шипицин
Hello, ubuntu somehow needs it, no idea why does not apt-get do it itself. Ilya From 0803e7bedff24f98cab5221999bf591bd4b8d23c Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 21 Nov 2020 13:42:19 +0500 Subject: [PATCH] CI: Github Action: run "apt-get update" before packages restore ---

Re: [PATCH] minor bug + http-request del-header supporting -m flag

2020-11-21 Thread Christopher Faulet
..Le 21/11/2020 à 06:15, Willy Tarreau a écrit : I looked at the patch, it's OK regarding this and most of the other stuff, except one thing, it mixes ACT_HTTP_* and PAT_MATCH_* and there is some breakage there, because the HTTP action being set to PAT_MATCH_STR for example sets it to value 5 whi