Re: OPTIM : IPv6 literal address parsing

address or not. Malformed IP addresses, whatever its format, will be rejected. -- Mildis Le 2015-10-13 21:05, Willy Tarreau a écrit : On Tue, Oct 13, 2015 at 08:10:03PM +0200, Mildis wrote: Le 2015-10-10 15:49, Willy Tarreau a écrit : >Hi, >@@ -856,11 +883,28 @@ struct sockaddr_s

Re: OPTIM : IPv6 literal address parsing

to do arithmetic around numerous strlen calls. Also, I’ve declared the address buffer of with a size of 48 as it looks that INET6_ADDRSTRLEN is sometime define’d as 48, sometimes as 46. -- Mildis Le 2015-10-23 01:02, Willy Tarreau a écrit : Hi, On Thu, Oct 22, 2015 at 08:26:01PM +0200, Mildis

Re: OPTIM : IPv6 literal address parsing

are not respectively opening and closing square brackets, it fails. I’m still trying to figure a good implementation of the port parser to make the colon optional for IPv6 addresses. Regards, -- Mildis Le 2015-10-10 15:49, Willy Tarreau a écrit : Hi, On Sat, Oct 10, 2015 at 01:50:46PM +0200, Mildis wrote

Re: OPTIM : IPv6 literal address parsing

Aw, man ! My C skills are so rusted :) I’ll look at your comments and correct all this. BTW, a bit off-topic : have you looked at a code-review server like gerrit ? Quite useful for multi-round patchset submission like this one. -- Mildis Le 2015-10-10 15:49, Willy Tarreau a écrit : Hi

Re: OPTIM : IPv6 literal address parsing

as IPv6 with port but forbid ‘[2001:db8::1234]:’ and ‘2001:db8::1234’ Would it makes sense to you ? mildis Le 2015-10-06 11:11, Willy Tarreau a écrit : On Mon, Oct 05, 2015 at 06:42:52PM +0200, Mildis wrote: Le 2015-10-05 18:07, David du Colombier a écrit : >>It looks like IPv6 parsing ma

RE: OPTIM : IPv6 literal address parsing

. Mildis Le 2015-10-06 19:39, Lukas Tribus a écrit : Hi Mildis, And regarding "2001:db8::1234", you can't forbit it simply because you don't know if 1234 is a port or not in this context, as you have reported. Sure. In this very specific case 1234 can’t be a port as 2001:db8:: is the

Re: OPTIM : IPv6 literal address parsing

[2001:db8::1234:5678]", "[2001:db8::1234:5678]:", "[2001:db8::1234:5678]:80", "[::]", "[::]:", "[::]:80" -- Mildis Le 2015-10-06 17:47, Willy Tarreau a écrit : Hi, On Tue, Oct 06, 2015 at 05:34:07PM +0200, Mildis wrote: Hi Willy, My bad : in the doc, I d

Re: OPTIM : IPv6 literal address parsing

are of the context it’s called ? Regards, Mildis

Re: OPTIM : IPv6 literal address parsing

ow if 1234 is a port or not in this context, as you have reported. Sure. In this very specific case 1234 can’t be a port as 2001:db8:: is then a subnet. Is a subnet a valid entry in this context ? Otherwise it's OK for me. Don’t forget to update the doc accordingly! I will. Mildis

OPTIM : IPv6 literal address parsing

://gist.github.com/mildis/4ab2c3ff3a9ad56c9970) The proposed patch allows IPv6 literal addresses to be enclose in square brackets as per https://www.ietf.org/rfc/rfc2732.txt MildisFrom 5ab1cdaffbd48d5776dc94365c7581c6b0b84124 Mon Sep 17 00:00:00 2001 From: mildis <m...@mildis.org> Date: Mon,

MINOR: ssl: close ssl key file on error

Hi, Please find attached a patch which corrects ssl_sock.c. It closes explicitly the FILE opened to read the ssl key file when parsing fails to find a valid key. Previous behavior : returned from the function after having set the error flags but not closed the file. Regards, Mildis 0001

Re: SonarSource static code analysis

favorites.Regards,MildisLe 17 juin 2016 à 18:01, Willy Tarreau <w...@1wt.eu> a écrit :Hi Mildis,On Thu, Jun 16, 2016 at 09:09:08PM +0200, Mildis wrote:Hi list, Hi Willy,At my job, we are using SonarSource???s SonarQube code analysis tool to get insights of the code health.This tool

Use regex for backend selection

serverN.domain.tld use_backend bck-server1 if to-server1 use_backend bck-server2 if to-server2 … use_backend bck-serverN if to-serverN by something more generic like use_backend bck-\1 if hdr_reg(host) -i (.*).domain.tld but I can’t find a way to make it work. Am I on the right path ? Thanks, Mildis

SonarSource static code analysis

AProxy to be analyzed so ‘little hands’ could help solving bugs pointed by the tool. Do you think HAProxy could benefit this tool ? Will you agree for HAProxy to be included in the SonarSource portal ? Regards, Mildis

Re: Diagnose a PD-- status

lines, it went OK. However, I still can’t figure out what is causing this behavior : there are many other calls to the same URL. Any clues ? Regards, mildis > Le 1 nov. 2017 à 12:37, Mildis <m...@mildis.org> a écrit : > > Hi, > > I got a request ending in a PD status. &g

Diagnose a PD-- status

? Maybe make haproxy log the reason why it ended in PD ? Thanks, mildis

Re: Diagnose a PD-- status

Christopher, We couldn’t had the error reproduced today : both dataset and client tool were updated. However, I keep the configuration options at hand if I ever need to debug this issue further again. Thanks for your time on this. Regards, Mildis > Le 7 nov. 2017 à 10:14, Christopher Fau

Re: Diagnose a PD-- status

ult OK select : pref=150, test result OK Total: 3 (3 usable), will use epoll. Available filters : [COMP] compression [TRACE] trace [SPOE] spoe haproxy.cfg Description: Binary data Mildis > Le 6 nov. 2017 à 10:10, Christopher Faulet <cfau...@haproxy.com> a

Domain fronting

domain fronting by forcing SNI and Host header to be the same ? Maybe add an optional parameter like "strict_sni_host" ? Regards, Mildis

Re: IPv6 : bug in unique-id-format and hex transormation

y. I did the former. So the results should be : - 192.168.0.1 => C0A80001 - 2001:db8:0:85a3::ac1f:8001 => 20010db885a3ac1f8001 - :::192.168.0.1 => C0A80001 Applying address compression without commas is not feasible. The argument of saving space with hex will n

Re: IPv6 : bug in unique-id-format and hex transormation

> Le 29 juin 2018 à 14:26, Mildis a écrit : > >> >> Le 29 juin 2018 à 04:51, Willy Tarreau a écrit : >> >> Hi, >> >> On Thu, Jun 28, 2018 at 11:48:24AM +0200, m...@mildis.org wrote: >>> >>> Hi, >>> >&

Patch : remove useless test

Hi, Very minor patch : remove a useless test that always evaluate to false. 0001-MINOR-same-length-test-is-made-just-before.patch Description: Binary data Mildis

Re: PATCH : mux_h2 h2c pointer deref

OK. Here you are. 0001-BUG-MINOR-checks-queues-null-deref.patch Description: Binary data 0001-BUG-MINOR-h2-null-deref.patch Description: Binary data Mildis > Le 2 oct. 2018 à 04:23, Willy Tarreau a écrit : > > Hi, > > On Sun, Sep 23, 2018 at 06:18:37PM +0200, Mild

PATCH : checks : queues null-deref

HI, Here is a patch for a null-deref. It checks if queues exists before working on it. 0001-BUG-MINOR-checks-queues-null-deref.patch Description: Binary data Mildis

PATCH : mux_h2 h2c pointer deref

Hi, Here is a patch for a null-deref. It checks if h2c exists before working on it. 0001-BUG-MINOR-h2-null-deref.patch Description: Binary data Mildis

Re: RSA and ECC not working as expected

> Le 3 déc. 2018 à 23:05, Lukas Tribus a écrit : > > Hello Mildis, > > > On Mon, 3 Dec 2018 at 22:19, Mildis wrote: >> >> Hi, >> >> I'm using 1.8.14 and I tried to follow >> https://www.haproxy.com/blog/serving-ecc-and-rsa-certificates-

RSA and ECC not working as expected

ething ? Thanks, Mildis

Re: haproxy segfault

> Le 12 févr. 2019 à 21:26, Christopher Faulet a écrit : >> > Hi, > > A recent fix about a double free has been merge in HAProxy 1.9: > > http://git.haproxy.org/?p=haproxy-1.9.git;a=commit;h=451c5a88 > > > Maybe you've hit

Re: haproxy segfault

md to generate the coredump on crash. Even running haproxy by hand with ulimit -c unlimited does not generate a coredump. Even after a reboot, the +1e2000 offset is the same. > You can get a backtrace with the following command as soon as you have a > coredump > > gdb /usr/sbin/hapr

haproxy segfault

sp:7ffe6fd3f2f0 error:0 in haproxy[561e5b72d000+1e2000] "show errors" is empty. How could I diagnose further without impacting production too much ? Thanks, mildis

Re: haproxy 2.0 - stretch - libgcc_s.so.1

Le 24 juin 2019 à 19:32, Vincent Bernat a écrit : > > ❦ 24 juin 2019 19:08 +02, Tim Düsterhus : > >>> You can workaround this by not chrooting HAProxy. The problem is that >>> once chrooted, it cannot load the library. We should force libpthread to >>> preload this lib. >> >> This mailing list

haproxy 2.0 - stretch - libgcc_s.so.1

worker #1 (32363) exited with code 134 (Aborted) Is it something to be fixed by Vincent during the build for the packaging ? Thanks, Mildis

Re: haproxy 2.0 - stretch - libgcc_s.so.1

> Le 24 juin 2019 à 19:32, Vincent Bernat a écrit : > > ❦ 24 juin 2019 19:08 +02, Tim Düsterhus : > >>> You can workaround this by not chrooting HAProxy. The problem is that >>> once chrooted, it cannot load the library. We should force libpthread to >>> preload this lib. >> >> This mailing

Re: haproxy 2.0 - stretch - libgcc_s.so.1

> Le 27 juin 2019 à 09:08, Vincent Bernat a écrit : > > ❦ 27 juin 2019 09:06 +02, Mildis : > >>>>> You can workaround this by not chrooting HAProxy. The problem is that >>>>> once chrooted, it cannot load the library. We should