Re: [PATCH] MINOR: acl: Warn when an ACL is named 'or' or '||'

2020-02-06 Thread Tim Düsterhus
Willy, Am 06.02.20 um 16:37 schrieb Willy Tarreau: > Maybe you didn't reload the page or ended on an older tab ? > Apparently it was my browser cache. Hitting reload several times made it show up. All good now! Best regards Tim Düsterhus

Re: [PATCH] MINOR: acl: Warn when an ACL is named 'or' or '||'

2020-02-06 Thread Willy Tarreau
On Thu, Feb 06, 2020 at 04:31:36PM +0100, Tim Düsterhus wrote: > The committed patch is looking good. I'm not seeing anything in 2.1 > though, did you forget to push that branch? No here it's pushed: commit 9007a8d65d56e670aad97f60b66c36a52aab22c5 (HEAD -> master, flx04/master) Author: Tim

Re: [PATCH] MINOR: acl: Warn when an ACL is named 'or' or '||'

2020-02-06 Thread Tim Düsterhus
Willy, Am 06.02.20 um 16:19 schrieb Willy Tarreau: > On Thu, Feb 06, 2020 at 03:42:17PM +0100, Willy Tarreau wrote: >>> Feel free to either modify the patch yourself to make the adjustments >>> you want to see or let me know if you want me to make them. It might >>> require a bit more back and

Re: [PATCH] MINOR: acl: Warn when an ACL is named 'or' or '||'

2020-02-06 Thread Willy Tarreau
On Thu, Feb 06, 2020 at 03:42:17PM +0100, Willy Tarreau wrote: > > Feel free to either modify the patch yourself to make the adjustments > > you want to see or let me know if you want me to make them. It might > > require a bit more back and forth, though :-) > > OK I guess I can do them, sure.

Re: [PATCH] MINOR: acl: Warn when an ACL is named 'or' or '||'

2020-02-06 Thread Willy Tarreau
On Thu, Feb 06, 2020 at 03:33:45PM +0100, Tim Düsterhus wrote: > Willy, > > Am 06.02.20 um 15:24 schrieb Willy Tarreau: > > I was surprized because I discovered that we've always accepted empty > > expressions thus"if" without even a condition or "if or" are valid, which > > adds to the

Re: [PATCH] MINOR: acl: Warn when an ACL is named 'or' or '||'

2020-02-06 Thread Tim Düsterhus
Willy, Am 06.02.20 um 15:24 schrieb Willy Tarreau: > I was surprized because I discovered that we've always accepted empty > expressions thus"if" without even a condition or "if or" are valid, which > adds to the confusion. So your patch does indeed make sense. However we > don't need to test for

Re: [PATCH] MINOR: acl: Warn when an ACL is named 'or' or '||'

2020-02-06 Thread Willy Tarreau
Hi Tim, On Wed, Feb 05, 2020 at 09:00:50PM +0100, Tim Duesterhus wrote: (...) > Consider a configuration like this: > > > acl t always_true > > acl or always_false > > > > http-response set-header Foo Bar if t or t > > The 'or' within the condition will be treated as a logical disjunction > and