Re: patch: enable Coverity scan in travis-ci builds

[Илья Шипицин]

ср, 7 авг. 2019 г. в 13:45, Willy Tarreau :

> On Wed, Aug 07, 2019 at 01:15:28PM +0500,  ??? wrote:
> > btw, Willy, we can exclude some exotic build targets from "on push" to
> "on
> > cron"
> >
> > by changing "if: type != cron" --> "if: type == cron"
> >
> >
> > probably boringssl, cygwin, libressl ?
>
> I indeed think that all non-latest and non-mainstream versions could be
> daily only. I'm probably fine with keeping the latest libressl as it
> significantly increases coverage. Thus we could keep something like this
> "on push" :
>
>   - linux-glibc with threads+openssl 1.1.1 on x86 + gcc
>

I would leave this one with clang. We run ASAN on clang builds.
I will revisit this after I get running gcc with sanitizers (it does not
work as expected on travis-ci)



>   - linux-glibc with threads+libressl 2.9.2 on x86 + clang
>   - linux-glibc without SSL nor threads on x86 + clang or gcc (no
> preference)
>   - osx with openssl-1.1.1 + clang
>
> And these ones would be "on cron" :
>   - linux-ppc64le
>   - linux + openssl-1.1.0
>   - linux + openssl-1.0.2
>   - linux + libressl-2.8.3
>   - linux + libressl-2.7.5
>   - linux + boringssl
>   - linux+51d/tree
>   - cygwin
>
> Note that some variants could be combined to save on builds. For example
> we can have linux-ppc64le build with openssl-1.0.2 to test the two at once,
> and linux+openssl-1.1.0 test with 51d/tree. In practice we don't need the
> level of detail indicating what broke, we just need to know if we broke
> anything, so heavy combinations are welcome.
>
> Just my two cents,
> Willy
>

Re: patch: enable Coverity scan in travis-ci builds

[Dinko Korunic]

Hi,

This has been disabled as soon as we have started testing out Travis-CI 
integration with Coverity, so we are all good.
Cheers!


Kind regards,
D.

> On 7 Aug 2019, at 09:50, Илья Шипицин  wrote:
> 
> Dinko, can you please disable your schedule (is it cron or whatever) ?
> 
> ср, 7 авг. 2019 г. в 12:07, Willy Tarreau mailto:w...@1wt.eu>>:
> Hi Ilya,
> 
> On Tue, Aug 06, 2019 at 10:55:47AM +0500,  ??? wrote:
> > 1) follow to https://travis-ci.com/haproxy/haproxy/settings 
> > 
> > 
> > 
> > 2) setup COVERITY_SCAN_TOKEN = P6rHpv1618gwKWkVs7FfKQ
> > 
> > 3) setup daily schedule
> 
> All done now (with Dinko's new token). Thanks very much for the
> screenshot, it did help me.
> 
> Let's see how it goes now. It says it's scheduled in about a minute.
> 
> Willy

-- 
Dinko Korunic   ** Standard disclaimer applies **
Sent from OSF1 osf1v4b V4.0 564 alpha

Re: patch: enable Coverity scan in travis-ci builds

[Willy Tarreau]

On Wed, Aug 07, 2019 at 01:15:28PM +0500,  ??? wrote:
> btw, Willy, we can exclude some exotic build targets from "on push" to "on
> cron"
> 
> by changing "if: type != cron" --> "if: type == cron"
> 
> 
> probably boringssl, cygwin, libressl ?

I indeed think that all non-latest and non-mainstream versions could be
daily only. I'm probably fine with keeping the latest libressl as it
significantly increases coverage. Thus we could keep something like this
"on push" :

  - linux-glibc with threads+openssl 1.1.1 on x86 + gcc
  - linux-glibc with threads+libressl 2.9.2 on x86 + clang
  - linux-glibc without SSL nor threads on x86 + clang or gcc (no preference)
  - osx with openssl-1.1.1 + clang

And these ones would be "on cron" :
  - linux-ppc64le
  - linux + openssl-1.1.0
  - linux + openssl-1.0.2
  - linux + libressl-2.8.3
  - linux + libressl-2.7.5
  - linux + boringssl
  - linux+51d/tree
  - cygwin

Note that some variants could be combined to save on builds. For example
we can have linux-ppc64le build with openssl-1.0.2 to test the two at once,
and linux+openssl-1.1.0 test with 51d/tree. In practice we don't need the
level of detail indicating what broke, we just need to know if we broke
anything, so heavy combinations are welcome.

Just my two cents,
Willy

Re: patch: enable Coverity scan in travis-ci builds

[Илья Шипицин]

btw, Willy, we can exclude some exotic build targets from "on push" to "on
cron"

by changing "if: type != cron" --> "if: type == cron"


probably boringssl, cygwin, libressl ?

ср, 7 авг. 2019 г. в 12:07, Willy Tarreau :

> Hi Ilya,
>
> On Tue, Aug 06, 2019 at 10:55:47AM +0500,  ??? wrote:
> > 1) follow to https://travis-ci.com/haproxy/haproxy/settings
> >
> >
> > 2) setup COVERITY_SCAN_TOKEN = P6rHpv1618gwKWkVs7FfKQ
> >
> > 3) setup daily schedule
>
> All done now (with Dinko's new token). Thanks very much for the
> screenshot, it did help me.
>
> Let's see how it goes now. It says it's scheduled in about a minute.
>
> Willy
>

Re: patch: enable Coverity scan in travis-ci builds

[Илья Шипицин]

Dinko, can you please disable your schedule (is it cron or whatever) ?

ср, 7 авг. 2019 г. в 12:07, Willy Tarreau :

> Hi Ilya,
>
> On Tue, Aug 06, 2019 at 10:55:47AM +0500,  ??? wrote:
> > 1) follow to https://travis-ci.com/haproxy/haproxy/settings
> >
> >
> > 2) setup COVERITY_SCAN_TOKEN = P6rHpv1618gwKWkVs7FfKQ
> >
> > 3) setup daily schedule
>
> All done now (with Dinko's new token). Thanks very much for the
> screenshot, it did help me.
>
> Let's see how it goes now. It says it's scheduled in about a minute.
>
> Willy
>

Re: patch: enable Coverity scan in travis-ci builds

[Willy Tarreau]

Hi Ilya,

On Tue, Aug 06, 2019 at 10:55:47AM +0500,  ??? wrote:
> 1) follow to https://travis-ci.com/haproxy/haproxy/settings
> 
> 
> 2) setup COVERITY_SCAN_TOKEN = P6rHpv1618gwKWkVs7FfKQ
> 
> 3) setup daily schedule

All done now (with Dinko's new token). Thanks very much for the
screenshot, it did help me.

Let's see how it goes now. It says it's scheduled in about a minute.

Willy

Re: patch: enable Coverity scan in travis-ci builds

[Илья Шипицин]

oops, I forgot to remove list.
Dinko, can you please generate new token ?

вт, 6 авг. 2019 г. в 10:55, Илья Шипицин :

> great!
>
>
> next steps
>
> 1) follow to https://travis-ci.com/haproxy/haproxy/settings
>
>
> 2) setup COVERITY_SCAN_TOKEN = P6rHpv1618gwKWkVs7FfKQ
>
> 3) setup daily schedule
>
> (screen attached)
>
>
>
> вт, 6 авг. 2019 г. в 09:42, Willy Tarreau :
>
>> Hi Ilya, Dinko,
>>
>> On Fri, Aug 02, 2019 at 11:04:30PM +0500,  ??? wrote:
>> > Hello,
>> >
>> >
>> > please find attached patch. it enables coverity scans.
>> >
>> > also, couple of things need to be done within travis-ci:
>> >
>> > 1) specify daily schedule
>> > 2) specify coverity scan token (Dinko will provide it off list)
>>
>> OK thanks, now applied and pushed. Please let me know off-list about the
>> next steps.
>>
>> thanks,
>> Willy
>>
>

Re: patch: enable Coverity scan in travis-ci builds

[Илья Шипицин]

great!


next steps

1) follow to https://travis-ci.com/haproxy/haproxy/settings


2) setup COVERITY_SCAN_TOKEN = P6rHpv1618gwKWkVs7FfKQ

3) setup daily schedule

(screen attached)



вт, 6 авг. 2019 г. в 09:42, Willy Tarreau :

> Hi Ilya, Dinko,
>
> On Fri, Aug 02, 2019 at 11:04:30PM +0500,  ??? wrote:
> > Hello,
> >
> >
> > please find attached patch. it enables coverity scans.
> >
> > also, couple of things need to be done within travis-ci:
> >
> > 1) specify daily schedule
> > 2) specify coverity scan token (Dinko will provide it off list)
>
> OK thanks, now applied and pushed. Please let me know off-list about the
> next steps.
>
> thanks,
> Willy
>

Re: patch: enable Coverity scan in travis-ci builds

[Willy Tarreau]

Hi Ilya, Dinko,

On Fri, Aug 02, 2019 at 11:04:30PM +0500,  ??? wrote:
> Hello,
> 
> 
> please find attached patch. it enables coverity scans.
> 
> also, couple of things need to be done within travis-ci:
> 
> 1) specify daily schedule
> 2) specify coverity scan token (Dinko will provide it off list)

OK thanks, now applied and pushed. Please let me know off-list about the
next steps.

thanks,
Willy

patch: enable Coverity scan in travis-ci builds

[Илья Шипицин]

Hello,


please find attached patch. it enables coverity scans.

also, couple of things need to be done within travis-ci:

1) specify daily schedule
2) specify coverity scan token (Dinko will provide it off list)


thanks!
Ilya Shipitsin
From 9c7e0bcec2629f7cf128254c1bb1e8cdccc723cb Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin 
Date: Fri, 2 Aug 2019 22:59:03 +0500
Subject: [PATCH] BUILD: travis-ci: enable daily Coverity scan

Coverity scan takes some time, also we are limited to 3 scans per day.
So, running it once a day seem to be good idea.
---
 .travis.yml | 22 ++
 1 file changed, 22 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index c1d7b2d11..bf4e9d3cd 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -23,39 +23,61 @@ cache:
 matrix:
   include:
   - os: linux
+if: type != cron
 compiler: gcc
 env: TARGET=linux-glibc FIFTYONEDEGREES_SRC="contrib/51d/src/trie"
   - os: linux-ppc64le
+if: type != cron
 compiler: gcc
 env: TARGET=linux-glibc OPENSSL_VERSION=1.1.1c LABEL="linux-ppc64le"
   - os: linux
+if: type != cron
 compiler: clang
 env: TARGET=linux-glibc OPENSSL_VERSION=1.1.1c
   - os: linux
+if: type == cron
+compiler: clang
+env: TARGET=linux-glibc OPENSSL_VERSION=1.1.1c COVERITY_SCAN_PROJECT_NAME="Haproxy" COVERITY_SCAN_BRANCH_PATTERN="*" COVERITY_SCAN_NOTIFICATION_EMAIL="chipits...@gmail.com" COVERITY_SCAN_BUILD_COMMAND="make CC=clang TARGET=$TARGET $FLAGS 51DEGREES_SRC=$FIFTYONEDEGREES_SRC"
+script:
+  - |
+if [ ! -z ${COVERITY_SCAN_TOKEN+x} ]; then
+  make -C contrib/wurfl
+  curl -s "https://scan.coverity.com/scripts/travisci_build_coverity_scan.sh; | bash || true
+fi
+  - os: linux
+if: type != cron
 compiler: clang
 env: TARGET=linux-glibc OPENSSL_VERSION=1.1.0j
   - os: linux
+if: type != cron
 compiler: clang
 env: TARGET=linux-glibc OPENSSL_VERSION=1.0.2r
   - os: linux
+if: type != cron
 compiler: clang
 env: TARGET=linux-glibc LIBRESSL_VERSION=2.9.2
   - os: linux
+if: type != cron
 compiler: clang
 env: TARGET=linux-glibc LIBRESSL_VERSION=2.8.3
   - os: linux
+if: type != cron
 compiler: clang
 env: TARGET=linux-glibc LIBRESSL_VERSION=2.7.5 EXTRA_OBJS="contrib/prometheus-exporter/service-prometheus.o"
   - os: linux
+if: type != cron
 compiler: clang
 env: TARGET=linux-glibc BORINGSSL=yes
   - os: linux
+if: type != cron
 compiler: clang
 env: TARGET=linux-glibc FLAGS=
   - os: osx
+if: type != cron
 compiler: clang
 env: TARGET=osx FLAGS="USE_OPENSSL=1" OPENSSL_VERSION=1.1.1c
   - os: windows
+if: type != cron
 install:
   - choco install bash make libssl-devel cygwin-devel gcc-core libgcc1 binutils lua-devel libpcre-devel zlib-devel --source cygwin
 script:
-- 
2.20.1