RE: [PATCH] DOC: Fix a few grammar/spelling issues and casing of HAProxy
Hey Willy, > -Original Message- > From: Willy Tarreau > Sent: Sunday, May 9, 2021 12:07 AM > To: Daniel Corbett > Cc: haproxy@formilux.org > Subject: Re: [PATCH] DOC: Fix a few grammar/spelling issues and casing of > HAProxy > > Hi Daniel, > ... > Thank you for going through this painful task. After carefully reviewing it, I > only found two that I had to revert (one occurrence of "HAProxy -vv" > and the process name for "kill"), and applied it. > My pleasure. I tried to avoid those situations with the binary. Thanks for catching that! > There's still the version reported on startup that I want to fix (and will have to > adjust the regtest script as well I think). It's been consistently reported as > "HA-Proxy" for 20 years and it's the only place I can think of where it's > reported like this. I think it was Bertrand who proposed a patch for this a few > months ago but it had to be split. Ah yes! For some reason I thought that was merged already. I see you have now fixed it. That's great! Thanks Willy. Have a great day. -- Daniel
Re: [PATCH] DOC: Fix a few grammar/spelling issues and casing of HAProxy
On Sun, May 09, 2021 at 01:33:11AM -0400, Daniel Corbett wrote: > Sorry, I forgot to add the area the patch touches to the commit title. > New patch attached to add that. Too late, already merged, but don't worry, it's neither the first one nor the last one :-) Willy
RE: [PATCH] DOC: Fix a few grammar/spelling issues and casing of HAProxy
Sorry, I forgot to add the area the patch touches to the commit title. New patch attached to add that. Thanks, -- Daniel 0001-DOC-config-Fix-a-few-grammar-spelling-issues-and-cas.patch Description: Binary data
Re: [PATCH] DOC: Fix a few grammar/spelling issues and casing of HAProxy
Hi Daniel, On Sat, May 08, 2021 at 12:57:57PM -0400, Daniel Corbett wrote: > Hello, > > This patch fixes a few grammar and spelling issues in configuration.txt. > It was also noted that there was a wide range of case usage > (i.e. haproxy, HAproxy, HAProxy, etc... ). This patch updates them > all to be consistently "HAProxy" except where a binary is mentioned. Thank you for going through this painful task. After carefully reviewing it, I only found two that I had to revert (one occurrence of "HAProxy -vv" and the process name for "kill"), and applied it. There's still the version reported on startup that I want to fix (and will have to adjust the regtest script as well I think). It's been consistently reported as "HA-Proxy" for 20 years and it's the only place I can think of where it's reported like this. I think it was Bertrand who proposed a patch for this a few months ago but it had to be split. Willy
[PATCH] DOC: Fix a few grammar/spelling issues and casing of HAProxy
Hello, This patch fixes a few grammar and spelling issues in configuration.txt. It was also noted that there was a wide range of case usage (i.e. haproxy, HAproxy, HAProxy, etc... ). This patch updates them all to be consistently "HAProxy" except where a binary is mentioned. Thanks, -- Daniel 0001-DOC-Fix-a-few-grammar-spelling-issues-and-casing-of-.patch Description: Binary data
