Re: [PATCH] Improve and simplify systemd-wrapper.

2014-07-29 Thread Willy Tarreau
Hi Conrad, On Tue, Jul 29, 2014 at 12:12:00AM +0200, Conrad Hoffmann wrote: > Hello, > > attached are the first two patches, one fixing the actual bug I > encountered and one just tidying up the signal handling a little. More > to come. > > Are they ok like this? Perfect, thank you very much fo

Re: [PATCH] Improve and simplify systemd-wrapper.

2014-07-28 Thread Conrad Hoffmann
Hello, attached are the first two patches, one fixing the actual bug I encountered and one just tidying up the signal handling a little. More to come. Are they ok like this? Cheers, Conrad On 07/25/2014 11:04 AM, Conrad Hoffmann wrote: > Hey, > > On 07/25/2014 08:31 AM, Willy Tarreau wrote: >>

Re: [PATCH] Improve and simplify systemd-wrapper.

2014-07-25 Thread Conrad Hoffmann
Hey, On 07/25/2014 08:31 AM, Willy Tarreau wrote: >> There was only one small bug really, but once I got going I thought i >> might as well simplify it a litle. I pulled everything out of the signal >> handlers, switched from signal() to sigaction(), got rid of global state >> and got rid of the w

Re: [PATCH] Improve and simplify systemd-wrapper.

2014-07-24 Thread Willy Tarreau
Hi Conrad, On Fri, Jul 25, 2014 at 03:34:39AM +0200, Conrad Hoffmann wrote: > Hey Willy, > > I know you're not that much into the systemd stuff, but although we > don't use systemd we actually us the wrapper a lot, and I thought it > could use a little make-over. OK. > There was only one small

[PATCH] Improve and simplify systemd-wrapper.

2014-07-24 Thread Conrad Hoffmann
offmann Date: Fri, 25 Jul 2014 02:58:51 +0200 Subject: [PATCH] Improve and simplify systemd-wrapper. The signal handling did too much work in the context of the signal handler, which didn't yet cause problems (for me) but is to be avoided. While at it I switched from the deprecated signal()