Re: [PATCH] MEDIUM: Support TCP keepalive parameters customization

2020-07-08 Thread Willy Tarreau
On Thu, Jul 09, 2020 at 04:25:17AM +, mizuta.take...@fujitsu.com wrote: > Hi, Willy, > > Thank you for your support. > Sorry for not considering other platforms. No worries, that's exactly part of the reasons I preferred to merge this after the 2.2 release :-) Willy

RE: [PATCH] MEDIUM: Support TCP keepalive parameters customization

2020-07-08 Thread mizuta.take...@fujitsu.com
Re: [PATCH] MEDIUM: Support TCP keepalive parameters > customization > > On Thu, Jul 09, 2020 at 04:42:29AM +0200, Willy Tarreau wrote: > > On Thu, Jul 09, 2020 at 02:21:32AM +, mizuta.take...@fujitsu.com > wrote: > > > I have attached a patch with dual-sided tcpka-* remov

Re: [PATCH] MEDIUM: Support TCP keepalive parameters customization

2020-07-08 Thread Willy Tarreau
On Thu, Jul 09, 2020 at 04:42:29AM +0200, Willy Tarreau wrote: > On Thu, Jul 09, 2020 at 02:21:32AM +, mizuta.take...@fujitsu.com wrote: > > I have attached a patch with dual-sided tcpka-* removed. > > OK thank you, that's perfect, I'm taking it now! Bah, we obviously broke non-linux builds,

Re: [PATCH] MEDIUM: Support TCP keepalive parameters customization

2020-07-08 Thread Willy Tarreau
On Thu, Jul 09, 2020 at 02:21:32AM +, mizuta.take...@fujitsu.com wrote: > Hi, Willy, > > > Given that even in the doc you strongly suggested to use only clika-* and > > srvka-*, I'd rather kill the dual-sided tcpka-* before they start to be > > used. > > Thank you for your suggestion! > >

RE: [PATCH] MEDIUM: Support TCP keepalive parameters customization

2020-07-08 Thread mizuta.take...@fujitsu.com
akeshi/水田 健司 > Cc: 'haproxy@formilux.org' > Subject: Re: [PATCH] MEDIUM: Support TCP keepalive parameters > customization > > Hi, > > On Mon, Jul 06, 2020 at 03:01:26AM +, mizuta.take...@fujitsu.com > wrote: > > Hi, Willy, > > > > Thank you for your

Re: [PATCH] MEDIUM: Support TCP keepalive parameters customization

2020-07-08 Thread Willy Tarreau
Hi, On Mon, Jul 06, 2020 at 03:01:26AM +, mizuta.take...@fujitsu.com wrote: > Hi, Willy, > > Thank you for your quick reply! > > > But I mean, that's probably OK and I won't argue on this. I'd be > > interested in others' opinions and/or suggestions on this, but > > it's not critical. > >

RE: [PATCH] MEDIUM: Support TCP keepalive parameters customization

2020-07-05 Thread mizuta.take...@fujitsu.com
MIZUTA Takeshi > -Original Message- > From: Willy Tarreau > Sent: Saturday, July 4, 2020 3:08 AM > To: Mizuta, Takeshi/水田 健司 > Cc: 'haproxy@formilux.org' > Subject: Re: [PATCH] MEDIUM: Support TCP keepalive parameters > customization > > Hi Takeshi, > > On F

Re: [PATCH] MEDIUM: Support TCP keepalive parameters customization

2020-07-03 Thread Willy Tarreau
Hi Takeshi, On Fri, Jul 03, 2020 at 11:21:59AM +, mizuta.take...@fujitsu.com wrote: > Dear maintainers, > > Thank you for discussing issue#670 on github. > https://github.com/haproxy/haproxy/issues/670 > > I have attached a patch that resolves the issue. > (I have changed the config keyword

[PATCH] MEDIUM: Support TCP keepalive parameters customization

2020-07-03 Thread mizuta.take...@fujitsu.com
Dear maintainers, Thank you for discussing issue#670 on github. https://github.com/haproxy/haproxy/issues/670 I have attached a patch that resolves the issue. (I have changed the config keyword from the commit on github.) Would you please comment on the patch? Documentation and test code will