Re: [PATCH] MINOR: support for http-request set-timeout client

2023-09-28 Thread Christopher Faulet
Le 27/09/2023 à 16:43, Vladimir Vdovin a écrit : Added set-timeout for frontend side of session, so it can be used to set custom per-client timeouts if needed. Added cur_client_timeout to fetch client timeout samples. Thanks Vladimir! The patch is merged now. -- Christopher Faulet

[PATCH] MINOR: support for http-request set-timeout client

2023-09-27 Thread Vladimir Vdovin
Added set-timeout for frontend side of session, so it can be used to set custom per-client timeouts if needed. Added cur_client_timeout to fetch client timeout samples. --- doc/configuration.txt | 17 +--- include/haproxy/action-t.h | 1 +

Re: [PATCH] MINOR: support for http-request set-timeout client

2023-09-26 Thread Vladimir
Sure it is too high, thought about this, but wanted to make less changes as possible) I will rework patch tomorrow. -- Vladimir > 26 сент. 2023 г., в 18:56, Christopher Faulet > написал(а): > > Le 25/09/2023 à 23:46, Vladimir Vdovin a écrit : >> Added set-timeout for frontend side of

Re: [PATCH] MINOR: support for http-request set-timeout client

2023-09-26 Thread Christopher Faulet
Le 25/09/2023 à 23:46, Vladimir Vdovin a écrit : Added set-timeout for frontend side of session, so it can be used to set custom per-client timeouts if needed. Added cur_client_timeout to fetch client timeout samples. Thanks, it looks good. Number of arguments for cfg_parse_rule_set_timeout()

[PATCH] MINOR: support for http-request set-timeout client

2023-09-25 Thread Vladimir Vdovin
Added set-timeout for frontend side of session, so it can be used to set custom per-client timeouts if needed. Added cur_client_timeout to fetch client timeout samples. --- doc/configuration.txt | 17 +--- include/haproxy/action-t.h | 1 +

Re: [PATCH] MINOR: support for http-request set-timeout client

2023-09-25 Thread Vladimir
Thanks for your comments and help! Everything seems to be clear for me, so sending you fresh changes as one rebased/squashed commit. -- Vladimir Vdovin > 25 сент. 2023 г., в 11:20, Christopher Faulet > написал(а): > > Le 16/09/2023 à 06:19, Vladimir Vdovin a écrit : >> Added set-timeout for

Re: [PATCH] MINOR: support for http-request set-timeout client

2023-09-25 Thread Christopher Faulet
Le 16/09/2023 à 06:19, Vladimir Vdovin a écrit : Added set-timeout for frontend side of session, so it can be used to set dynamically per-client timeouts if needed. Thanks ! It looks good. However I have few comments. First it could be good to add a sample fetch to retrieve the current

Re: [PATCH] MINOR: support for http-request set-timeout client

2023-09-25 Thread Christopher Faulet
Le 23/09/2023 à 13:07, Willy Tarreau a écrit : On Sat, Sep 16, 2023 at 07:19:46AM +0300, Vladimir Vdovin wrote: Added set-timeout for frontend side of session, so it can be used to set dynamically per-client timeouts if needed. I'm figuring we didn't respond to this one. Christopher, could

Re: [PATCH] MINOR: support for http-request set-timeout client

2023-09-23 Thread Willy Tarreau
On Sat, Sep 16, 2023 at 07:19:46AM +0300, Vladimir Vdovin wrote: > Added set-timeout for frontend side of session, so it can be used to set > dynamically per-client timeouts if needed. I'm figuring we didn't respond to this one. Christopher, could you please review it next week so that we don't

[PATCH] MINOR: support for http-request set-timeout client

2023-09-15 Thread Vladimir Vdovin
Added set-timeout for frontend side of session, so it can be used to set dynamically per-client timeouts if needed. --- doc/configuration.txt | 12 ++-- include/haproxy/action-t.h | 1 + src/action.c | 5 - src/http_act.c | 5 + src/stream.c