Re: [PATCH] Prometheus: Simplify metrics matrices definition

2021-01-21 Thread Christopher Faulet
Le 21/01/2021 à 18:54, Christopher Faulet a écrit : Le 21/01/2021 à 18:10, William Dauchy a écrit : Hey Christopher, On Wed, Jan 20, 2021 at 7:45 PM Willy Tarreau wrote: I will continue my work once you have merged this series. Great, I'll let you guys deal with this together :-) sorry to

Re: [PATCH] Prometheus: Simplify metrics matrices definition

2021-01-21 Thread Christopher Faulet
Le 21/01/2021 à 18:10, William Dauchy a écrit : Hey Christopher, On Wed, Jan 20, 2021 at 7:45 PM Willy Tarreau wrote: I will continue my work once you have merged this series. Great, I'll let you guys deal with this together :-) sorry to be a bit impatient but is it possible to push those t

Re: [PATCH] Prometheus: Simplify metrics matrices definition

2021-01-21 Thread William Dauchy
Hey Christopher, On Wed, Jan 20, 2021 at 7:45 PM Willy Tarreau wrote: > > I will continue my work once you have merged this series. > Great, I'll let you guys deal with this together :-) sorry to be a bit impatient but is it possible to push those things so I can continue? :-) Best, -- William

Re: [PATCH] Prometheus: Simplify metrics matrices definition

2021-01-20 Thread Willy Tarreau
On Wed, Jan 20, 2021 at 07:35:11PM +0100, William Dauchy wrote: > I have not tested them but from what I see it should really much change > the current output, even the order. That being said, it looks definitely > simpler to me. Same here, I'm glad not to see this transition array anymore. Regard

Re: [PATCH] Prometheus: Simplify metrics matrices definition

2021-01-20 Thread William Dauchy
On Wed, Jan 20, 2021 at 07:35:11PM +0100, William Dauchy wrote: > I have not tested them but from what I see it should really much change I meant "it should not" ;) > the current output, even the order. That being said, it looks definitely > simpler to me. > I will continue my work once you have

Re: [PATCH] Prometheus: Simplify metrics matrices definition

2021-01-20 Thread William Dauchy
Hi Christopher, On Wed, Jan 20, 2021 at 04:55:59PM +0100, Christopher Faulet wrote: > Here is an attempt to simplify the metrics matrices definition. Instead of > having multiple arrays to define the metrics names and type, there is now > only 2 arrays. One for the global metrics and another one f

[PATCH] Prometheus: Simplify metrics matrices definition

2021-01-20 Thread Christopher Faulet
William, My turn now :) Here is an attempt to simplify the metrics matrices definition. Instead of having multiple arrays to define the metrics names and type, there is now only 2 arrays. One for the global metrics and another one for the frontend/backend/server metrics. And there is no longe