Re: [PATCH 0/3] Add a `strip-dot` normalizer

2021-04-21 Thread Tim Düsterhus
Willy, On 4/21/21 7:03 PM, Willy Tarreau wrote: $ curl -v https://example.com/foo///bar 2>&1 |grep GET GET /foo///bar HTTP/2 $ curl -v https://example.com/foo/../bar 2>&1 |grep GET GET /bar HTTP/2 $ curl -v https://example.com/foo//../bar 2>&1 |grep GET GET /foo/bar HTTP/2 I'm fine with p

Re: [PATCH 0/3] Add a `strip-dot` normalizer

2021-04-21 Thread Willy Tarreau
On Wed, Apr 21, 2021 at 06:48:20PM +0200, Tim Düsterhus wrote: > Willy, > > On 4/21/21 12:11 PM, Willy Tarreau wrote: > > > For the existing path ones I'd suggest: > > > > > >http-request normalize-uri filesystem > > > > > > that combines path-strip-dot, path-strip-dotdot, path-merge-slashes

Re: [PATCH 0/3] Add a `strip-dot` normalizer

2021-04-21 Thread Tim Düsterhus
Willy, On 4/21/21 12:11 PM, Willy Tarreau wrote: For the existing path ones I'd suggest: http-request normalize-uri filesystem that combines path-strip-dot, path-strip-dotdot, path-merge-slashes in an useful order. The only thing is that "filesystem" doesn't imply at all that it applies t

Re: [PATCH 0/3] Add a `strip-dot` normalizer

2021-04-21 Thread Christopher Faulet
Le 21/04/2021 à 00:22, Maximilian Mader a écrit : Hi Christopher, Tim and I were talking while he was working on the URI normalizers and as a fun evening exercise I decided to write a simple normalizer to remove single dots from the path component. While looking over his code to get an understan

Re: [PATCH 0/3] Add a `strip-dot` normalizer

2021-04-21 Thread Willy Tarreau
Hi Tim, On Wed, Apr 21, 2021 at 12:02:58PM +0200, Tim Düsterhus wrote: > Yes, I already replied to Christopher during the initial review that > providing combined normalizers definitely makes sense. Ah OK I didn't understand that it was what you meant. > For the existing path ones I'd suggest: >

Re: [PATCH 0/3] Add a `strip-dot` normalizer

2021-04-21 Thread Tim Düsterhus
Willy, On 4/21/21 6:57 AM, Willy Tarreau wrote: This whole series looks good to me (of course) :-) I'm fine with this one at first glance, but I *really* think that we need to seriously think about merging all the path* normalizers into a single "path". There is no reason for having users ite

Re: [PATCH 0/3] Add a `strip-dot` normalizer

2021-04-20 Thread Willy Tarreau
On Wed, Apr 21, 2021 at 12:37:51AM +0200, Tim Düsterhus wrote: > Hi > > On 4/21/21 12:22 AM, Maximilian Mader wrote: > > Tim and I were talking while he was working on the URI normalizers > > and as a fun evening exercise I decided to write a simple normalizer > > to remove single dots from the pa

Re: [PATCH 0/3] Add a `strip-dot` normalizer

2021-04-20 Thread Tim Düsterhus
Hi On 4/21/21 12:22 AM, Maximilian Mader wrote: Tim and I were talking while he was working on the URI normalizers and as a fun evening exercise I decided to write a simple normalizer to remove single dots from the path component. This whole series looks good to me (of course) :-) While look

[PATCH 0/3] Add a `strip-dot` normalizer

2021-04-20 Thread Maximilian Mader
Hi Christopher, Tim and I were talking while he was working on the URI normalizers and as a fun evening exercise I decided to write a simple normalizer to remove single dots from the path component. While looking over his code to get an understanding of how things work I found a minor bug in his i