Re: [PATCH 1/2] BUG/MINOR: cli: fix set server addr/port coherency with health checks

2021-02-02 Thread William Dauchy
Hi Christopher, Thanks for the review. On Tue, Feb 2, 2021 at 10:21 AM Christopher Faulet wrote: > So, it may be good to take a global look at this stuff. I may missed > something. > And be carefull for the backports because the health-checks were refactored in > the 2.2. ok I will come back w

Re: [PATCH 1/2] BUG/MINOR: cli: fix set server addr/port coherency with health checks

2021-02-02 Thread Christopher Faulet
Le 31/01/2021 à 11:11, William Dauchy a écrit : while reading `update_server_addr_port` I found out some things which can be seen as incoherency. I hope I did not overlooked anything: - one comment is stating check's address should be updated if it uses the server one; however the condition c

[PATCH 1/2] BUG/MINOR: cli: fix set server addr/port coherency with health checks

2021-02-01 Thread William Dauchy
while reading `update_server_addr_port` I found out some things which can be seen as incoherency. I hope I did not overlooked anything: - one comment is stating check's address should be updated if it uses the server one; however the condition checks if `SRV_F_CHECKADDR` is set; this flag is s