Re: [PATCH 1/3] BUG/MINOR: pollers: remove uneeded free in global init

2020-05-13 Thread Willy Tarreau
On Wed, May 13, 2020 at 04:01:02PM +0200, William Dauchy wrote: > On Wed, May 13, 2020 at 03:52:54PM +0200, Willy Tarreau wrote: > > > This one breaks clang builds because it removes the fail_revt label but > > > it is > > > still declared as a local label, and clang errors on it. > > > > Ah

Re: [PATCH 1/3] BUG/MINOR: pollers: remove uneeded free in global init

2020-05-13 Thread William Dauchy
On Wed, May 13, 2020 at 03:52:54PM +0200, Willy Tarreau wrote: > > This one breaks clang builds because it removes the fail_revt label but it > > is > > still declared as a local label, and clang errors on it. > > Ah crap! I didn't notice this part which didn't appear in the context > of the

Re: [PATCH 1/3] BUG/MINOR: pollers: remove uneeded free in global init

2020-05-13 Thread Jerome Magnin
Hi Willy, On Wed, May 13, 2020 at 03:52:54PM +0200, Willy Tarreau wrote: > Hi Jérôme, > [...] > Ah crap! I didn't notice this part which didn't appear in the context > of the patch. I didn't notice we still had a few such labels in very > old files. Do you mind if instead I edit your patch to

Re: [PATCH 1/3] BUG/MINOR: pollers: remove uneeded free in global init

2020-05-13 Thread Willy Tarreau
Hi Jérôme, On Wed, May 13, 2020 at 03:30:53PM +0200, Jerome Magnin wrote: > On Wed, May 13, 2020 at 11:46:50AM +0200, Willy Tarreau wrote: > > On Mon, May 11, 2020 at 03:20:03PM +0200, William Dauchy wrote: > > > Since commit d4604adeaa8c ("MAJOR: threads/fd: Make fd stuffs > > > thread-safe"),

Re: [PATCH 1/3] BUG/MINOR: pollers: remove uneeded free in global init

2020-05-13 Thread Jerome Magnin
Hi, On Wed, May 13, 2020 at 11:46:50AM +0200, Willy Tarreau wrote: > On Mon, May 11, 2020 at 03:20:03PM +0200, William Dauchy wrote: > > Since commit d4604adeaa8c ("MAJOR: threads/fd: Make fd stuffs > > thread-safe"), we init pollers per thread using a helper. It was still > > correct for

Re: [PATCH 1/3] BUG/MINOR: pollers: remove uneeded free in global init

2020-05-13 Thread Willy Tarreau
On Mon, May 11, 2020 at 03:20:03PM +0200, William Dauchy wrote: > Since commit d4604adeaa8c ("MAJOR: threads/fd: Make fd stuffs > thread-safe"), we init pollers per thread using a helper. It was still > correct for mono-thread mode until commit cd7879adc2c4 ("BUG/MEDIUM: > threads: Run the poll

[PATCH 1/3] BUG/MINOR: pollers: remove uneeded free in global init

2020-05-11 Thread William Dauchy
Since commit d4604adeaa8c ("MAJOR: threads/fd: Make fd stuffs thread-safe"), we init pollers per thread using a helper. It was still correct for mono-thread mode until commit cd7879adc2c4 ("BUG/MEDIUM: threads: Run the poll loop on the main thread too"). We now use a deinit helper for all threads,