Hi Jérôme, On Wed, May 13, 2020 at 03:30:53PM +0200, Jerome Magnin wrote: > On Wed, May 13, 2020 at 11:46:50AM +0200, Willy Tarreau wrote: > > On Mon, May 11, 2020 at 03:20:03PM +0200, William Dauchy wrote: > > > Since commit d4604adeaa8c ("MAJOR: threads/fd: Make fd stuffs > > > thread-safe"), we init pollers per thread using a helper. It was still > > > correct for mono-thread mode until commit cd7879adc2c4 ("BUG/MEDIUM: > > > threads: Run the poll loop on the main thread too"). We now use a deinit > > > helper for all threads, making those free uneeded. > > > > > > Only poll and select are affected by this very minor issue. > > > > > > it could be backported from v1.8 to v2.1. > > > > > > Fixes: cd7879adc2c4 ("BUG/MEDIUM: threads: Run the poll loop on the main > > > thread too") > > > Signed-off-by: William Dauchy <w.dau...@criteo.com> > > > > Applied, thank you William. > > > > This one breaks clang builds because it removes the fail_revt label but it is > still declared as a local label, and clang errors on it.
Ah crap! I didn't notice this part which didn't appear in the context of the patch. I didn't notice we still had a few such labels in very old files. Do you mind if instead I edit your patch to completely remove the line ? Thanks, Willy