Re: [PATCH 1/5] CLEANUP: connection: Use `VAR_ARRAY` in `struct tlv` definition

Willy, Am 09.03.21 um 09:36 schrieb Willy Tarreau: > If you're interested in such "ist" conversions Not really interested in changing any more location at the moment. It's just that I'm very much interested in the PROXY protocol support and this inconsistency between the authority and unique ID

Re: [PATCH 1/5] CLEANUP: connection: Use `VAR_ARRAY` in `struct tlv` definition

All the series now applied after reviewing, thanks for doing this, Tim! If you're interested in such "ist" conversions, there are plenty of header names, cookie names, cookie values and so on that are always used as pairs of ptr+len in struct proxy and struct server. For example, I do have some

[PATCH 1/5] CLEANUP: connection: Use `VAR_ARRAY` in `struct tlv` definition

This is for consistency with `struct tlv_ssl`. --- include/haproxy/connection-t.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/haproxy/connection-t.h b/include/haproxy/connection-t.h index 9c2af7b8f..0bcceacff 100644 --- a/include/haproxy/connection-t.h +++

Re: [PATCH 1/5]: CLEANUP

On Tue, Feb 16, 2016 at 07:04:00PM +, David CARLIER wrote: > Hi and thanks for the feedback, indeed the performance will be affected > (greatly) as you demonstrate that s for sure. I completely forgot the > context of my tests those days and regarding your following questions about > compilers

Re: [PATCH 1/5]: CLEANUP

Hi and thanks for the feedback, indeed the performance will be affected (greatly) as you demonstrate that s for sure. I completely forgot the context of my tests those days and regarding your following questions about compilers ; I might just have CFLAGS environment variable override whereas I did

Re: [PATCH 1/5]: CLEANUP

Hi again David, On Wed, Jan 06, 2016 at 01:23:52PM +, David CARLIER wrote: > Sure, it is mainly gcc 5.2/5.3, sometimes clang 3.6 depending the > machine I was working on. So I just rechecked on https://gcc.godbolt.org/ with the following versions : - gcc 4.9 - gcc 5.1.0 - gcc 5.2.0 -

Re: [PATCH 1/5]: CLEANUP

Hi David, On Wed, Jan 06, 2016 at 01:23:52PM +, David CARLIER wrote: > Sure, it is mainly gcc 5.2/5.3, sometimes clang 3.6 depending the > machine I was working on. I'm back (late) on this patch series. So at this point I'm seeing that the memmem() and ebmb_lookup() functions are

Re: [PATCH 1/5]: CLEANUP

On Wed, Jan 06, 2016 at 01:11:46PM +, David CARLIER wrote: > About ebtree, it is partly the compiler, partly not ... the > container_of macro came from warnings whereas ebtree functions was a > bit my own ... my_memmem function is also my own ... all the rest is > compiler warnings. OK thank

Re: [PATCH 1/5]: CLEANUP

Sure, it is mainly gcc 5.2/5.3, sometimes clang 3.6 depending the machine I was working on. On 6 January 2016 at 13:15, Willy TARREAU wrote: > On Wed, Jan 06, 2016 at 01:11:46PM +, David CARLIER wrote: >> About ebtree, it is partly the compiler, partly not ... the >>

Re: [PATCH 1/5]: CLEANUP

About ebtree, it is partly the compiler, partly not ... the container_of macro came from warnings whereas ebtree functions was a bit my own ... my_memmem function is also my own ... all the rest is compiler warnings. Cheers. On 6 January 2016 at 12:54, Willy TARREAU wrote:

Re: [PATCH 1/5]: CLEANUP

Hi David, On Tue, Dec 29, 2015 at 01:28:13PM +, David CARLIER wrote: > Hi all, > > these are a set of independent patches which basically remove some > void pointers arithmetics operations in various places. At least they > can be applied individually or not ... > > That should be my last

[PATCH 1/5]: CLEANUP

Hi all, these are a set of independent patches which basically remove some void pointers arithmetics operations in various places. At least they can be applied individually or not ... That should be my last submission for this year :-) Kind regards.

[PATCH 1/5] [CLEANUP] peers.h: fix declarations

* The declaration of peer_session_create() does not match its definition. As it is only used inside of peers.c make it static. * Make the declaration of peers_register_table() match its definition. * Also, make all functions in peers.c that are not also in peers.h static ---