Re: [RFC PATCH v2 0/4] Add support for if-none-match for cache responses

2020-09-01 Thread Christopher Faulet
Le 31/08/2020 à 17:40, Tim Düsterhus a écrit : Christopher, Am 31.08.20 um 10:36 schrieb Christopher Faulet: There is no applet for uncached requests. So there is no reason to call the release callback function. Looking at your 4th patch, you should manually release 'if_none_match' variable for

Re: [RFC PATCH v2 0/4] Add support for if-none-match for cache responses

2020-08-31 Thread Tim Düsterhus
Christopher, Am 31.08.20 um 10:36 schrieb Christopher Faulet: > There is no applet for uncached requests. So there is no reason to call > the release callback function. Looking at your 4th patch, you should > manually release 'if_none_match' variable for uncached requests in the > http_action_req_

Re: [RFC PATCH v2 0/4] Add support for if-none-match for cache responses

2020-08-31 Thread Christopher Faulet
Le 28/08/2020 à 20:40, Tim Duesterhus a écrit : William, Am 28.08.20 um 13:57 schrieb William Lallemand: So basically I would need to simply store the 'if-none-match' of the request within the `appctx`, yes? That's right, once the object is found in the cache, you can check the etag from the

[RFC PATCH v2 0/4] Add support for if-none-match for cache responses

2020-08-28 Thread Tim Duesterhus
William, Am 28.08.20 um 13:57 schrieb William Lallemand: >> So basically I would need to simply store the 'if-none-match' of the >> request within the `appctx`, yes? > > That's right, once the object is found in the cache, you can check the > etag from the request action and set a flag in the app