Re: [PATCH v3 0/2] Certificate Generation Enhancements

2020-08-28 Thread William Lallemand
On Fri, Aug 28, 2020 at 11:53:47AM +0300, Gersner wrote: > Thanks William! > > I will commit some time to add those reg-tests. > > Shimi. Thanks a lot, that's greatly appreciated! -- William Lallemand

Re: [PATCH v3 0/2] Certificate Generation Enhancements

2020-08-28 Thread Gersner
t; comments from previous patch. > > As suggested, this is now the default behaviour. > > > > PR Reference > https://github.com/Azure/haproxy/tree/wip/sgersner/ca-features > > > > Thanks, > > Shimi. > > > > Shimi Gersner (2): > > MEDIUM: ssl: Sup

Re: [PATCH v3 0/2] Certificate Generation Enhancements

2020-08-25 Thread William Lallemand
t; > PR Reference https://github.com/Azure/haproxy/tree/wip/sgersner/ca-features > > Thanks, > Shimi. > > Shimi Gersner (2): > MEDIUM: ssl: Support certificate chaining for certificate generation > MINOR: ssl: Support SAN extension for certificate generation > > i

[PATCH v3 0/2] Certificate Generation Enhancements

2020-08-23 Thread gersner
): MEDIUM: ssl: Support certificate chaining for certificate generation MINOR: ssl: Support SAN extension for certificate generation include/haproxy/listener-t.h | 3 +- src/ssl_sock.c | 147 +-- 2 files changed, 105 insertions(+), 45 deletions

[PATCH v3 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-08-23 Thread gersner
&& !defined SSL_NO_GENERATE_CERTIFICATES) if (global_ssl.ctx_cache) { @@ -5051,52 +5066,56 @@ ssl_sock_load_ca(struct bind_conf *bind_conf) ha_alert("Proxy '%s': cannot enable certificate generation, " &quo

[PATCH v3 2/2] MINOR: ssl: Support SAN extension for certificate generation

2020-08-23 Thread gersner
From: Shimi Gersner The use of Common Name is fading out in favor of the RFC recommended way of using SAN extensions. For example, Chrome from version 58 will only match server name against SAN. The following patch adds SAN extension by default to all generated certificates. The SAN extension wi

Re: [PATCH 2/2] SMALL: ssl: Support SAN extension for certificate generation

2020-07-11 Thread Gersner
On Fri, Jul 10, 2020 at 4:15 PM William Lallemand wrote: > Hello, > > On Sun, Jul 05, 2020 at 09:43:23AM +0300, gers...@gmail.com wrote: > > > > Subject: Re: [PATCH 2/2] SMALL: ssl: Support SAN extension for > certificate generation > > We commonly use the '

Re: [PATCH 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-11 Thread Gersner
On Fri, Jul 10, 2020 at 3:51 PM William Lallemand wrote: > Hello, > > > On Sun, Jul 05, 2020 at 09:43:22AM +0300, gers...@gmail.com wrote: > > From: Shimi Gersner > > > > haproxy supports generating SSL certificates based on SNI using a > provided > > CA signing certificate. Because CA certifica

Re: [PATCH v2 0/2] Certificate Generation Enhancements

2020-07-11 Thread Gersner
Oh, yes, missed the mail from William. Will go over the comments shortly. Thanks On Sat, Jul 11, 2020 at 1:54 PM Tim Düsterhus wrote: > Shimi, > > Am 11.07.20 um 09:28 schrieb Gersner: > > Gentle ping on this. Can I assist with providing more information? > > William responded on the v1 of your

Re: [PATCH v2 0/2] Certificate Generation Enhancements

2020-07-11 Thread Tim Düsterhus
Shimi, Am 11.07.20 um 09:28 schrieb Gersner: > Gentle ping on this. Can I assist with providing more information? William responded on the v1 of your patch. I assume he didn't see that there was a v2, because it's a separate email thread. I put him in Cc. https://www.mail-archive.com/haproxy@for

Re: [PATCH v2 0/2] Certificate Generation Enhancements

2020-07-11 Thread Gersner
>>> Additionally I have re-ran travis/cirrus >>> - https://travis-ci.com/github/gersner/haproxy/builds/174353855 >>> - https://cirrus-ci.com/build/5482853758664704 >>> >>> >>> PR Reference >>> https://github.com/Azure/haproxy/tre

Re: [PATCH 2/2] SMALL: ssl: Support SAN extension for certificate generation

2020-07-10 Thread William Lallemand
Hello, On Sun, Jul 05, 2020 at 09:43:23AM +0300, gers...@gmail.com wrote: > > Subject: Re: [PATCH 2/2] SMALL: ssl: Support SAN extension for certificate > generation We commonly use the 'MINOR' tag instead of 'SMALL' here. > The use of Common Name is fading out

Re: [PATCH 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-10 Thread William Lallemand
Hello, On Sun, Jul 05, 2020 at 09:43:22AM +0300, gers...@gmail.com wrote: > From: Shimi Gersner > > haproxy supports generating SSL certificates based on SNI using a provided > CA signing certificate. Because CA certificates may be signed by multiple > CAs, in some scenarios, it is neccesary fo

Re: [PATCH 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-06 Thread Gersner
On Mon, Jul 6, 2020 at 4:37 PM Aleksandar Lazic wrote: > Should a blank be after '%s'? > > + memprintf(err, "%sthis version of openssl cannot attach > certificate chain for SSL certificate generation.\n", > + err && *err ? *err :

Re: [PATCH 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-06 Thread Aleksandar Lazic
Should a blank be after '%s'? + memprintf(err, "%sthis version of openssl cannot attach certificate chain for SSL certificate generation.\n", + err && *err ? *err : ""); On 05.07.20 14:09, Gersner wrote: That's my fault. I was

Re: [PATCH v2 0/2] Certificate Generation Enhancements

2020-07-06 Thread Gersner
;> https://github.com/Azure/haproxy/tree/wip/sgersner/ca-sign-extra >> >> Thanks, >> Shimi. >> >> >> Shimi Gersner (2): >> MEDIUM: ssl: Support certificate chaining for certificate generation >> SMALL: ssl: Support SAN extension for certificate

Re: [PATCH v2 0/2] Certificate Generation Enhancements

2020-07-06 Thread Илья Шипицин
Reference > https://github.com/Azure/haproxy/tree/wip/sgersner/ca-sign-extra > > Thanks, > Shimi. > > > Shimi Gersner (2): > MEDIUM: ssl: Support certificate chaining for certificate generation > SMALL: ssl: Support SAN extension for certificate generation > >

[PATCH v2 0/2] Certificate Generation Enhancements

2020-07-05 Thread gersner
/builds/174353855 - https://cirrus-ci.com/build/5482853758664704 PR Reference https://github.com/Azure/haproxy/tree/wip/sgersner/ca-sign-extra Thanks, Shimi. Shimi Gersner (2): MEDIUM: ssl: Support certificate chaining for certificate generation SMALL: ssl: Support SAN extension for

[PATCH v2 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-05 Thread gersner
defined(SSL_CTX_add1_chain_cert)) + conf->ca_sign_use_chain = 1; + return 0; +#else + memprintf(err, "%sthis version of openssl cannot attach certificate chain for SSL certificate generation.\n", + err && *err ? *err : ""); +

[PATCH v2 2/2] SMALL: ssl: Support SAN extension for certificate generation

2020-07-05 Thread gersner
From: Shimi Gersner The use of Common Name is fading out in favor of the RFC recommended way of using SAN extensions. For example, Chrome from version 58 will only match server name against SAN. The following patch adds an optional flag to attach SAN extension of type DNS to the generated certif

Re: [PATCH 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-05 Thread Gersner
uration.txt >>>>>>>>>>> @@ -12158,6 +12158,14 @@ ca-sign-pass >>>>>>>>>>>the dynamic generation of certificates is enabled. See >>>>>>>>>>>'generate-certificates' for de

Re: [PATCH 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-05 Thread Илья Шипицин
vailable when support for OpenSSL was >>>>>>>>>> built in. It is >>>>>>>>>> + the CA private key passphrase. This setting is optional and >>>>>>>>>> used only when >>>>>>>>&

Re: [PATCH 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-05 Thread Gersner
t;>>>>> + the dynamic generation of certificates is enabled. See >>>>>>>>> + 'generate-certificates' for details. >>>>>>>>> + Enabling this flag will attach all public certificates encoded >>>>>>

Re: [PATCH 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-05 Thread Илья Шипицин
the served certificate to the client, enabling trust. >>>>>>>> + >>>>>>>> ca-verify-file >>>>>>>>This setting designates a PEM file from which to load CA >>>>>>>> certificates used to >>

Re: [PATCH 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-05 Thread Илья Шипицин
gt;>>>>>>> + >>>>>>>> ca-verify-file >>>>>>>>This setting designates a PEM file from which to load CA >>>>>>>> certificates used to >>>>>>>>verify client's certificate. It d

Re: [PATCH 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-05 Thread Gersner
e from which to load CA >>>>>>> certificates used to >>>>>>>verify client's certificate. It designates CA certificates which >>>>>>> must not be >>>>>>> diff --git a/include/haproxy/listener-t.h >>>&

Re: [PATCH 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-05 Thread Илья Шипицин
t;>>>>> index 224e32513..38ca2839f 100644 >>>>>> --- a/include/haproxy/listener-t.h >>>>>> +++ b/include/haproxy/listener-t.h >>>>>> @@ -163,8 +163,8 @@ struct bind_conf { >>>>>> char *ca_sign_file;

Re: [PATCH 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-05 Thread Илья Шипицин
;>>> char *ca_sign_pass;/* CAKey passphrase */ >>>>> >>>>> - X509 *ca_sign_cert;/* CA certificate referenced by >>>>> ca_file */ >>>>> - EVP_PKEY *ca_sign_pkey;/* CA privat

Re: [PATCH 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-05 Thread Gersner
ferenced by >>>> ca_key */ >>>> + int ca_sign_use_chain; /* Optionally attached the >>>> certificate chain to the served certificate */ >>>> + struct cert_key_and_chain * ca_sign_ckch; /* CA and >>>> possible certificate chain

Re: [PATCH 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-05 Thread Илья Шипицин
for ca generation */ >>> #endif >>> struct proxy *frontend;/* the frontend all these listeners >>> belong to, or NULL */ >>> const struct mux_proto_list *mux_proto; /* the mux to use for >>> all incoming connections (specified b

Re: [PATCH 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-05 Thread Gersner
> incoming connections (specified by the "proto" keyword) */ >> diff --git a/src/cfgparse-ssl.c b/src/cfgparse-ssl.c >> index 144cef882..270c857f9 100644 >> --- a/src/cfgparse-ssl.c >> +++ b/src/cfgparse-ssl.c >> @@ -538,6 +538,18 @@ static int bind_parse_c

Re: [PATCH 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-05 Thread Илья Шипицин
arse_ca_sign_use_chain(char **args, int cur_arg, struct > proxy *px, struct bind_conf *conf, char **err) > +{ > +#if (defined SSL_CTRL_SET_TLSEXT_HOSTNAME && !defined > SSL_NO_GENERATE_CERTIFICATES && defined SSL_CTX_set1_chain) > + conf->ca_sign_use_chain = 1; > +#else >

[PATCH 1/2] MEDIUM: ssl: Support certificate chaining for certificate generation

2020-07-04 Thread gersner
_use_chain = 1; +#else + memprintf(err, "%sthis version of openssl cannot attach certificate chain for SSL certificate generation.\n", + err && *err ? *err : ""); +#endif + return 0; +} + /* parse the "ca-sign-pass" bind keyword */

[PATCH 0/2] Certificate Generation Enhancements

2020-07-04 Thread gersner
From: Shimi Gersner Hi folks, The following patches add two enhancements to the certificate generation feature. - SAN extension on the generated certificate - Chaining the full trust of the original CA certificate While evaluating HAP for a new product we realized that these two features

[PATCH 2/2] SMALL: ssl: Support SAN extension for certificate generation

2020-07-04 Thread gersner
From: Shimi Gersner The use of Common Name is fading out in favor of the RFC recommended way of using SAN extensions. For example, Chrome from version 58 will only match server name against SAN. The following patch adds an optional flag to attach SAN extension of type DNS to the generated certif

Re: certificate generation

2015-09-07 Thread Michael Rennecke
SubCA and the certificate generation is cooler. We will use elliptic curves for the CA. All our clients can handle elliptic curves certificates. best, Michael On 05.09.2015 04:16, Jeff Palmer wrote: > Can you explain what the overall goal is? I suspect that even if > you could dynam

Re: certificate generation

2015-09-07 Thread Christopher Faulet
Le 04/09/2015 23:32, Michael Rennecke a écrit : -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hallo, is it possible with HAProxy to generate a certificate for each incoming hostname on the fly? I will use subca for HAProxy. I think to generate the certificates on the fly is cooler, then a certi

Re: certificate generation

2015-09-04 Thread Jeff Palmer
Can you explain what the overall goal is? I suspect that even if you could dynamically generate new certificates on the fly, the overhead to do so would be prohibitively expensive. If you are attempting to do this for security, it's probably worth pointing out that it is insanely easy to configur

certificate generation

2015-09-04 Thread Michael Rennecke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hallo, is it possible with HAProxy to generate a certificate for each incoming hostname on the fly? I will use subca for HAProxy. I think to generate the certificates on the fly is cooler, then a certificate for each hostname. I found possibilities t