Re: Dynamic Googlebot identification via lua?

2020-09-12 Thread Reinhard Vicinus
Tim, On 9/12/20 4:25 PM, Tim Düsterhus wrote: > Reinhard, > > Am 12.09.20 um 12:45 schrieb Reinhard Vicinus: >> thanks, for your reply and the information. Sorry for my late reply, but >> I had only today time to test. I did try to get the spoa server working >> on a ubuntu bionic (18.04.4) with

Re: Dynamic Googlebot identification via lua?

2020-09-12 Thread Reinhard Vicinus
Tim, Aleksandar, On 9/8/20 11:18 PM, Aleksandar Lazic wrote: > On 08.09.20 22:54, Tim Düsterhus wrote: >> Reinhard, >> Björn, >> >> Am 08.09.20 um 21:39 schrieb Björn Jacke: the only official supported way to identify a google bot is to run a reverse DNS lookup on the accessing IP

Re: [PATCH] ci: travis-ci: help coverity to recognize abort

2020-09-12 Thread Willy Tarreau
On Sat, Sep 12, 2020 at 11:31:29AM +0500, ??? wrote: > so, it is good time to adjust .gitignore :) > > I also added commit message with explanation. I'm ok if you modify it by > your will. That's perfect, all applied with no change now, thank you very much Ilya! Willy

Re: Dynamic Googlebot identification via lua?

2020-09-12 Thread Tim Düsterhus
Reinhard, Am 12.09.20 um 16:43 schrieb Reinhard Vicinus: >>> thanks, for your reply and the information. Sorry for my late reply, but >>> I had only today time to test. I did try to get the spoa server working >>> on a ubuntu bionic (18.04.4) with haproxy 2.2.3-2ppa1~bionic from the >>> vbernat

Re: Dynamic Googlebot identification via lua?

2020-09-12 Thread Tim Düsterhus
Reinhard, Am 12.09.20 um 12:45 schrieb Reinhard Vicinus: > thanks, for your reply and the information. Sorry for my late reply, but > I had only today time to test. I did try to get the spoa server working > on a ubuntu bionic (18.04.4) with haproxy 2.2.3-2ppa1~bionic from the > vbernat ppa. I

Re: [PATCH] ci: travis-ci: help coverity to recognize abort

2020-09-12 Thread Илья Шипицин
so, it is good time to adjust .gitignore :) I also added commit message with explanation. I'm ok if you modify it by your will. чт, 10 сент. 2020 г. в 22:34, Willy Tarreau : > Hi Ilya, > > On Thu, Sep 10, 2020 at 09:45:08PM +0500, ??? wrote: > > ping :) > > Ah sorry, thanks for the

Is adaptive circuit breaking in the roadmap for 2.3/2.4?

2020-09-12 Thread Pavlos Parissis
Hi old friends!, Is in the roadmap the addition of a circuit breaking which adapts its settings using real-time data? I believe we discussed this in the last HAProxyConf with a group of people, but I don't remember if there were , back then, concrete plans to work on it. I know that something

[PATCH] BUG/MINOR: Do not use a fixed type for 'sizeof' in 'calloc'

2020-09-12 Thread Tim Duesterhus
This fixes at least one instance where the wrong type was given to sizeof. clang-analyzer complained that in src/cfgparse.c line 3614 (newsrv->curr_idle_thr): > Result of 'calloc' is converted to a pointer of type 'unsigned int', which is > incompatible with sizeof operand type 'int' Changes

Re: [PATCH] BUG/MINOR: Do not use a fixed type for 'sizeof' in 'calloc'

2020-09-12 Thread Willy Tarreau
Hi Tim, On Sat, Sep 12, 2020 at 05:32:03PM +0200, Tim Duesterhus wrote: > This fixes at least one instance where the wrong type was given to sizeof. > clang-analyzer complained that in src/cfgparse.c line 3614 > (newsrv->curr_idle_thr): > > > Result of 'calloc' is converted to a pointer of type

[PATCH v2 2/2] CLEANUP: Do not use a fixed type for 'sizeof' in 'calloc'

2020-09-12 Thread Tim Duesterhus
Changes performed using the following coccinelle patch: @@ type T; expression E; expression t; @@ ( t = calloc(E, sizeof(*t)) | - t = calloc(E, sizeof(T)) + t = calloc(E, sizeof(*t)) ) Looking through the commit history, grepping for coccinelle

[PATCH v2 0/2] Fixed type in sizeof in calloc

2020-09-12 Thread Tim Duesterhus
Willy, Am 12.09.20 um 18:52 schrieb Willy Tarreau: > Thanks for doing this, I really appreciate it as I too hate having > a named type in calloc, as it doesn't survive code changes over time. > > I'd rather have one patch to fix the known bug and the rest as a > cleanup patch however, so that we

[PATCH v2 1/2] BUG/MINOR: Fix type passed of sizeof() for calloc()

2020-09-12 Thread Tim Duesterhus
newsrv->curr_idle_thr is of type `unsigned int`, not `int`. Fix this issue by simply passing the dereferenced pointer to sizeof, which is the preferred style anyway. This bug was introduced in commit dc2f2753e97ecfe94827de56ee9efd2cd6d39ad3. It first appeared in 2.2-dev5. The patch must be

Re: [PATCH v2 0/2] Fixed type in sizeof in calloc

2020-09-12 Thread Willy Tarreau
On Sat, Sep 12, 2020 at 08:26:41PM +0200, Tim Duesterhus wrote: > Willy, > > Am 12.09.20 um 18:52 schrieb Willy Tarreau: > > Thanks for doing this, I really appreciate it as I too hate having > > a named type in calloc, as it doesn't survive code changes over time. > > > > I'd rather have one