Re: [PATCH] another ssl fine guard (SSL_CTX_get0_privatekey)

2020-12-21 Thread Willy Tarreau
On Sat, Dec 19, 2020 at 03:15:27AM +0500, ??? wrote: > Hello, > > another fine guard. Look good, now applied, thank you Ilya! Willy

Re: [PATCH] speling fixes

2020-12-21 Thread Willy Tarreau
Hi Ilya, please could you provide a commit message for this one which is totally cryptic to me: > From c0811d0580d7ff5f5650e17afbc5ecf9d173f772 Mon Sep 17 00:00:00 2001 > From: Ilya Shipitsin > Date: Mon, 21 Dec 2020 01:03:12 +0500 > Subject: [PATCH 1/3] CI: codespell: whitelist "te" and "nd"

Re: [PATCH] speling fixes

2020-12-21 Thread Willy Tarreau
On Mon, Dec 21, 2020 at 03:49:08PM +0500, ??? wrote: > te is widely used abbrevation for "transfer encoding" > nd is variable name "name description" > > we need to teach codespell those are legitimate Perfect, makes sense, now applied. Thank you. Willy

[ANNOUNCE] haproxy-2.4-dev4

2020-12-21 Thread Willy Tarreau
Hi, HAProxy 2.4-dev4 was released on 2020/12/21. It added 33 new commits after version 2.4-dev3. In this traditionally calm period, there aren't that many changes, except a lot of bug fixes. Actually 3 bugs in dev3 managed to cause crashes on haproxy.org, this hadn't happened in a very long

Re: [PR] hpack-tbl-t.h uses VAR_ARRAY and requires compiler.h to be included

2020-12-21 Thread Willy Tarreau
On Mon, Dec 21, 2020 at 12:20:36PM +0100, Christian Ruppert wrote: > > 2) we include from this file so that it becomes > > consistent > > with everything else ; > > > > 3) we add the ifdef VAR_ARRAY directly into the file so that it > > continues > > not to depend on anything and

Re: Quick question on atomics on ARM

2020-12-21 Thread Willy Tarreau
Hi David, On Tue, Dec 15, 2020 at 03:54:34PM +, David CARLIER wrote: > Hi, > > I started to look at Haproxy on ARM and stumbled across the > implementation of cpu relax. While it is needed to have such > instruction, I am however wondering if the yield instruction is not > more appropriate

Re: [PR] smp_size and sample_size seems to be mixed in docu

2020-12-21 Thread Willy Tarreau
On Thu, Dec 17, 2020 at 11:23:02PM +0100, PR Bot wrote: > Dear list! > > Author: Jan Wagner > Number of patches: 1 > > This is an automated relay of the Github pull request: >smp_size and sample_size seems to be mixed in docu > > Patch title(s): >smp_size and sample_size seems to be

Re: [PATCH] BUG/MINOR: contrib/prometheus-exporter: consistent per-server metrics

2020-12-21 Thread William Dauchy
Hi Willy, Thank you for your answer. On Mon, Dec 21, 2020 at 11:08 AM Willy Tarreau wrote: > What impact do you think this renaming can have on stable versions ? > I suspect the reason it was not backported was to avoid breakage. But > actually maybe the difference between older and newer

Re: [PATCH] BUG/MINOR: contrib/prometheus-exporter: consistent per-server metrics

2020-12-21 Thread Willy Tarreau
Hi William, On Thu, Dec 17, 2020 at 11:55:18AM +0100, William Dauchy wrote: > commit c55a626217a7e676e1cc ("MINOR: contrib/prometheus-exporter: Add > missing global and per-server metrics") is renaming two metrics: > server_idle_connections_current > server_idle_connections_limit > > This

Re: [PR] hpack-tbl-t.h uses VAR_ARRAY and requires compiler.h to be included

2020-12-21 Thread Willy Tarreau
Hi, On Sun, Dec 20, 2020 at 12:58:52PM +0500, ??? wrote: > ping :) Oh I completely missed this one in the noise it seems! I'm sorry. > > Author: Christian Ruppert > > Number of patches: 1 > > > > This is an automated relay of the Github pull request: > >hpack-tbl-t.h uses

Re: [PATCH] BUG/MINOR: contrib/prometheus-exporter: consistent per-server metrics

2020-12-21 Thread Willy Tarreau
On Mon, Dec 21, 2020 at 01:05:50PM +0100, William Dauchy wrote: > > I'm not opposed at all to merging your patch, I'm just worried that > > some users will then report that these metrics are missing. Or should > > we duplicate them so that they appear with the two names in older > > versions maybe

Re: [PATCH] add 3 popular "contrib" tools to github actions builds

2020-12-21 Thread Tim Düsterhus
Ilya, Am 21.12.20 um 13:41 schrieb Илья Шипицин: > this will hopefully prevent regressions on halog. > I disagree with putting these into the VTest workflow. They do not depend on VTest and they do not depend on the build flags. Can you create a dedicated YML file for these, similar to the

Re: [ANNOUNCE] haproxy-2.4-dev4

2020-12-21 Thread Tim Düsterhus
Willy, Am 21.12.20 um 12:22 schrieb Willy Tarreau: > Just my two cents, I'm interested in anyone's opinion or suggestion here. Your proposal sounds good to me. Best regards Tim Düsterhus

HAProxy 1.6 (was: [ANNOUNCE] haproxy-2.4-dev4)

2020-12-21 Thread Tim Düsterhus
Willy, Am 21.12.20 um 12:22 schrieb Willy Tarreau: > HAProxy 2.4-dev4 was released on 2020/12/21. It added 33 new commits > after version 2.4-dev3. > > In this traditionally calm period, there aren't that many changes, except > a lot of bug fixes. Actually 3 bugs in dev3 managed to cause crashes

[PATCH] BUG/???: mux_h2: Add missing braces

2020-12-21 Thread Tim Duesterhus
Willy, please fill in the severity yourself, because I don't know what effects this bug causes. Check the issue for details: https://github.com/haproxy/haproxy/issues/1015 Best regards Tim Düsterhus Apply with `git am --scissors` to automatically cut the commit message. -- >8 -- This is a

Re: HAProxy 1.6 (was: [ANNOUNCE] haproxy-2.4-dev4)

2020-12-21 Thread Willy Tarreau
Hi Tim, On Mon, Dec 21, 2020 at 07:08:45PM +0100, Tim Düsterhus wrote: > Looking at haproxy.org I am seeing that the end of life for HAProxy 1.6 > is Q4-2020. Q4 is almost over. Is this on your radar? It probably makes > sense to: > > - do a final 1.6 release, and > - at the same time move 1.8

Re: [PATCH] add 3 popular "contrib" tools to github actions builds

2020-12-21 Thread Илья Шипицин
пн, 21 дек. 2020 г. в 22:59, Tim Düsterhus : > Ilya, > > Am 21.12.20 um 13:41 schrieb Илья Шипицин: > > this will hopefully prevent regressions on halog. > > > > I disagree with putting these into the VTest workflow. They do not > depend on VTest and they do not depend on the build flags. > > Can

Re: [PATCH] DNS: SRV resolution ignores duplicated AR records

2020-12-21 Thread Willy Tarreau
On Sat, Dec 19, 2020 at 09:53:38AM +0100, Baptiste wrote: > Hi, > > Since 2.2, HAProxy runtime resolver uses the Additional records of an SRV > response when available. That said, there was a small bug when multiple > records points to the same hostname and IP, then the subsequent ones may >

Re: [PATCH] speling fixes

2020-12-21 Thread Илья Шипицин
пн, 21 дек. 2020 г. в 15:27, Willy Tarreau : > Hi Ilya, > > please could you provide a commit message for this one which is totally > cryptic to me: > > > From c0811d0580d7ff5f5650e17afbc5ecf9d173f772 Mon Sep 17 00:00:00 2001 > > From: Ilya Shipitsin > > Date: Mon, 21 Dec 2020 01:03:12 +0500 > >

Re: [PR] hpack-tbl-t.h uses VAR_ARRAY and requires compiler.h to be included

2020-12-21 Thread Christian Ruppert
Hey Willy, On 2020-12-21 11:36, Willy Tarreau wrote: Hi, On Sun, Dec 20, 2020 at 12:58:52PM +0500, ??? wrote: ping :) Oh I completely missed this one in the noise it seems! I'm sorry. No problem! :) > Author: Christian Ruppert > Number of patches: 1 > > This is an automated

[PATCH] add 3 popular "contrib" tools to github actions builds

2020-12-21 Thread Илья Шипицин
Hello, this will hopefully prevent regressions on halog. Ilya From 57696674aef9431a01db6405cdba8b164162e2b9 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Mon, 21 Dec 2020 17:35:37 +0500 Subject: [PATCH] CI: github actions: build several popular "contrib" tools this adds "halog", "flags"

Bid Writing, Major Donors and Volunteering Workshops

2020-12-21 Thread NFP Workshops
NFP WORKSHOPS 18 Blake Street, York YO1 8QG 01133 280988 Affordable Training Courses for Charities, Schools & Public Sector Organisations This email has been sent to haproxy@formilux.org CLICK TO UNSUBSCRIBE FROM LIST Alternatively send a blank e-mail to unsubscr...@nfpmail2001.co.uk