Re: [PATCH] BUG/MEDIUM: sink: fix crash when null sink is used in __do_send_log

2020-06-22 Thread Christopher Faulet
Le 22/06/2020 à 10:56, Emeric Brun a écrit : Hi Daniel, Willy, On 6/19/20 9:22 PM, Willy Tarreau wrote: Hi Daniel, On Thu, Jun 18, 2020 at 12:35:29AM -0400, Daniel Corbett wrote: Hello, When using a ring log in combination with proto fcgi, it was possible to cause a crash by sending a

Re: [PATCH] BUG/MEDIUM: sink: fix crash when null sink is used in __do_send_log

2020-06-22 Thread Emeric Brun
Hi Daniel, Willy, On 6/19/20 9:22 PM, Willy Tarreau wrote: > Hi Daniel, > > On Thu, Jun 18, 2020 at 12:35:29AM -0400, Daniel Corbett wrote: >> Hello, >> >> >> When using a ring log in combination with proto fcgi, it was possible >> to cause a crash by sending a request for a non-existent fastcgi

Re: [PATCH] BUG/MEDIUM: sink: fix crash when null sink is used in __do_send_log

2020-06-20 Thread Daniel Corbett
Hello, On 6/19/20 3:22 PM, Willy Tarreau wrote: Hi Daniel, ... Thanks for the fix and the detailed report, that's very useful! However the problem is somewhere else, and I suspect is slightly harder to solve. It's normally not possible to have a null sink on a log server if its type is a

Re: [PATCH] BUG/MEDIUM: sink: fix crash when null sink is used in __do_send_log

2020-06-19 Thread Willy Tarreau
2884 > #11 0x00005586ffefa956 in run_thread_poll_loop (data=0x0) at > src/haproxy.c:3056 > #12 0x5586ffefc622 in main (argc=4, argv=0x7ffcd94960a8) at > src/haproxy.c:3758 > > > > Thanks, > > -- Daniel > > > >From c5793a0ab7372329b7bc69e823b4bb960

Re: [PATCH] BUG/MEDIUM: sink: fix crash when null sink is used in __do_send_log

2020-06-17 Thread Daniel Corbett
Hello, On 6/18/20 12:35 AM, Daniel Corbett wrote: Hello, When using a ring log in combination with proto fcgi, it was possible to cause a crash by sending a request for a non-existent fastcgi file to php-fpm, causing it to produce the error "Primary script unknown". When php-fpm produces

[PATCH] BUG/MEDIUM: sink: fix crash when null sink is used in __do_send_log

2020-06-17 Thread Daniel Corbett
efc622 in main (argc=4, argv=0x7ffcd94960a8) at src/haproxy.c:3758 Thanks, -- Daniel >From c5793a0ab7372329b7bc69e823b4bb960311a58a Mon Sep 17 00:00:00 2001 From: Daniel Corbett Date: Thu, 18 Jun 2020 00:10:17 -0400 Subject: [PATCH] BUG/MEDIUM: sink: fix crash when null sink is used in