Re: HAProxy 1.8.X crashing

2018-04-13 Thread Willy Tarreau
Hi Praveen, On Fri, Apr 13, 2018 at 02:03:47PM +, UPPALAPATI, PRAVEEN wrote: > Hi Oliver, > > The crash got fixed with the patch you provided before. Thanks for this useful feedback! > Do you thing the latest patch will be the right solution? It should, and if it doesn't, it means we

Re: HAProxy 1.8.X crashing

2018-04-13 Thread Olivier Houchard
Hi Praveen, On Fri, Apr 13, 2018 at 02:03:47PM +, UPPALAPATI, PRAVEEN wrote: > Hi Oliver, > > The crash got fixed with the patch you provided before. > > Do you thing the latest patch will be the right solution? > > Thanks, > Praveen. > It should be fine. Regards, Olivier

RE: HAProxy 1.8.X crashing

2018-04-13 Thread UPPALAPATI, PRAVEEN
.eu> Cc: UPPALAPATI, PRAVEEN <pu5...@att.com>; haproxy@formilux.org Subject: Re: HAProxy 1.8.X crashing Hi, On Thu, Apr 12, 2018 at 11:33:43PM +0200, Willy Tarreau wrote: > That may be the problem. But if a mux fails to initialize, then we can't > destroy them either ? Is cs_destroy(

Re: HAProxy 1.8.X crashing

2018-04-13 Thread Willy Tarreau
On Fri, Apr 13, 2018 at 03:56:31PM +0200, Olivier Houchard wrote: > Ok, here is a patch that does exactly what you suggest. I'm not entirely > happy with it, but it'll do the job, as a stopgap. I want this crash > fixed :) Great, now merged, thank you! If you don't mind, I changed the tag to

Re: HAProxy 1.8.X crashing

2018-04-13 Thread Olivier Houchard
Hi, On Thu, Apr 12, 2018 at 11:33:43PM +0200, Willy Tarreau wrote: > That may be the problem. But if a mux fails to initialize, then we can't > destroy them either ? Is cs_destroy() the problem here maybe ? If so, I > suspect that this approach would be more robust and would better match > the

Re: HAProxy 1.8.X crashing

2018-04-12 Thread Willy Tarreau
On Thu, Apr 12, 2018 at 01:14:58PM +0200, Olivier Houchard wrote: > > > @@ -3718,6 +3719,8 @@ int http_process_request(struct stream *s, struct > > > channel *req, int an_bit) > > > > > > return 0; > > > } > > > + /* XXX: We probably need a better mux */ > >

Re: HAProxy 1.8.X crashing

2018-04-12 Thread Olivier Houchard
Hi Willy, On Thu, Apr 12, 2018 at 08:53:51AM +0200, Willy Tarreau wrote: > Hi Olivier, > > On Wed, Apr 11, 2018 at 05:29:15PM +0200, Olivier Houchard wrote: > > From 7c9f06727cf60acf873353ac71283ff9c562aeee Mon Sep 17 00:00:00 2001 > > From: Olivier Houchard > > Date:

Re: HAProxy 1.8.X crashing

2018-04-12 Thread Willy Tarreau
Hi Olivier, On Wed, Apr 11, 2018 at 05:29:15PM +0200, Olivier Houchard wrote: > From 7c9f06727cf60acf873353ac71283ff9c562aeee Mon Sep 17 00:00:00 2001 > From: Olivier Houchard > Date: Wed, 11 Apr 2018 17:23:17 +0200 > Subject: [PATCH] BUG/MINOR: connection: Setup a mux

Re: HAProxy 1.8.X crashing

2018-04-11 Thread Olivier Houchard
Hi Praveen, On Wed, Apr 11, 2018 at 02:16:28PM +, UPPALAPATI, PRAVEEN wrote: > Hi Haproxy-Team, > > I tried compiling different minor versions of 1.8.x releases and all the > minor versions are crashing whe trying to use option http-proxy: > > Configuration that is causing issue: > >

HAProxy 1.8.X crashing

2018-04-11 Thread UPPALAPATI, PRAVEEN
Hi Haproxy-Team, I tried compiling different minor versions of 1.8.x releases and all the minor versions are crashing whe trying to use option http-proxy: Configuration that is causing issue: listen http_proxy- bind *:9876 mode http option httplog http-request set-uri