Re: [ANNOUNCE] haproxy-1.5-dev26 (and hopefully last)

2014-05-31 Thread Dmitry Sivachenko
On 29 мая 2014 г., at 3:04, Willy Tarreau w...@1wt.eu wrote: Yes it does but it doesn't change its verdict. The test is really bogus I think : const char fmt[] = blah; printf(fmt); = OK const char *fmt= blah; printf(fmt); = KO const char * const fmt =

Re: [ANNOUNCE] haproxy-1.5-dev26 (and hopefully last)

2014-05-28 Thread Vincent Bernat
❦ 28 mai 2014 18:11 +0200, Willy Tarreau w...@1wt.eu : Feedback welcome as usual, When compiling with -Werror=format-security (which is a common settings on a Debian-based distribution), we get: src/dumpstats.c:3059:4: error: format not a string literal and no format arguments

Re: [ANNOUNCE] haproxy-1.5-dev26 (and hopefully last)

2014-05-28 Thread Ryan O'Hara
On Wed, May 28, 2014 at 08:43:10PM +0200, Vincent Bernat wrote: ❦ 28 mai 2014 18:11 +0200, Willy Tarreau w...@1wt.eu : Feedback welcome as usual, When compiling with -Werror=format-security (which is a common settings on a Debian-based distribution), we get: src/dumpstats.c:3059:4:

Re: [ANNOUNCE] haproxy-1.5-dev26 (and hopefully last)

2014-05-28 Thread Willy Tarreau
Hi Vincent, On Wed, May 28, 2014 at 08:43:10PM +0200, Vincent Bernat wrote: ??? 28 mai 2014 18:11 +0200, Willy Tarreau w...@1wt.eu : Feedback welcome as usual, When compiling with -Werror=format-security (which is a common settings on a Debian-based distribution), we get:

Re: [ANNOUNCE] haproxy-1.5-dev26 (and hopefully last)

2014-05-28 Thread Vincent Bernat
❦ 28 mai 2014 22:59 +0200, Willy Tarreau w...@1wt.eu : When compiling with -Werror=format-security (which is a common settings on a Debian-based distribution), we get: src/dumpstats.c:3059:4: error: format not a string literal and no format arguments [-Werror=format-security]

Re: [ANNOUNCE] haproxy-1.5-dev26 (and hopefully last)

2014-05-28 Thread Willy Tarreau
On Wed, May 28, 2014 at 11:04:45PM +0200, Vincent Bernat wrote: ??? 28 mai 2014 22:59 +0200, Willy Tarreau w...@1wt.eu : When compiling with -Werror=format-security (which is a common settings on a Debian-based distribution), we get: src/dumpstats.c:3059:4: error: format not a string

Re: [ANNOUNCE] haproxy-1.5-dev26 (and hopefully last)

2014-05-28 Thread Vincent Bernat
❦ 28 mai 2014 23:16 +0200, Willy Tarreau w...@1wt.eu : src/dumpstats.c:3059:4: error: format not a string literal and no format arguments [-Werror=format-security] chunk_appendf(trash, srv_hlt_st[1]); /* DOWN (agent) */ ^ srv_hlt_st[1] is DOWN %s/%s, so this is not even a

Re: [ANNOUNCE] haproxy-1.5-dev26 (and hopefully last)

2014-05-28 Thread Willy Tarreau
On Thu, May 29, 2014 at 12:28:41AM +0200, Vincent Bernat wrote: ??? 28 mai 2014 23:16 +0200, Willy Tarreau w...@1wt.eu : src/dumpstats.c:3059:4: error: format not a string literal and no format arguments [-Werror=format-security] chunk_appendf(trash, srv_hlt_st[1]); /* DOWN

Re: [ANNOUNCE] haproxy-1.5-dev26 (and hopefully last)

2014-05-28 Thread Vincent Bernat
❦ 29 mai 2014 01:04 +0200, Willy Tarreau w...@1wt.eu : const char * hello means hello is a pointer to a const char. You may want to say const char * const hello. But gcc doesn't seem to handle it either (but clang does). Yes it does but it doesn't change its verdict. The test is really