Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-14 Thread Илья Шипицин
as for reporting "what is ubuntu-latest" and "what is ssl=stock", I did not have much success yet. github does not expose that information in easy way. actually, there's build step where image version is reported, but it is collapsed [image: image.png] ср, 14 дек. 2022 г. в 19:55, Илья Шипицин

Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-14 Thread Илья Шипицин
ср, 14 дек. 2022 г. в 19:23, William Lallemand : > On Wed, Dec 14, 2022 at 06:34:26PM +0500, Илья Шипицин wrote: > > I am attaching another patch, i.e. using "ubuntu-latest" and > "macos-latest" > > for development branches and fixed images for stable branches. > > > > Thank you, that make sense,

Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-14 Thread William Lallemand
On Wed, Dec 14, 2022 at 06:34:26PM +0500, Илья Шипицин wrote: > I am attaching another patch, i.e. using "ubuntu-latest" and "macos-latest" > for development branches and fixed images for stable branches. > Thank you, that make sense, I'll backport it to 2.6 as well. We just need to be careful

Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-14 Thread Илья Шипицин
I am attaching another patch, i.e. using "ubuntu-latest" and "macos-latest" for development branches and fixed images for stable branches. пн, 12 дек. 2022 г. в 19:57, William Lallemand : > On Mon, Dec 12, 2022 at 07:27:59PM +0500, Илья Шипицин wrote: > > I attached a patch. > > > > Thanks! > >

Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-12 Thread William Lallemand
On Mon, Dec 12, 2022 at 07:27:59PM +0500, Илья Шипицин wrote: > I attached a patch. > Thanks! > btw, we only build for the latest LibreSSL. are we ok to skip LibreSSL for > stable branches ? > In <= 2.5 we are still building with 3.5.3,

Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-12 Thread Илья Шипицин
I attached a patch. btw, we only build for the latest LibreSSL. are we ok to skip LibreSSL for stable branches ? the remaining feature requests might be addressed later, I hope пн, 12 дек. 2022 г. в 13:03, William Lallemand : > On Mon, Dec 12, 2022 at 08:48:06AM +0100, William Lallemand wrote:

Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-12 Thread William Lallemand
On Mon, Dec 12, 2022 at 08:48:06AM +0100, William Lallemand wrote: > Hi Ilya ! > > On Mon, Dec 12, 2022 at 10:56:11AM +0500, Илья Шипицин wrote: > > hello, > > > > I made some prototype of I meant: > > > > https://github.com/chipitsine/haproxy/commit/c95955ecfd1a5b514c235b0f155bfa71178b51d5 > >

Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-11 Thread Илья Шипицин
OK, I will send v2 today (I may also reintroduce 1.1.1) On Mon, Dec 12, 2022, 1:48 PM William Lallemand wrote: > Hi Ilya ! > > On Mon, Dec 12, 2022 at 10:56:11AM +0500, Илья Шипицин wrote: > > hello, > > > > I made some prototype of I meant: > > > > >

Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-11 Thread William Lallemand
Hi Ilya ! On Mon, Dec 12, 2022 at 10:56:11AM +0500, Илья Шипицин wrote: > hello, > > I made some prototype of I meant: > > https://github.com/chipitsine/haproxy/commit/c95955ecfd1a5b514c235b0f155bfa71178b51d5 > - We don't often use "dev" in our branches so we should build everything when

Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-11 Thread Илья Шипицин
hello, I made some prototype of I meant: https://github.com/chipitsine/haproxy/commit/c95955ecfd1a5b514c235b0f155bfa71178b51d5 I;m not sure how stable branches are named in private github ci. If you can enlighten me, I'll try to adopt. currently, I did the following, if branch name is either

Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-06 Thread Илья Шипицин
вт, 6 дек. 2022 г. в 23:29, Willy Tarreau : > On Tue, Dec 06, 2022 at 06:59:30PM +0100, Tim Düsterhus wrote: > > William, > > > > On 12/6/22 15:37, William Lallemand wrote: > > > As I already mentionned, I don't really like the "latest" keyword for > > > the OpenSSL version as it prevent us to

Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-06 Thread William Lallemand
Tim, On Tue, Dec 06, 2022 at 06:59:30PM +0100, Tim Düsterhus wrote: > > What I suggest is to stop using "latest" for the "git push" CI, but > > using it only in a separate CI (once a day/week I don't know). And only > > use fixed version of the libraries on the CI so builds are not broken by > >

Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-06 Thread Willy Tarreau
On Tue, Dec 06, 2022 at 06:59:30PM +0100, Tim Düsterhus wrote: > William, > > On 12/6/22 15:37, William Lallemand wrote: > > As I already mentionned, I don't really like the "latest" keyword for > > the OpenSSL version as it prevent us to have reproducible builds. > > It updates versions without

Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-06 Thread Tim Düsterhus
William, On 12/6/22 15:37, William Lallemand wrote: As I already mentionned, I don't really like the "latest" keyword for the OpenSSL version as it prevent us to have reproducible builds. It updates versions without warning, even major ones. I agree and also was not really happy with the

Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-06 Thread Илья Шипицин
вт, 6 дек. 2022 г. в 21:22, William Lallemand : > On Tue, Dec 06, 2022 at 07:54:33PM +0500, Илья Шипицин wrote: > > I recall I even promised to do something, but I did not :-) > > > > automatically determine "which is latest 3.0.x" does not make much sense, > > it is stable branch, very

Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-06 Thread William Lallemand
On Tue, Dec 06, 2022 at 07:54:33PM +0500, Илья Шипицин wrote: > I recall I even promised to do something, but I did not :-) > > automatically determine "which is latest 3.0.x" does not make much sense, > it is stable branch, very conservative. we can stick to 3.0.7, for example. > I do not expect

Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-06 Thread Илья Шипицин
I think I got the idea. looks like you use the same github actions for stable branches. either I will manage to make them different or I will stick to 3.0.something. hopefully tomorrow вт, 6 дек. 2022 г. в 19:54, Илья Шипицин : > I recall I even promised to do something, but I did not :-) >

Re: Reproducible CI build with OpenSSL and "latest" keyword

2022-12-06 Thread Илья Шипицин
I recall I even promised to do something, but I did not :-) automatically determine "which is latest 3.0.x" does not make much sense, it is stable branch, very conservative. we can stick to 3.0.7, for example. I do not expect any breaking change between 3.0.7 and 3.0.8 we can move "latest" to