Re: haproxy tests with sanitizers: bug found ? https://gitlab.com/chipitsine/haproxy/-/jobs/80667862

2018-07-11 Thread Илья Шипицин
Thanks, I'll check it out.

ср, 11 июл. 2018 г. в 18:20, Frederic Lecaille :

> On 07/11/2018 10:41 AM, Frederic Lecaille wrote:
> > On 07/10/2018 01:35 PM, Илья Шипицин wrote:
> >> Hello,
> >
> > Hello Ilya,
> >
> >> I had an idea, what if we will run reg-tests with various sanitizers ?
> >>
> >> for example,
> >>
> >> https://gitlab.com/chipitsine/haproxy/-/jobs/80667862
> >>
> >> (gcc + sanitize-address).
> >> can someone confirm a bug there ?
> >
> > I confirm there is a little bug, but without any consequence (only a
> > memleak). In fact the address sanitizer detects that the loggin buffers
> > are allocated twice by the main thread.
>
> So in fact there is no bug (see Christopher answer:
> https://www.mail-archive.com/haproxy@formilux.org/msg30622.html).
>
> After googling, it seems that libasan may produce false positives.
>
> You must not use it to run reg tests.
>
> Fred.
>


Re: haproxy tests with sanitizers: bug found ? https://gitlab.com/chipitsine/haproxy/-/jobs/80667862

2018-07-11 Thread Frederic Lecaille

On 07/11/2018 10:41 AM, Frederic Lecaille wrote:

On 07/10/2018 01:35 PM, Илья Шипицин wrote:

Hello,


Hello Ilya,


I had an idea, what if we will run reg-tests with various sanitizers ?

for example,

https://gitlab.com/chipitsine/haproxy/-/jobs/80667862

(gcc + sanitize-address).
can someone confirm a bug there ?


I confirm there is a little bug, but without any consequence (only a 
memleak). In fact the address sanitizer detects that the loggin buffers 
are allocated twice by the main thread.


So in fact there is no bug (see Christopher answer:
https://www.mail-archive.com/haproxy@formilux.org/msg30622.html).

After googling, it seems that libasan may produce false positives.

You must not use it to run reg tests.

Fred.



Re: haproxy tests with sanitizers: bug found ? https://gitlab.com/chipitsine/haproxy/-/jobs/80667862

2018-07-11 Thread Frederic Lecaille

On 07/10/2018 01:35 PM, Илья Шипицин wrote:

Hello,


Hello Ilya,


I had an idea, what if we will run reg-tests with various sanitizers ?

for example,

https://gitlab.com/chipitsine/haproxy/-/jobs/80667862

(gcc + sanitize-address).
can someone confirm a bug there ?


I confirm there is a little bug, but without any consequence (only a 
memleak). In fact the address sanitizer detects that the loggin buffers 
are allocated twice by the main thread.


I am going to provide a patch which makes your test pass in another thread.

Thank you.



Re: haproxy tests with sanitizers: bug found ? https://gitlab.com/chipitsine/haproxy/-/jobs/80667862

2018-07-10 Thread Илья Шипицин
just for the record, asan was very easy to enable:

https://gitlab.com/chipitsine/haproxy/blob/master/.gitlab-ci.yml

вт, 10 июл. 2018 г. в 16:35, Илья Шипицин :

> Hello,
>
> I had an idea, what if we will run reg-tests with various sanitizers ?
>
> for example,
>
> https://gitlab.com/chipitsine/haproxy/-/jobs/80667862
>
> (gcc + sanitize-address).
> can someone confirm a bug there ?
>
> "AddressSanitizer: heap-use-after-free on"
>
>
> I'll add more sanitizers later.
> thanks for your attention!
>
> Ilya Shipitsin
>