Re: [HarfBuzz] New MSVC compile issue (with current git master)

2018-11-08 Thread John Emmas
Re-sent (as I wasn't subscribed...) On 08/11/2018 17:59, John Emmas wrote: Hi Behdad, Back in September I flagged up a compilation problem I'd encountered when building with MSVC. At the time, you were a bit confused because apparently you use 'bots' of some kind to check the MSVC

[HarfBuzz] New MSVC compile issue (with current git master)

2018-11-08 Thread John Emmas
MSVC is complaining because it seems to have found 4 x declarations for 'pages' and it doesn't know which one to use. I can delve a bit deeper at the weekend when I'll have some more time available - but in the meantime, I just wondered if the bots are passing this okay? Regards, John

Re: [HarfBuzz] pangoft2 link error (was - harfbuzz: Branch 'master')

2018-09-11 Thread John Emmas
I'm not sure what's changed but after updating from git master today the problem seems to have gone ! John On 10/09/2018 10:44, Behdad Esfahbod wrote: On Fri, Sep 7, 2018 at 5:22 PM, John Emmas <mailto:j...@creativepost.co.uk>> wrote: On 07/09/2018 15:24, Behdad Esfah

Re: [HarfBuzz] MSVC compile issue with latest git master

2018-09-11 Thread John Emmas
On 10/09/2018 10:06, Behdad Esfahbod wrote: I pushed a fix to master. Please test. Thanks Behdad, that seems to have fixed it. John On Sat, Sep 8, 2018 at 8:58 AM, John Emmas <mailto:j...@creativepost.co.uk>> wrote: On 07/09/2018 19:43, Behdad Esfahbod wrote:

Re: [HarfBuzz] MSVC compile issue with latest git master

2018-09-08 Thread John Emmas
On 07/09/2018 19:43, Behdad Esfahbod wrote: The cast is fine if you also add a static_assert (sizeof (LONG) == sizeof (int), ""); right there. Please submit a github Pull Request if that works. Sorry, I don't understand... Where am I supposed to add the 'static_assert' line ?

Re: [HarfBuzz] harfbuzz: Branch 'master'

2018-09-07 Thread John Emmas
On 07/09/2018 15:24, Behdad Esfahbod wrote: src/hb-subset.cc |3 +++ 1 file changed, 3 insertions(+) Forgive me if this is unrelated - but when building with MSVC, should I be building harfbuzz as a static library or as a DLL? Currently I'm building as a static lib and up until a

Re: [HarfBuzz] MSVC compile issue with latest git master

2018-09-07 Thread John Emmas
On 07/09/2018 15:39, Behdad Esfahbod wrote: Can you check if just removing the cast works? Hi Behdad, Unfortunately no - removing the cast (by itself) doesn't work. However, if I remove the cast and then change line 258 to this, it then works:- mutable LONG v; Previously, line 258

[HarfBuzz] MSVC compile issue with latest git master

2018-09-07 Thread John Emmas
Apologies if this comes through twice (yesterday, I accidentally posted while being unsubscribed). Here's a link on MSDN which might be helpful... https://msdn.microsoft.com/en-us/library/191ca0sk.aspx On 06/09/2018 15:19, John Emmas wrote: I updated from git today and I've hit a problem when

[HarfBuzz] hb_fallback_shaper stuff

2017-02-18 Thread John Emmas
I just updated from Harfbuzz git master and tried to build with MSVC. When compiling src/hb-fallback-shape.cc it now gives me a lot of errors, starting with this at line 31:- error C2039: 'fallback' : is not a member of 'hb_shaper_data_t' And there are other errors relating to

Re: [HarfBuzz] harfbuzz: Branch 'master' - 2 commits

2017-02-16 Thread John Emmas
Off-topic - but is anything happening about my recent report (regarding the introduction of strtof() in hb-common.cc):- https://lists.freedesktop.org/archives/harfbuzz/2017-February/005885.html I can fix it locally if this can't get fixed upstream for some reason? John On 17/02/2017 03:07,

Re: [HarfBuzz] Problem with strtof() (in src/hb-common.cc)

2017-02-08 Thread John Emmas
Just wondering if this came through okay..? The relevant commit was #b3c0714b4b if that helps (21st Jan 2017) John On 02/02/2017 12:03, John Emmas wrote: Hi guys, When building from git master this morning (with MSVC) I noticed a minor problem in harfbuzz, src/hb-common.cc (at line 670

[HarfBuzz] Problem with strtof() (in src/hb-common.cc)

2017-02-02 Thread John Emmas
we maybe change the above line to this..? v = (float) strtod (p, ); Best regards, John Emmas ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/harfbuzz

Re: [HarfBuzz] Windows build of harfbuzz with nmake

2016-06-13 Thread John Emmas
On 13/06/2016 13:51, Khaled Hosny wrote: DirectWrite and Uniscribe backends should be disabled by default since they are only for testing purposes [...] Or may be the issue is that you are using your own build system and just included all the source files Hi Khaled, You're right to an

Re: [HarfBuzz] Windows build of harfbuzz with nmake

2016-06-13 Thread John Emmas
On 13/06/2016 10:09, Juha Martikainen wrote: I had a second build attempt where I made my own vcxproj file. There I get the following kind of errors: 1>..\..\src\hb-directwrite.cc(246): error C2039: 'directwrite' : is not a member of 'hb_shaper_data_t' 1>..\..\src\hb-directwrite.cc(257):

Re: [HarfBuzz] Windows build of harfbuzz with nmake

2016-06-13 Thread John Emmas
On 13/06/2016 08:36, Juha Martikainen wrote: nmake /f Makefile.vc CFG=release /P Resulting: NMAKE : fatal error U1073: don't know how to make 'config.h.win32' Stop. Hi Juha, In addition to what Cosimo said, it might be worthwhile to remember that it's not strictly necessary to have

Re: [HarfBuzz] Compile issue with MSVC

2016-05-23 Thread John Emmas
On 22/05/2016 17:08, Behdad Esfahbod wrote: On Thu, May 19, 2016 at 10:31 PM, John Emmas <john...@tiscali.co.uk <mailto:john...@tiscali.co.uk>> wrote: Could you possibly email me the latest versions of those files and some instructions for generating them from their res

Re: [HarfBuzz] Compile issue with MSVC

2016-05-22 Thread John Emmas
On 20/05/2016 06:31, John Emmas wrote: After processing the ".rl" files, these files get generated AFAICT:- src/hb-ot-shape-complex-indic-machine.hh src/hb-ot-shape-complex-myanmar-machine.hh src/hb-ot-shape-complex-use-machine.hh src/hb-ot-shape-complex-use-

Re: [HarfBuzz] Compile issue with MSVC

2016-05-19 Thread John Emmas
On 19/05/2016 20:00, Behdad Esfahbod wrote: Hi, You need to regenerate hb-ot-shape-complex-use-machine.cc from the .rl source. Thanks Behdad, It looks like I never got around to generating those files (I probably just grabbed them from a tarball). After processing the ".rl" files,

[HarfBuzz] Compile issue with MSVC

2016-05-19 Thread John Emmas
to #define now (which wasn't needed previously?) BTW - my internet access will be very poor for the next few days, so apologies in advance if I'm a bit slow in responding. Many thanks, John Emmas ___ HarfBuzz mailing list HarfBuzz

Re: [HarfBuzz] Questionable use of DEBUG

2013-04-30 Thread John Emmas
On 29/04/2013 10:15, John Emmas wrote: On 27/04/2013 21:37, Behdad Esfahbod wrote: The debug is fine. The if gets optimized out by the compiler. That's by design. Hi Behdad. Can I ask how confident you are about this (for example, is there something in the Harfbuzz code to guarantee

Re: [HarfBuzz] Questionable use of DEBUG

2013-04-30 Thread John Emmas
On 30/04/2013 07:41, Konstantin Ritt wrote: Hi Behdad, John is probably right, having DEBUG macro defined in release mode could potentially lead to a hard-tracking issues. And this possibility grows when we're compiling Harfbuzz in instead of linking to it. Maybe worth of renaming to

Re: [HarfBuzz] Questionable use of DEBUG

2013-04-29 Thread John Emmas
On 27/04/2013 18:06, John Emmas wrote: Line 568 of 'hb-private.hh looks like this:- #define DEBUG(WHAT) (DEBUG_LEVEL (WHAT, 0)) It's making me feel uneasy because DEBUG will be defined, even for a Release build. Is that the intended behaviour? On 27/04/2013 21:37, Behdad Esfahbod

[HarfBuzz] Missing header files

2013-04-28 Thread John Emmas
Hi Behdad, I hope you can help with a small build problem I need to build Harfbuzz using MSVC. Previously I'd already built it as part of pango - but since it got separated from pango, Harfbuzz seems to have grown quite a bit. I've still got my original MSVC project so, in theory, to

[HarfBuzz] Questionable use of DEBUG

2013-04-27 Thread John Emmas
Line 568 of 'hb-private.hh looks like this:- #define DEBUG(WHAT) (DEBUG_LEVEL (WHAT, 0)) It's making me feel uneasy because DEBUG will be defined, even for a Release build. Is that the intended behaviour? John ___ HarfBuzz mailing list