Re: [HarfBuzz] harfbuzz: Branch 'master'

Please file github issues if issue persists. On Mon, Sep 10, 2018 at 11:44 AM, Behdad Esfahbod wrote: > On Fri, Sep 7, 2018 at 5:22 PM, John Emmas > wrote: > >> On 07/09/2018 15:24, Behdad Esfahbod wrote: >> >>> src/hb-subset.cc |3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> >>

Re: [HarfBuzz] harfbuzz: Branch 'master'

On Fri, Sep 7, 2018 at 5:22 PM, John Emmas wrote: > On 07/09/2018 15:24, Behdad Esfahbod wrote: > >> src/hb-subset.cc |3 +++ >> 1 file changed, 3 insertions(+) >> >> > Forgive me if this is unrelated - but when building with MSVC, should I be > building harfbuzz as a static library or as

Re: [HarfBuzz] harfbuzz: Branch 'master'

On 07/09/2018 15:24, Behdad Esfahbod wrote: src/hb-subset.cc |3 +++ 1 file changed, 3 insertions(+) Forgive me if this is unrelated - but when building with MSVC, should I be building harfbuzz as a static library or as a DLL? Currently I'm building as a static lib and up until a

Re: [HarfBuzz] harfbuzz: Branch 'master'

On Tue, Feb 20, 2018 at 6:24 PM, Richard Wordingham < richard.wording...@ntlworld.com> wrote: > On Tue, 20 Feb 2018 22:36:46 + (UTC) > beh...@kemper.freedesktop.org (Behdad Esfahbod) wrote: > > > +++ b/src/hb-ot-shape-complex-indic-machine.hh > ... > > +static const short

Re: [HarfBuzz] harfbuzz: Branch 'master'

On Tue, 20 Feb 2018 22:36:46 + (UTC) beh...@kemper.freedesktop.org (Behdad Esfahbod) wrote: > +++ b/src/hb-ot-shape-complex-indic-machine.hh ... > +static const short _indic_syllable_machine_indicies[] = { Have you been advised that the English word is spelt 'indices'? Richard.

Re: [HarfBuzz] harfbuzz: Branch 'master'

On Thu, Sep 14, 2017 at 6:03 PM, Konstantin Ritt wrote: > What about MinGW, MSVC, WinCE? I don't think they'll be so nice to use > autoconf ;) > They can define HAVE_...? Or if you mean the cmake system, I don't maintain it. Ebrahim, etc do. They can adapt this. Regards, >

Re: [HarfBuzz] harfbuzz: Branch 'master'

What about MinGW, MSVC, WinCE? I don't think they'll be so nice to use autoconf ;) Regards, Konstantin 2017-09-15 4:51 GMT+04:00 Behdad Esfahbod : > configure.ac |4 ++-- > src/hb-common.cc | 53 ++ > +-- >

Re: [HarfBuzz] harfbuzz: Branch 'master'

On 10/08/2017 05:43, Martin Hosken wrote: Dear Behdad, - if (buffer == NULL) + if (!buffer) Always wanting to learn. How does this cause a divide by zero? Or what led you to make the change? It doesn't, that's purely stylistic. The real change in this commit comes later on:

Re: [HarfBuzz] harfbuzz: Branch 'master'

> -if (subtable_record == NULL) > +if (!subtable_record || !x_ppem || !y_ppem) > return false; is the real fix. The other changes are no-op. Regards, Konstantin 2017-08-10 8:43 GMT+04:00 Martin Hosken : > Dear Behdad, > > > - if (buffer == NULL) > > + if

Re: [HarfBuzz] harfbuzz: Branch 'master'

Dear Behdad, > - if (buffer == NULL) > + if (!buffer) Always wanting to learn. How does this cause a divide by zero? Or what led you to make the change? TIA, Martin ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org

Re: [HarfBuzz] harfbuzz: Branch 'master' - 2 commits

Off-topic - but is anything happening about my recent report (regarding the introduction of strtof() in hb-common.cc):- https://lists.freedesktop.org/archives/harfbuzz/2017-February/005885.html I can fix it locally if this can't get fixed upstream for some reason? John On 17/02/2017 03:07,

Re: [HarfBuzz] harfbuzz: Branch 'master'

On 16-01-04 02:33 AM, Martin Hosken wrote: > Dear Behdad, > >>> So, I would add an enum to the debug message to give a debug message event >>> type. >> >> My current thinking is that everything is transferred as a text API in >> one-line messages. The client can transform that to an enum if

Re: [HarfBuzz] harfbuzz: Branch 'master'

Dear Behdad, > > So, I would add an enum to the debug message to give a debug message event > > type. > > My current thinking is that everything is transferred as a text API in > one-line messages. The client can transform that to an enum if desired. That works only if the messages are

Re: [HarfBuzz] harfbuzz: Branch 'master'

Hi Martin, others, On 15-12-21 01:59 AM, Martin Hosken wrote: > Dear Behdad, > >> buf = hb.buffer_create () >> +class Debugger(object): >> +def message (self, buf, font, msg, data, _x_what_is_this): >> +print(msg) >> +return True >> +debugger = Debugger() >>

Re: [HarfBuzz] harfbuzz: Branch 'master'

Dear Behdad, > buf = hb.buffer_create () > +class Debugger(object): > + def message (self, buf, font, msg, data, _x_what_is_this): > + print(msg) > + return True > +debugger = Debugger() > +hb.buffer_set_message_func (buf, debugger.message, 1, 0) > hb.buffer_add_utf8

Re: [HarfBuzz] harfbuzz: Branch 'master'

Dear Behdad, > buf = hb.buffer_create () > +class Debugger(object): > + def message (self, buf, font, msg, data, _x_what_is_this): > + print(msg) > + return True > +debugger = Debugger() > +hb.buffer_set_message_func (buf, debugger.message, 1, 0) > hb.buffer_add_utf8

Re: [HarfBuzz] harfbuzz: Branch 'master'

On 15-12-18 07:49 PM, Rajeesh K V wrote: > Hi Behdad, > > > On Thu, Dec 17, 2015 at 6:31 PM, Behdad Esfahbod > > wrote: > > src/hb-ot-shape-complex-indic.cc | 11 +-- > 1 file changed, 9 insertions(+), 2

Re: [HarfBuzz] harfbuzz: Branch 'master'

Hi Behdad, On Thu, Dec 17, 2015 at 6:31 PM, Behdad Esfahbod < beh...@kemper.freedesktop.org> wrote: > src/hb-ot-shape-complex-indic.cc | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > New commits: > commit 508cc3d3cfcfb0383df0fe795cc28db4e0fd5729 > Author: Behdad

Re: [HarfBuzz] harfbuzz: Branch 'master'

On 6/11/15 07:45, Behdad Esfahbod wrote: diff --git a/src/hb-buffer-private.hh b/src/hb-buffer-private.hh index 721e718..8d9ae7c 100644 --- a/src/hb-buffer-private.hh +++ b/src/hb-buffer-private.hh @@ -35,6 +35,16 @@ #include "hb-unicode-private.hh" +#ifndef HB_BUFFER_MAX_EXPANSION_FACTOR

Re: [HarfBuzz] harfbuzz: Branch 'master'

On 15-11-06 02:17 AM, Jonathan Kew wrote: >> >> +#ifndef HB_BUFFER_MAX_LEN_DEFAULT_ > > Oops -- there seems to be a stray underscore at the end here. Fixed. Thanks for reviewing! Any comments on the 'stch' code? I wasn't sure if I should put it into a release today or not; by the end, I was

Re: [HarfBuzz] harfbuzz: Branch 'master'

On 15-10-03 01:55 PM, Konstantin Ritt wrote: > Can not one do this by defining his own malloc/../free in config.h + passing > -DHAVE_CONFIG instead? I thought that probably blows up inside stdlib.h... > Regards, > Konstantin > > 2015-10-03 16:21 GMT+04:00 Behdad Esfahbod

Re: [HarfBuzz] harfbuzz: Branch 'master' - 2 commits

On 15-01-27 09:40 AM, Jonathan Kew wrote: Meaning basically an API that accepts 16-bit codepoints but does not handle surrogate pairs, so it would in effect support UCS-2 rather than UTF-16? I doubt there's much of a use-case for that. Yes, in case you or anyone has a 16bit representation for

Re: [HarfBuzz] harfbuzz: Branch 'master' - 2 commits

On 26/1/15 22:33, Behdad Esfahbod wrote: This is by no ways to promote non-Unicode encodings. This is an entry point that takes Unicode codepoints that happen to all be the first 256 characters and hence fit in 8bit strings. This is useful eg in Chrome where strings that

Re: [HarfBuzz] harfbuzz: Branch 'master' - 4 commits

On 14-12-28 09:13 PM, Werner LEMBERG wrote: Originally I wanted to change hb_ft_face_create() and hb_ft_font_create() to reference the face if destroy==NULL was passed in. That would improve pretty much all clients, with little undesired effects. Except that FreeType

Re: [HarfBuzz] harfbuzz: Branch 'master' - 4 commits

Originally I wanted to change hb_ft_face_create() and hb_ft_font_create() to reference the face if destroy==NULL was passed in. That would improve pretty much all clients, with little undesired effects. Except that FreeType itself, when compiled with HarfBuzz support,

Re: [HarfBuzz] harfbuzz: Branch 'master' - 2 commits

Ouch. Thanks. On 14-06-27 05:51 PM, Jonathan Kew wrote: This looks like a typo? @@ -311,6 +428,7 @@ struct CmapSubtable case 10: return TRACE_RETURN (u.format10.sanitize (c)); case 12: return TRACE_RETURN (u.format12.sanitize (c)); case 13: return TRACE_RETURN

Re: [HarfBuzz] harfbuzz: Branch 'master' - 2 commits

On 15/5/14 01:19, Martin Hosken wrote: Dear Behdad, The previous grammar for medial group was allowing an Asat after the medial group only if there was a medial Wa or Ha, but not if there was only a medial Ya. This doesn't make sense to me and sounds reversed, as both medial Wa and Ha are

Re: [HarfBuzz] harfbuzz: Branch 'master'

On Tue, Nov 12, 2013 at 02:23:06PM -0800, Behdad Esfahbod wrote: commit 16f175cb2e081e605fe7f9cd01bbe8c24380278a Author: Behdad Esfahbod beh...@behdad.org Date: Tue Nov 12 17:22:49 2013 -0500 Fix scratch-buffer alignment warnings This broke Uniscribe shaper for me, I’m getting an

Re: [HarfBuzz] harfbuzz: Branch 'master'

On 13-12-23 06:29 AM, Khaled Hosny wrote: On Tue, Nov 12, 2013 at 02:23:06PM -0800, Behdad Esfahbod wrote: commit 16f175cb2e081e605fe7f9cd01bbe8c24380278a Author: Behdad Esfahbod beh...@behdad.org Date: Tue Nov 12 17:22:49 2013 -0500 Fix scratch-buffer alignment warnings This broke

Re: [HarfBuzz] harfbuzz: Branch 'master'

On Mon, Dec 23, 2013 at 07:33:26AM -0500, Behdad Esfahbod wrote: On 13-12-23 06:29 AM, Khaled Hosny wrote: On Tue, Nov 12, 2013 at 02:23:06PM -0800, Behdad Esfahbod wrote: commit 16f175cb2e081e605fe7f9cd01bbe8c24380278a Author: Behdad Esfahbod beh...@behdad.org Date: Tue Nov 12 17:22:49

Re: [HarfBuzz] harfbuzz: Branch 'master'

On 13-12-23 08:22 AM, Khaled Hosny wrote: On Mon, Dec 23, 2013 at 07:33:26AM -0500, Behdad Esfahbod wrote: On 13-12-23 06:29 AM, Khaled Hosny wrote: On Tue, Nov 12, 2013 at 02:23:06PM -0800, Behdad Esfahbod wrote: commit 16f175cb2e081e605fe7f9cd01bbe8c24380278a Author: Behdad Esfahbod

Re: [HarfBuzz] harfbuzz: Branch 'master' - 3 commits

On 22/12/13 21:21, Behdad Esfahbod wrote: + if (!(frac_mask | numr_mask | dnom_mask)) + return; Maybe it would be better to require *both* numr and dnom to be present if they're to be used. Something more like if (!frac_mask (!numr_mask !dnom_mask)) return; perhaps?

Re: [HarfBuzz] harfbuzz: Branch 'master' - 3 commits

On 13-12-22 04:43 PM, Jonathan Kew wrote: On 22/12/13 21:21, Behdad Esfahbod wrote: +if (!(frac_mask | numr_mask | dnom_mask)) + return; Maybe it would be better to require *both* numr and dnom to be present if they're to be used. Something more like if (!frac_mask

Re: [HarfBuzz] harfbuzz: Branch 'master' - 5 commits

On 13-09-02 06:41 AM, Khaled Hosny wrote: On Fri, Aug 09, 2013 at 06:42:20AM -0700, Behdad Esfahbod wrote: commit 10f964623f003c70f6bdd33423420abda3820ce0 Author: Behdad Esfahbod beh...@behdad.org Date: Fri Aug 9 09:40:01 2013 -0400 Round when scaling values Doesn't matter

Re: [HarfBuzz] harfbuzz: Branch 'master' - 5 commits

On Tue, Sep 03, 2013 at 04:21:12PM -0400, Behdad Esfahbod wrote: Are you shaping at upem size? That is just the output of hb-shape, so I guess yes. If Uniscribe returns the old value then this is definitely a bug. Seems so: $ cat test | hb-shape.exe amiri-regular.ttf --shapers=uniscribe

Re: [HarfBuzz] harfbuzz: Branch 'master' - 5 commits

On Tue, Sep 03, 2013 at 06:16:37PM -0400, Behdad Esfahbod wrote: On 13-09-03 06:08 PM, Khaled Hosny wrote: On Tue, Sep 03, 2013 at 04:21:12PM -0400, Behdad Esfahbod wrote: Are you shaping at upem size? That is just the output of hb-shape, so I guess yes. If Uniscribe returns the old

Re: [HarfBuzz] harfbuzz: Branch 'master' - 5 commits

On 13-03-24 08:28 AM, Khaled Hosny wrote: On Tue, Feb 12, 2013 at 06:49:01AM -0800, Behdad Esfahbod wrote: commit 568000274c8edb5f41bc4f876ce21fcc8bdaeed8 Author: Behdad Esfahbod beh...@behdad.org Date: Tue Feb 12 09:44:57 2013 -0500 Adjust mark advance-width zeroing logic for Myanmar

Re: [HarfBuzz] harfbuzz: Branch 'master' - 5 commits

On Tue, Feb 12, 2013 at 06:49:01AM -0800, Behdad Esfahbod wrote: commit 568000274c8edb5f41bc4f876ce21fcc8bdaeed8 Author: Behdad Esfahbod beh...@behdad.org Date: Tue Feb 12 09:44:57 2013 -0500 Adjust mark advance-width zeroing logic for Myanmar Before, we were zeroing advance

Re: [HarfBuzz] harfbuzz: Branch 'master'

On Thu, Jan 31, 2013 at 03:18:35PM -0800, Behdad Esfahbod wrote: --- a/util/options.cc +++ b/util/options.cc @@ -414,7 +414,7 @@ font_options_t::get_font (void) const GString *gs = g_string_new (NULL); char buf[BUFSIZ]; #ifdef HAVE__SETMODE - _setmode (fileno (stdin),

Re: [HarfBuzz] harfbuzz: Branch 'master'

On 13-01-31 06:33 PM, Khaled Hosny wrote: On Thu, Jan 31, 2013 at 03:18:35PM -0800, Behdad Esfahbod wrote: --- a/util/options.cc +++ b/util/options.cc @@ -414,7 +414,7 @@ font_options_t::get_font (void) const GString *gs = g_string_new (NULL); char buf[BUFSIZ]; #ifdef

Re: [HarfBuzz] harfbuzz: Branch 'master' - 2 commits

On 12-12-24 12:59 AM, Pravin Satpute wrote: Reordering is still not happening. Am i missing anything? ./hb-shape /usr/share/fonts/lohit-malayalam/Lohit-Malayalam.ttf ൎക [uni0D4E=0|U0D15=1+1015] Really? This is what I get with Lohit-Malayalam 2.5.2: $ ./hb-unicode-encode d4e,d15 |

Re: [HarfBuzz] harfbuzz: Branch 'master' - 2 commits

On ?? 23 ??? 2012 10:08 ?.??., Rajeesh K Nambiar wrote: On Sun, Dec 23, 2012 at 7:25 AM, Behdad Esfahbod beh...@behdad.org mailto:beh...@behdad.org wrote: On 12-12-22 09:08 AM, Rajeesh K Nambiar wrote: commit 8b217f5ac54aa0dcbba2dd6d59aa89dde33e56c2 Author: Behdad

Re: [HarfBuzz] harfbuzz: Branch 'master' - 2 commits

On Sun, Dec 23, 2012 at 7:25 AM, Behdad Esfahbod beh...@behdad.org wrote: On 12-12-22 09:08 AM, Rajeesh K Nambiar wrote: commit 8b217f5ac54aa0dcbba2dd6d59aa89dde33e56c2 Author: Behdad Esfahbod beh...@behdad.org Date: Fri Dec 21 15:48:32 2012 -0500 [Indic] Reorder Malayalam

Re: [HarfBuzz] harfbuzz: Branch 'master' - 6 commits

On 12-12-12 09:00 PM, Khaled Hosny wrote: On Wed, Dec 12, 2012 at 08:39:26AM -0800, Behdad Esfahbod wrote: We still don't look for the old incorrect place of the featureParams. I'll wait till someone actually complains about it... Actually the first font I tested was an old-AFDKO

Re: [HarfBuzz] harfbuzz: Branch 'master' - 6 commits

On Wed, Dec 12, 2012 at 08:39:26AM -0800, Behdad Esfahbod wrote: We still don't look for the old incorrect place of the featureParams. I'll wait till someone actually complains about it... Actually the first font I tested was an old-AFDKO broken one, so I’m already complaining :)

Re: [HarfBuzz] harfbuzz: Branch 'master'

On 12-12-10 10:14 AM, Jiang Jiang wrote: On Mon, Dec 10, 2012 at 6:58 AM, Behdad Esfahbod beh...@kemper.freedesktop.org wrote: commit 071d5b831e6de5f3b24160dc77b139cb040ab886 Author: Behdad Esfahbod beh...@behdad.org Date: Mon Dec 10 00:57:00 2012 -0500 Work around missing

Re: [HarfBuzz] harfbuzz: Branch 'master'

Hi Behdad, Thank you for the change, but it seems that we need to do it for hb_apply_context_t(), not hb_would_apply_context_t() to fix the crash :) On Tue, Sep 4, 2012 at 9:19 AM, Behdad Esfahbod beh...@kemper.freedesktop.org wrote: src/hb-ot-layout-gsubgpos-private.hh |2 +- 1 file

Re: [HarfBuzz] harfbuzz: Branch 'master'

Ah, my bad. It really bothers me that GCC doesn't crash on it. So I reorganized code to make sure the same mistake won't happen again. I'm planning on removing the code in Arabic shape fallback soon though. behdad On 09/04/2012 02:31 AM, Kenichi Ishibashi wrote: Hi Behdad, Thank you for

Re: [HarfBuzz] harfbuzz: Branch 'master'

Thanks for the commit, have been waiting for this one. As for the first issue: there's only so much you can do to workaround broken fonts. -- Tom. On 02/09/12 03:40, Behdad Esfahbod wrote: src/hb-ot-shape.cc | 32 1 file changed, 32 insertions(+) New

Re: [HarfBuzz] harfbuzz: Branch 'master'

On Thu, Aug 16, 2012 at 05:11:37AM -0700, Behdad Esfahbod wrote: configure.ac | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) New commits: commit b161bfc4f6f2db0edea780b95b798ff7b559cf33 Author: Behdad Esfahbod beh...@behdad.org Date: Thu Aug 16 08:09:44

Re: [HarfBuzz] harfbuzz: Branch 'master'

On 08/16/2012 09:25 AM, Khaled Hosny wrote: On Thu, Aug 16, 2012 at 05:11:37AM -0700, Behdad Esfahbod wrote: configure.ac | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) New commits: commit b161bfc4f6f2db0edea780b95b798ff7b559cf33 Author: Behdad Esfahbod

Re: [HarfBuzz] harfbuzz: Branch 'master'

On Thu, Aug 16, 2012 at 09:27:30AM -0400, Behdad Esfahbod wrote: On 08/16/2012 09:25 AM, Khaled Hosny wrote: On Thu, Aug 16, 2012 at 05:11:37AM -0700, Behdad Esfahbod wrote: configure.ac | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) New commits: commit

Re: [HarfBuzz] harfbuzz: Branch 'master'

On Thu, Aug 16, 2012 at 03:54:06PM +0200, Khaled Hosny wrote: I didn't find any (nor against Debian package), I guess I'll submit one. https://bugs.launchpad.net/ubuntu/+source/icu/+bug/1037588 Regards, Khaled ___ HarfBuzz mailing list

Re: [HarfBuzz] harfbuzz: Branch 'master' - 2 commits

On Wednesday 28 October 2009 05:51:16 am Behdad Esfahbod wrote: contrib/harfbuzz-unicode.c | 27 --- src/harfbuzz-hebrew.c |3 ++- 2 files changed, 26 insertions(+), 4 deletions(-) New commits: commit b90ffbace5536786eafe23e28ec3eee74c7c4e27 Author: Adam