Re: [classlib] [beans] xml resource files in tests

2006-06-26 Thread Tim Ellison
Should the tests be doing a line-by line comparison anyway? i.e. I can reformat the XML file and it still means the same thing, I would not expect the test to fail. Can't you read the golden data into a DOM and check it is the same (maybe Node.isEqualNode(Node) or thereabouts)? Regards, Tim

Re: [classlib] [beans] xml resource files in tests

2006-06-26 Thread Alexei Zakharov
Since this code is located in unit test IMHO it makes some sense to compare the output line by line with the desired content. Of course it also can be (should be) read into DOM but I will need to refactor the tests to apply it. BTW, Geir has said (in private) it is ok to simply remove the

Re: [classlib] [beans] xml resource files in tests

2006-06-26 Thread Thorbjørn Ravn Andersen
Tim Ellison skrev den 26-06-2006 13:22: Should the tests be doing a line-by line comparison anyway? i.e. I can reformat the XML file and it still means the same thing, I would not expect the test to fail. James Clark defined Canonical XML in order to be able to compare xml documents as

Re: [classlib] [beans] xml resource files in tests

2006-06-26 Thread Geir Magnusson Jr
I thought I said it in public as well. Sorry. Alexei Zakharov wrote: Since this code is located in unit test IMHO it makes some sense to compare the output line by line with the desired content. Of course it also can be (should be) read into DOM but I will need to refactor the tests to

[classlib] [beans] xml resource files in tests

2006-06-22 Thread Alexei Zakharov
Hi people, While working on java.beans tests I've faced a funny problem. There are tests for XMLEncoder that perform line by line comparison of the encoder's output with static xml files from /test/resources folder (string compare). And it seems that at some point of time someone simply prepend

Re: [classlib] [beans] xml resource files in tests

2006-06-22 Thread Ilya Neverov
Hi, Is it easier to preprocess golden files data before the string comparison? Removing first XML comment with the text Copyright*Apache seems to be an action which can not modify content used in the comparison. Thank you. Ilya Neverov, Intel Middleware Products Division On 6/22/06, Alexei

Re: [classlib] [beans] xml resource files in tests

2006-06-22 Thread Alexei Zakharov
Ilya, yes, it is technically possible. But IMHO is not very elegant at the same time. 2006/6/22, Ilya Neverov [EMAIL PROTECTED]: Hi, Is it easier to preprocess golden files data before the string comparison? Removing first XML comment with the text Copyright*Apache seems to be an action which

Re: [classlib] [beans] xml resource files in tests

2006-06-22 Thread Alexei Zakharov
Well, the real question I'd like to get an answer for was: is it really impossible to remove the license from these files? 2006/6/22, Alexei Zakharov [EMAIL PROTECTED]: Ilya, yes, it is technically possible. But IMHO is not very elegant at the same time. 2006/6/22, Ilya Neverov [EMAIL