Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-06 Thread Subru Krishnan
day, July 6, 2018 at 10:59 AM > > To: Vinod Kumar Vavilapalli > > Cc: Anu Engineer , Arpit Agarwal < > > aagar...@hortonworks.com>, "su...@apache.org" , " > > yarn-...@hadoop.apache.org" , " > > hdfs-dev@hadoop.a

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-06 Thread Arpit Agarwal
ache.org" , " > yarn-...@hadoop.apache.org" , " > hdfs-dev@hadoop.apache.org" , " > common-...@hadoop.apache.org" , " > mapreduce-...@hadoop.apache.org" > Subject: Re: [VOTE] reset/force push to clean up inadvertent merge c

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-06 Thread Sunil G
@hadoop.apache.org" , " > hdfs-dev@hadoop.apache.org" , " > common-...@hadoop.apache.org" , " > mapreduce-...@hadoop.apache.org" > Subject: Re: [VOTE] reset/force push to clean up inadvertent merge commit > pushed to trunk > > Everything seems ok ex

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-06 Thread Vinod Kumar Vavilapalli
o Fumarola >> Date: Friday, July 6, 2018 at 10:59 AM >> To: Vinod Kumar Vavilapalli >> Cc: Anu Engineer , Arpit Agarwal < >> aagar...@hortonworks.com>, "su...@apache.org" , " >> yarn-...@hadoop.apache.org" , " >> hdfs-dev@hadoop.ap

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-06 Thread Anu Engineer
ot; > common-...@hadoop.apache.org" , " > mapreduce-...@hadoop.apache.org" > Subject: Re: [VOTE] reset/force push to clean up inadvertent merge commit > pushed to trunk > > Everything seems ok except the 3 commits: YARN-8435, YARN-7556, YARN-7451 >

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-06 Thread Arpit Agarwal
ot; > common-...@hadoop.apache.org" , " > mapreduce-...@hadoop.apache.org" > Subject: Re: [VOTE] reset/force push to clean up inadvertent merge commit > pushed to trunk > > Everything seems ok except the 3 commits: YARN-8435, YARN-7556, YARN-

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-06 Thread Sunil G
g" , " > yarn-...@hadoop.apache.org" , " > hdfs-dev@hadoop.apache.org" , " > common-...@hadoop.apache.org" , " > mapreduce-...@hadoop.apache.org" > Subject: Re: [VOTE] reset/force push to clean up inadvertent merge commit > pushed to tru

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-06 Thread Arpit Agarwal
dfs-dev@hadoop.apache.org" , "common-...@hadoop.apache.org" , "mapreduce-...@hadoop.apache.org" Subject: Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk Everything seems ok except the 3 commits: YARN-8435, YARN-7556, YARN-7451 are not anymore in

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-06 Thread Sunil G
Yes these patches can be cherry-picked. git cherry-pick 17262470246232d0f0651d627a4961e55b1efe6a git cherry-pick 99febe7fd50c31c0f5dd40fa7f376f2c1f64f8c3 I will try this now and will compile. - Sunil On Fri, Jul 6, 2018 at 10:59 AM Giovanni Matteo Fumarola < giovanni.fumar...@gmail.com>

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-06 Thread Giovanni Matteo Fumarola
Everything seems ok except the 3 commits: YARN-8435, YARN-7556, YARN-7451 are not anymore in trunk due to the revert. Haibo/Robert if you can recommit your patches I will commit mine subsequently to preserve the original order. (My apology for the mess I did with the merge commit) On Fri, Jul

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-06 Thread Vinod Kumar Vavilapalli
I will add that the branch also successfully compiles. Let's just move forward as is, unblock commits and just fix things if anything is broken. +Vinod > On Jul 6, 2018, at 10:30 AM, Anu Engineer wrote: > > Hi All, > > [ Thanks to Arpit for working offline and verifying that branch is

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-06 Thread Anu Engineer
Hi All, [ Thanks to Arpit for working offline and verifying that branch is indeed good.] I want to summarize what I know of this issue and also solicit other points of view. We reverted the commit(c163d1797) from the branch, as soon as we noticed it. That is, we have made no other commits

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-06 Thread Arpit Agarwal
-1 for the force push. Nothing is broken in trunk. The history looks ugly for two commits and we can live with it. The revert restored the branch to Giovanni's intent. i.e. only YARN-8435 is applied. Verified there is no delta between hashes 0d9804d and 39ad989 (HEAD). 39ad989 2018-07-05

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-06 Thread Sean Busbey
-1 (non-binding) force pushes are extremely disruptive. there's no way to know who's updated their local git repo to include these changes since the commit went in. if a merge commit is so disruptive that we need to subject folks to the inconvenience of a force push then we should have more

答复: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-05 Thread Lin,Yiqun(vip.com)
+1. -邮件原件- 发件人: Subru Krishnan [mailto:su...@apache.org] 发送时间: 2018年7月6日 5:59 收件人: Wei-Chiu Chuang 抄送: Rohith Sharma K S; Subramaniam Krishnan; yarn-...@hadoop.apache.org; Hdfs-dev; Hadoop Common; mapreduce-...@hadoop.apache.org 主题: Re: [VOTE] reset/force push to clean up inadvertent

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-05 Thread Subru Krishnan
Unfortunately since it was a merge commit, less straightforward to revert. You can find the details in the original mail thread: http://mail-archives.apache.org/mod_mbox/hadoop-yarn-dev/201807.mbox/%3CCAHqguubKBqwfUMwhtJuSD7X1Bgfro_P6FV%2BhhFhMMYRaxFsF9Q%40mail.gmail.com%3E On Thu, Jul 5, 2018 at

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-05 Thread Wei-Chiu Chuang
I'm sorry I come to this thread late. Anu commented on INFRA-16727 saying he reverted the commit. Do we still need the vote? Thanks On Thu, Jul 5, 2018 at 2:47 PM Rohith Sharma K S wrote: > +1 > > On 5 July 2018 at 14:37, Subru Krishnan wrote: > > > Folks, > > > > There was a merge commit

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-05 Thread varunsax...@apache.org
+1 On Fri, 6 Jul 2018 at 3:07 AM, Subru Krishnan wrote: > Folks, > > There was a merge commit accidentally pushed to trunk, you can find the > details in the mail thread [1]. > > I have raised an INFRA ticket [2] to reset/force push to clean up trunk. > > Can we have a quick vote for INFRA

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-05 Thread Rohith Sharma K S
+1 On 5 July 2018 at 14:37, Subru Krishnan wrote: > Folks, > > There was a merge commit accidentally pushed to trunk, you can find the > details in the mail thread [1]. > > I have raised an INFRA ticket [2] to reset/force push to clean up trunk. > > Can we have a quick vote for INFRA sign-off

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-05 Thread Sunil G
+1 for this. - Sunil On Thu, Jul 5, 2018 at 2:37 PM Subru Krishnan wrote: > Folks, > > There was a merge commit accidentally pushed to trunk, you can find the > details in the mail thread [1]. > > I have raised an INFRA ticket [2] to reset/force push to clean up trunk. > > Can we have a quick

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-05 Thread Eric Yang
+1 On 7/5/18, 2:44 PM, "Giovanni Matteo Fumarola" wrote: +1 On Thu, Jul 5, 2018 at 2:41 PM, Wangda Tan wrote: > +1 > > On Thu, Jul 5, 2018 at 2:37 PM Subru Krishnan wrote: > > > Folks, > > > > There was a merge commit accidentally pushed to

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-05 Thread Giovanni Matteo Fumarola
+1 On Thu, Jul 5, 2018 at 2:41 PM, Wangda Tan wrote: > +1 > > On Thu, Jul 5, 2018 at 2:37 PM Subru Krishnan wrote: > > > Folks, > > > > There was a merge commit accidentally pushed to trunk, you can find the > > details in the mail thread [1]. > > > > I have raised an INFRA ticket [2] to

Re: [VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-05 Thread Wangda Tan
+1 On Thu, Jul 5, 2018 at 2:37 PM Subru Krishnan wrote: > Folks, > > There was a merge commit accidentally pushed to trunk, you can find the > details in the mail thread [1]. > > I have raised an INFRA ticket [2] to reset/force push to clean up trunk. > > Can we have a quick vote for INFRA

[VOTE] reset/force push to clean up inadvertent merge commit pushed to trunk

2018-07-05 Thread Subru Krishnan
Folks, There was a merge commit accidentally pushed to trunk, you can find the details in the mail thread [1]. I have raised an INFRA ticket [2] to reset/force push to clean up trunk. Can we have a quick vote for INFRA sign-off to proceed as this is blocking all commits? Thanks, Subru [1]