[jira] [Updated] (HDFS-13913) LazyPersistFileScrubber.run() error handling is poor

2019-09-01 Thread Daniel Templeton (Jira)
[ https://issues.apache.org/jira/browse/HDFS-13913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-13913: Status: Patch Available (was: Open) > LazyPersistFileScrubber.run() error handling is

[jira] [Commented] (HDFS-13913) LazyPersistFileScrubber.run() error handling is poor

2019-07-15 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885425#comment-16885425 ] Daniel Templeton commented on HDFS-13913: - LGTM +1 pending Jenkins. >

[jira] [Resolved] (HDFS-9499) Fix typos in DFSAdmin.java

2019-07-15 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton resolved HDFS-9499. Resolution: Invalid Looks like it's already been resolved by another JIRA. > Fix typos in

[jira] [Commented] (HDFS-14047) [libhdfs++] Fix hdfsGetLastExceptionRootCause bug in test_libhdfs_threaded.c

2019-06-21 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870037#comment-16870037 ] Daniel Templeton commented on HDFS-14047: - I can't at the moment; no desktop/laptop. @weichiu,

[jira] [Resolved] (HDFS-14487) Missing Space in Client Error Message

2019-06-18 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton resolved HDFS-14487. - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.3.0 Thanks for the

[jira] [Comment Edited] (HDFS-14514) Actual read size of open file in encryption zone still larger than listing size even after enabling HDFS-11402 in Hadoop 2

2019-05-29 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851419#comment-16851419 ] Daniel Templeton edited comment on HDFS-14514 at 5/30/19 12:17 AM: ---

[jira] [Commented] (HDFS-14514) Actual read size of open file in encryption zone still larger than listing size even after enabling HDFS-11402 in Hadoop 2

2019-05-29 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851419#comment-16851419 ] Daniel Templeton commented on HDFS-14514: - LGTM. I'd like to see the last two {{if}}s in

[jira] [Updated] (HDFS-14359) Inherited ACL permissions masked when parent directory does not exist (mkdir -p)

2019-03-25 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14359: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.3.0

[jira] [Commented] (HDFS-14359) Inherited ACL permissions masked when parent directory does not exist (mkdir -p)

2019-03-25 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801220#comment-16801220 ] Daniel Templeton commented on HDFS-14359: - Alrighty. I'll get this committed. Thanks,

[jira] [Commented] (HDFS-14359) Inherited ACL permissions masked when parent directory does not exist (mkdir -p)

2019-03-20 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797246#comment-16797246 ] Daniel Templeton commented on HDFS-14359: - LGTM. +1 from me. Anyone else want to weigh in

[jira] [Commented] (HDFS-14359) Inherited ACL permissions masked when parent directory does not exist (mkdir -p)

2019-03-19 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796376#comment-16796376 ] Daniel Templeton commented on HDFS-14359: - I think you're right about the 3 failed test results.

[jira] [Commented] (HDFS-14381) Add option to hdfs dfs -cat to ignore corrupt blocks

2019-03-19 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796338#comment-16796338 ] Daniel Templeton commented on HDFS-14381: - That's a really good point. I'll update the

[jira] [Updated] (HDFS-14381) Add option to hdfs dfs to ignore corrupt blocks

2019-03-19 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14381: Description: If I have a file in HDFS that contains 100 blocks, and I happen to lose the

[jira] [Updated] (HDFS-14381) Add option to hdfs dfs to ignore corrupt blocks

2019-03-19 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14381: Summary: Add option to hdfs dfs to ignore corrupt blocks (was: Add option to hdfs dfs

[jira] [Created] (HDFS-14382) The hdfs fsck command docs do not explain the meaning of the reported fields

2019-03-19 Thread Daniel Templeton (JIRA)
Daniel Templeton created HDFS-14382: --- Summary: The hdfs fsck command docs do not explain the meaning of the reported fields Key: HDFS-14382 URL: https://issues.apache.org/jira/browse/HDFS-14382

[jira] [Created] (HDFS-14381) Add option to hdfs dfs -cat to ignore corrupt blocks

2019-03-19 Thread Daniel Templeton (JIRA)
Daniel Templeton created HDFS-14381: --- Summary: Add option to hdfs dfs -cat to ignore corrupt blocks Key: HDFS-14381 URL: https://issues.apache.org/jira/browse/HDFS-14381 Project: Hadoop HDFS

[jira] [Updated] (HDFS-14328) [Clean-up] Remove NULL check before instanceof in TestGSet

2019-03-18 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14328: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.3.0

[jira] [Commented] (HDFS-14359) Inherited ACL permissions masked when parent directory does not exist (mkdir -p)

2019-03-11 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789803#comment-16789803 ] Daniel Templeton commented on HDFS-14359: - At a first pass, it LGTM. I'll take a closer look

[jira] [Commented] (HDFS-14339) Inconsistent log level practices in RpcProgramNfs3.java

2019-03-09 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788795#comment-16788795 ] Daniel Templeton commented on HDFS-14339: - Since it's [~OneisAll]'s patch, I went ahead and

[jira] [Assigned] (HDFS-14339) Inconsistent log level practices in RpcProgramNfs3.java

2019-03-09 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned HDFS-14339: --- Assignee: Anuhan Torgonshar (was: Shweta) > Inconsistent log level practices in

[jira] [Commented] (HDFS-14333) Datanode fails to start if any disk has errors during Namenode registration

2019-03-04 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783792#comment-16783792 ] Daniel Templeton commented on HDFS-14333: - I took a look, and I don't have any comments. LGTM!

[jira] [Updated] (HDFS-14273) Fix checkstyle issues in BlockLocation's method javadoc

2019-02-20 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14273: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.3.0 Release

[jira] [Commented] (HDFS-14273) Fix checkstyle issues in BlockLocation's method javadoc

2019-02-20 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773511#comment-16773511 ] Daniel Templeton commented on HDFS-14273: - LGTM +1. I'll check it in soon. > Fix checkstyle

[jira] [Updated] (HDFS-14185) Cleanup method calls to static Assert methods in TestAddStripedBlocks

2019-01-23 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14185: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.3.0

[jira] [Commented] (HDFS-14185) Cleanup method calls to static Assert methods in TestAddStripedBlocks

2019-01-10 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739848#comment-16739848 ] Daniel Templeton commented on HDFS-14185: - +1 pending a clean(-ish) Jenkins run. > Cleanup

[jira] [Comment Edited] (HDFS-14132) Add BlockLocation.isStriped() to determine if block is replicated or Striped

2019-01-08 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737708#comment-16737708 ] Daniel Templeton edited comment on HDFS-14132 at 1/9/19 1:06 AM: - Thanks

[jira] [Updated] (HDFS-14132) Add BlockLocation.isStriped() to determine if block is replicated or Striped

2019-01-08 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14132: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.3.0

[jira] [Commented] (HDFS-14132) Add BlockLocation.isStriped() to determine if block is replicated or Striped

2019-01-08 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737703#comment-16737703 ] Daniel Templeton commented on HDFS-14132: - I don't love breaking a line on a "." when you could

[jira] [Updated] (HDFS-14121) Log message about the old hosts file format is misleading

2018-12-14 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14121: Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch

[jira] [Commented] (HDFS-14121) Log message about the old hosts file format is misleading

2018-12-14 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721324#comment-16721324 ] Daniel Templeton commented on HDFS-14121: - On further reflection, let's leave it as a WARN.  +1

[jira] [Commented] (HDFS-14121) Log message about the old hosts file format is misleading

2018-12-14 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721214#comment-16721214 ] Daniel Templeton commented on HDFS-14121: - Thanks, [~zvenczel].  The patch looks great.  One

[jira] [Commented] (HDFS-14132) Add BlockLocation.isStriped() to determine if block is replicated or Striped

2018-12-14 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721093#comment-16721093 ] Daniel Templeton commented on HDFS-14132: - Thanks for the patch, [~shwetayakkali]. A couple of

[jira] [Updated] (HDFS-13985) Clearer error message for ReplicaNotFoundException

2018-12-13 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-13985: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.3.0

[jira] [Commented] (HDFS-13985) Clearer error message for ReplicaNotFoundException

2018-12-13 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720293#comment-16720293 ] Daniel Templeton commented on HDFS-13985: - Oops. I forgot to also thank [~zvenczel] and

[jira] [Commented] (HDFS-13985) Clearer error message for ReplicaNotFoundException

2018-12-13 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720160#comment-16720160 ] Daniel Templeton commented on HDFS-13985: - LGTM +1 > Clearer error message for

[jira] [Commented] (HDFS-14126) DataNode DirectoryScanner holding global lock for too long

2018-12-13 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719884#comment-16719884 ] Daniel Templeton commented on HDFS-14126: - That error and the lag that causes it are exactly why

[jira] [Commented] (HDFS-13985) Clearer error message for ReplicaNotFoundException

2018-12-12 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719473#comment-16719473 ] Daniel Templeton commented on HDFS-13985: - Thanks' [~adam.antal]. I'm going to pick on the error

[jira] [Commented] (HDFS-14121) Log message about the old hosts file format is misleading

2018-12-12 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719123#comment-16719123 ] Daniel Templeton commented on HDFS-14121: - Thanks, [~zvenczel]. I agree with Kitti that the

[jira] [Assigned] (HDFS-13752) fs.Path stores file path in java.net.URI causes big memory waste

2018-12-04 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned HDFS-13752: --- Assignee: Barnabas Maidics > fs.Path stores file path in java.net.URI causes big

[jira] [Created] (HDFS-14121) Log message about the old hosts file format is misleading

2018-11-30 Thread Daniel Templeton (JIRA)
Daniel Templeton created HDFS-14121: --- Summary: Log message about the old hosts file format is misleading Key: HDFS-14121 URL: https://issues.apache.org/jira/browse/HDFS-14121 Project: Hadoop HDFS

[jira] [Commented] (HDFS-13998) ECAdmin NPE with -setPolicy -replicate

2018-11-27 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700796#comment-16700796 ] Daniel Templeton commented on HDFS-13998: - The safest answer is to add another CLI option. I

[jira] [Created] (HDFS-14092) Remove two-step create/append in WebHdfsFileSystem

2018-11-20 Thread Daniel Templeton (JIRA)
Daniel Templeton created HDFS-14092: --- Summary: Remove two-step create/append in WebHdfsFileSystem Key: HDFS-14092 URL: https://issues.apache.org/jira/browse/HDFS-14092 Project: Hadoop HDFS

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-16 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.3.0

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-16 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690164#comment-16690164 ] Daniel Templeton commented on HDFS-14015: - {quote}assuming this is tested (e.g. hard code the

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-15 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688972#comment-16688972 ] Daniel Templeton commented on HDFS-14015: - Patch 012 addresses: * JNI_OK for return value *

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-15 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Attachment: HDFS-14015.012.patch > Improve error handling in hdfsThreadDestructor in

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-15 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Attachment: HDFS-14015.012.patch > Improve error handling in hdfsThreadDestructor in

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-15 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Attachment: (was: HDFS-14015.012.patch) > Improve error handling in

[jira] [Commented] (HDFS-13998) ECAdmin NPE with -setPolicy -replicate

2018-11-15 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688719#comment-16688719 ] Daniel Templeton commented on HDFS-13998: - [~vinayrpet] and [~xiaochen], that's a hard-line

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-14 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687476#comment-16687476 ] Daniel Templeton commented on HDFS-14015: - Thanks for the review, [~pranay_singh]! I originally

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-14 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687111#comment-16687111 ] Daniel Templeton commented on HDFS-14015: - Oh, duh. The -1 is for not having tests in the patch.

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-14 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687029#comment-16687029 ] Daniel Templeton commented on HDFS-14015: - I just did my own review of my patch and caught some

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-14 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Attachment: HDFS-14015.011.patch > Improve error handling in hdfsThreadDestructor in

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-14 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687004#comment-16687004 ] Daniel Templeton commented on HDFS-14015: - I don't see any evidence of a test failure, so I'm not

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-13 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Attachment: HDFS-14015.010.patch > Improve error handling in hdfsThreadDestructor in

[jira] [Commented] (HDFS-13998) ECAdmin NPE with -setPolicy -replicate

2018-11-09 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681741#comment-16681741 ] Daniel Templeton commented on HDFS-13998: - Patch 002 looks good except for one minor quibble:

[jira] [Updated] (HDFS-14047) [libhdfs++] Fix hdfsGetLastExceptionRootCause bug in test_libhdfs_threaded.c

2018-11-06 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14047: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.3.0

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675930#comment-16675930 ] Daniel Templeton commented on HDFS-14015: - Attached patch 009 to address compiler warnings. >

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Attachment: HDFS-14015.009.patch > Improve error handling in hdfsThreadDestructor in

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-02 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673790#comment-16673790 ] Daniel Templeton commented on HDFS-14015: - New patch uses {{toString() + ":" + getId()}} and

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-02 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Attachment: HDFS-14015.008.patch > Improve error handling in hdfsThreadDestructor in

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-02 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673741#comment-16673741 ] Daniel Templeton commented on HDFS-14015: - I'm worried about the testing, too. No idea how to

[jira] [Commented] (HDFS-14047) [libhdfs++] Fix hdfsGetLastExceptionRootCause bug in test_libhdfs_threaded.c

2018-11-02 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673710#comment-16673710 ] Daniel Templeton commented on HDFS-14047: - LGTM +1 I'll let this sit a day or two before I

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-02 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Attachment: HDFS-14015.007.patch > Improve error handling in hdfsThreadDestructor in

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-02 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Attachment: (was: HDFS-14015.007.patch) > Improve error handling in

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-02 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673678#comment-16673678 ] Daniel Templeton commented on HDFS-14015: - I extended my patch to include more information about

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-11-02 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Attachment: HDFS-14015.007.patch > Improve error handling in hdfsThreadDestructor in

[jira] [Commented] (HDFS-14027) DFSStripedOutputStream should implement both hsync methods

2018-10-29 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667921#comment-16667921 ] Daniel Templeton commented on HDFS-14027: - LGTM +1 > DFSStripedOutputStream should implement

[jira] [Commented] (HDFS-14027) DFSStripedOutputStream should implement both hsync methods

2018-10-26 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16665685#comment-16665685 ] Daniel Templeton commented on HDFS-14027: - Thanks for the updated patch, [~xiaochen]. Last

[jira] [Commented] (HDFS-14027) DFSStripedOutputStream should implement both hsync methods

2018-10-25 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664292#comment-16664292 ] Daniel Templeton commented on HDFS-14027: - Thanks for the patch, [~xiaochen]. Couple of

[jira] [Commented] (HDFS-14022) Failing CTEST test_libhdfs

2018-10-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662774#comment-16662774 ] Daniel Templeton commented on HDFS-14022: - HDFS-14015 patch 006 also failed the same way. >

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662770#comment-16662770 ] Daniel Templeton commented on HDFS-14015: - Whew. Failed as expected. > Improve error handling

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662679#comment-16662679 ] Daniel Templeton commented on HDFS-14015: - Just in case, I just posted a patch 006 that only adds

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Attachment: HDFS-14015.006.patch > Improve error handling in hdfsThreadDestructor in

[jira] [Commented] (HDFS-14022) Failing CTEST test_libhdfs

2018-10-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662676#comment-16662676 ] Daniel Templeton commented on HDFS-14022: - Doesn't look like HDFS-15856 changed anything. I

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662671#comment-16662671 ] Daniel Templeton commented on HDFS-14015: - Still a bunch of failures. > Improve error handling

[jira] [Commented] (HDFS-14022) Failing CTEST test_libhdfs

2018-10-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662535#comment-16662535 ] Daniel Templeton commented on HDFS-14022: - Just FYI, I just retriggered the build on my placebo

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662522#comment-16662522 ] Daniel Templeton commented on HDFS-14015: - I just retriggered the build now that HDFS-15856 is

[jira] [Commented] (HDFS-14022) Failing CTEST test_libhdfs

2018-10-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662515#comment-16662515 ] Daniel Templeton commented on HDFS-14022: - I don't think so. > Failing CTEST test_libhdfs >

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-23 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661519#comment-16661519 ] Daniel Templeton commented on HDFS-14015: - Thanks, [~jojochuang] and [~pranay_singh]. How shall

[jira] [Comment Edited] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-23 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661055#comment-16661055 ] Daniel Templeton edited comment on HDFS-14015 at 10/23/18 5:54 PM: --- I

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-23 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661055#comment-16661055 ] Daniel Templeton commented on HDFS-14015: - I don't see why the tests are failing, but they're

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-23 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Attachment: HDFS-14015.005.patch > Improve error handling in hdfsThreadDestructor in

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-22 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659800#comment-16659800 ] Daniel Templeton commented on HDFS-14015: - Isn't that the build for the 1st patch? I'm surprised

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-22 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659763#comment-16659763 ] Daniel Templeton commented on HDFS-14015: - Darn it. Caught a mistake in my own review. Updated

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-22 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Attachment: HDFS-14015.004.patch > Improve error handling in hdfsThreadDestructor in

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-22 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659760#comment-16659760 ] Daniel Templeton commented on HDFS-14015: - Good catch, [~jojochuang]! I also lack a Windows box

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-22 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Attachment: HDFS-14015.003.patch > Improve error handling in hdfsThreadDestructor in

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-22 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659651#comment-16659651 ] Daniel Templeton commented on HDFS-14015: - Whoops. Posted the wrong patch before. > Improve

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-22 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Attachment: HDFS-14015.002.patch > Improve error handling in hdfsThreadDestructor in

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-22 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Status: Patch Available (was: Open) > Improve error handling in hdfsThreadDestructor in

[jira] [Updated] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-22 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-14015: Attachment: HDFS-14015.001.patch > Improve error handling in hdfsThreadDestructor in

[jira] [Commented] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-22 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659206#comment-16659206 ] Daniel Templeton commented on HDFS-14015: - I will post the patch as soon as my local build

[jira] [Created] (HDFS-14015) Improve error handling in hdfsThreadDestructor in native thread local storage

2018-10-22 Thread Daniel Templeton (JIRA)
Daniel Templeton created HDFS-14015: --- Summary: Improve error handling in hdfsThreadDestructor in native thread local storage Key: HDFS-14015 URL: https://issues.apache.org/jira/browse/HDFS-14015

[jira] [Updated] (HDFS-13846) Safe blocks counter is not decremented correctly if the block is striped

2018-09-12 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HDFS-13846: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.2.0

[jira] [Commented] (HDFS-13846) Safe blocks counter is not decremented correctly if the block is striped

2018-09-12 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612555#comment-16612555 ] Daniel Templeton commented on HDFS-13846: - Thanks, [~knanasi]. I was going to let those 3

[jira] [Created] (HDFS-13913) LazyPersistFileScrubber.run() error handling is poor

2018-09-12 Thread Daniel Templeton (JIRA)
Daniel Templeton created HDFS-13913: --- Summary: LazyPersistFileScrubber.run() error handling is poor Key: HDFS-13913 URL: https://issues.apache.org/jira/browse/HDFS-13913 Project: Hadoop HDFS

[jira] [Commented] (HDFS-13846) Safe blocks counter is not decremented correctly if the block is striped

2018-09-12 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612417#comment-16612417 ] Daniel Templeton commented on HDFS-13846: - OK, +1 from me. I'll commit later today. > Safe

[jira] [Commented] (HDFS-13846) Safe blocks counter is not decremented correctly if the block is striped

2018-09-11 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611338#comment-16611338 ] Daniel Templeton commented on HDFS-13846: - That sounds good to me. Hmmm... I'm wondering why

[jira] [Commented] (HDFS-13846) Safe blocks counter is not decremented correctly if the block is striped

2018-08-29 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596832#comment-16596832 ] Daniel Templeton commented on HDFS-13846: - I see. That makes sense. Might be nice to add a

  1   2   3   4   5   >