[jira] [Commented] (HDDS-1130) Make BenchMarkBlockManager multi-threaded

2019-02-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772575#comment-16772575 ] Hudson commented on HDDS-1130: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #160

[jira] [Commented] (HDDS-1130) Make BenchMarkBlockManager multi-threaded

2019-02-19 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772561#comment-16772561 ] Yiqun Lin commented on HDDS-1130: - LGTM, +1. Committing. > Make BenchMarkBlockManager mul

[jira] [Commented] (HDDS-1130) Make BenchMarkBlockManager multi-threaded

2019-02-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772083#comment-16772083 ] Hadoop QA commented on HDDS-1130: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDDS-1130) Make BenchMarkBlockManager multi-threaded

2019-02-19 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772008#comment-16772008 ] Lokesh Jain commented on HDDS-1130: --- [~linyiqun] Thanks for the suggestion! v3 patch fix

[jira] [Commented] (HDDS-1130) Make BenchMarkBlockManager multi-threaded

2019-02-19 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771808#comment-16771808 ] Yiqun Lin commented on HDDS-1130: - [~ljain], I'm afraid that findbugs issues still exist.

[jira] [Commented] (HDDS-1130) Make BenchMarkBlockManager multi-threaded

2019-02-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771784#comment-16771784 ] Hadoop QA commented on HDDS-1130: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDDS-1130) Make BenchMarkBlockManager multi-threaded

2019-02-19 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771751#comment-16771751 ] Lokesh Jain commented on HDDS-1130: --- [~linyiqun] Thanks for reviewing the patch! v2 patc

[jira] [Commented] (HDDS-1130) Make BenchMarkBlockManager multi-threaded

2019-02-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771614#comment-16771614 ] Hadoop QA commented on HDDS-1130: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDDS-1130) Make BenchMarkBlockManager multi-threaded

2019-02-18 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771596#comment-16771596 ] Yiqun Lin commented on HDDS-1130: - The patch almost looks good to me, two minor comments: