[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537573#comment-16537573
]
Hudson commented on HDDS-116:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14547 (See
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496943#comment-16496943
]
Hanisha Koneru commented on HDDS-116:
-
Thanks all for the reviews. Thanks [~arpitagarwal] for
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496733#comment-16496733
]
Xiaoyu Yao commented on HDDS-116:
-
Thanks [~hanishakoneru] for the update. +1 for the v4 patch.
>
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495985#comment-16495985
]
Anu Engineer commented on HDDS-116:
---
+1 from me. All my comments are addressed in patchv4. Thank you
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495923#comment-16495923
]
Arpit Agarwal commented on HDDS-116:
Thanks [~hanishakoneru]. Minor comment:
# The following comments
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495906#comment-16495906
]
genericqa commented on HDDS-116:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495833#comment-16495833
]
Hanisha Koneru commented on HDDS-116:
-
Thank you [~arpitagarwal], [~anu] and [~xyao] for the reviews. I
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495683#comment-16495683
]
Arpit Agarwal commented on HDDS-116:
Thanks [~hanishakoneru], the patch looks good.
Let's move the
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495542#comment-16495542
]
Hanisha Koneru commented on HDDS-116:
-
Thanks [~anu] and [~xyao] for the reviews.
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495415#comment-16495415
]
Xiaoyu Yao commented on HDDS-116:
-
{quote}I think we can instead use AtomicLong? Thoughts?
{quote}
Yes, we
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495321#comment-16495321
]
Anu Engineer commented on HDDS-116:
---
I am +1 on this change, Have one minor comment.
#
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494507#comment-16494507
]
Hanisha Koneru commented on HDDS-116:
-
[~bharatviswa],
We would use the default max size of container.
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494505#comment-16494505
]
Hanisha Koneru commented on HDDS-116:
-
Thanks for the review [~xyao].
{quote}nextVolumeIndex can be
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494110#comment-16494110
]
Bharat Viswanadham commented on HDDS-116:
-
Hi [~hanishakoneru]
Thank You for the patch.
I have
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493954#comment-16493954
]
Xiaoyu Yao commented on HDDS-116:
-
Thanks [~hanishakoneru] for the update. The patch v3 looks good to me
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491406#comment-16491406
]
genericqa commented on HDDS-116:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491345#comment-16491345
]
Hanisha Koneru commented on HDDS-116:
-
Thanks for the review [~xyao]. Addressed your comments in patch
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489610#comment-16489610
]
Xiaoyu Yao commented on HDDS-116:
-
Thanks [~hanishakoneru] for working on this. I have a few comments
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488244#comment-16488244
]
genericqa commented on HDDS-116:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488116#comment-16488116
]
genericqa commented on HDDS-116:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
20 matches
Mail list logo
