[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537574#comment-16537574
]
Hudson commented on HDDS-123:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14547 (See
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503910#comment-16503910
]
Bharat Viswanadham commented on HDDS-123:
-
Committed to feature branch HDDS-48.
> ContainerSet
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503908#comment-16503908
]
Bharat Viswanadham commented on HDDS-123:
-
Thank You [~xyao] [~hanishakoneru] and [~msingh] for
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503842#comment-16503842
]
Xiaoyu Yao commented on HDDS-123:
-
Thanks [~bharatviswa] for the update. +1 for patch v5.
> ContainerSet
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502800#comment-16502800
]
Bharat Viswanadham commented on HDDS-123:
-
Hi [~xyao]
I have addressed review comments.
Could you
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502616#comment-16502616
]
Hanisha Koneru commented on HDDS-123:
-
Thanks [~bharatviswa].
+1 for patch v05.
> ContainerSet class
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501224#comment-16501224
]
genericqa commented on HDDS-123:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501147#comment-16501147
]
genericqa commented on HDDS-123:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501143#comment-16501143
]
Bharat Viswanadham commented on HDDS-123:
-
Hi [~msingh]
Thank You for review.
Addressed your
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501134#comment-16501134
]
Mukul Kumar Singh commented on HDDS-123:
Thanks for working on this [~bharatviswa]. The v4 patch
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501085#comment-16501085
]
Bharat Viswanadham commented on HDDS-123:
-
Thank You [~xyao] for review.
Addressed review
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500996#comment-16500996
]
Xiaoyu Yao commented on HDDS-123:
-
Thanks [~bharatviswa] for the patch. The v3 patch LGTM, I only have one
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498620#comment-16498620
]
genericqa commented on HDDS-123:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498546#comment-16498546
]
Bharat Viswanadham commented on HDDS-123:
-
[~hanishakoneru]
Addressed all the review comments.
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497066#comment-16497066
]
Hanisha Koneru commented on HDDS-123:
-
Thanks for working on this [~bharatviswa].
A few comments:
*
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496154#comment-16496154
]
genericqa commented on HDDS-123:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496097#comment-16496097
]
Bharat Viswanadham commented on HDDS-123:
-
Attached patch v02.
Fixed java doc issues.
>
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496054#comment-16496054
]
genericqa commented on HDDS-123:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496011#comment-16496011
]
Bharat Viswanadham commented on HDDS-123:
-
Thank You [~msingh] for review.
Addressed review
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495567#comment-16495567
]
Mukul Kumar Singh commented on HDDS-123:
Thanks for working on this [~bharatviswa]. The patch looks
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491396#comment-16491396
]
genericqa commented on HDDS-123:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491292#comment-16491292
]
Bharat Viswanadham commented on HDDS-123:
-
Not submitting the patch, as this is dependant on
22 matches
Mail list logo