[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556137#comment-16556137
]
Hanisha Koneru commented on HDDS-266:
-
Thank you [~nandakumar131] and [~bharatviswa] for reviewing and
[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555688#comment-16555688
]
Hudson commented on HDDS-266:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14637 (See
[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555618#comment-16555618
]
Nanda kumar commented on HDDS-266:
--
Test failure is not related, I will commit this shortly.
> Integrate
[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555648#comment-16555648
]
Nanda kumar commented on HDDS-266:
--
Thanks [~hanishakoneru] for the contribution and [~bharatviswa] for
[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1655#comment-1655
]
genericqa commented on HDDS-266:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554924#comment-16554924
]
Bharat Viswanadham commented on HDDS-266:
-
Hi [~hanishakoneru]
Thanks for updated patch.
+1 Looks
[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554873#comment-16554873
]
Bharat Viswanadham commented on HDDS-266:
-
I have tried to start a jenkins run for this.
[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554690#comment-16554690
]
Nanda kumar commented on HDDS-266:
--
Thanks [~hanishakoneru] for updating the patch. Looks good to me. +1,
[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554620#comment-16554620
]
Hanisha Koneru commented on HDDS-266:
-
Thanks for the review [~nandakumar131].
I have addressed your
[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553965#comment-16553965
]
Nanda kumar commented on HDDS-266:
--
+1 on v003, the patch looks good to me. Some nitpicks
[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553347#comment-16553347
]
genericqa commented on HDDS-266:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553174#comment-16553174
]
Hanisha Koneru commented on HDDS-266:
-
Thanks for the review [~bharatviswa]. Addressed your comments in
[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551428#comment-16551428
]
Bharat Viswanadham commented on HDDS-266:
-
Hi [~hanishakoneru]
Thanks for the patch. Overall patch
[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551350#comment-16551350
]
genericqa commented on HDDS-266:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551182#comment-16551182
]
Hanisha Koneru commented on HDDS-266:
-
Rebased the patch and fixed findbug and relevant tests.
>
[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551152#comment-16551152
]
Bharat Viswanadham commented on HDDS-266:
-
[~hanishakoneru] the patch doesn't apply anymore. Please
[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550018#comment-16550018
]
genericqa commented on HDDS-266:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
17 matches
Mail list logo