[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385100#comment-15385100
]
Konstantin Shvachko commented on HDFS-10301:
This looks good to me. +1
> Bloc
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384955#comment-15384955
]
Vinitha Reddy Gankidi commented on HDFS-10301:
--
Patch 011 fixes the two check
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384611#comment-15384611
]
Vinitha Reddy Gankidi commented on HDFS-10301:
--
> For example, an RPC could h
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384609#comment-15384609
]
Konstantin Shvachko commented on HDFS-10301:
Hey [~redvine],
# looks like che
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383461#comment-15383461
]
Konstantin Shvachko commented on HDFS-10301:
> adding a list of storage IDs to
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383447#comment-15383447
]
Hadoop QA commented on HDFS-10301:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vot
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383413#comment-15383413
]
Colin P. McCabe commented on HDFS-10301:
---
a/hadoop-hdfs-project/hadoop-hdfs/sr
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383300#comment-15383300
]
Hadoop QA commented on HDFS-10301:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383224#comment-15383224
]
Vinitha Reddy Gankidi commented on HDFS-10301:
--
I have made STORAGE_REPORT {{
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383161#comment-15383161
]
Konstantin Shvachko commented on HDFS-10301:
All-capital identifiers are reser
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382959#comment-15382959
]
Vinitha Reddy Gankidi commented on HDFS-10301:
--
Attached a new patch (009) ad
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380310#comment-15380310
]
Konstantin Shvachko commented on HDFS-10301:
Reviewed latest patch. Got a few
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375617#comment-15375617
]
Hadoop QA commented on HDFS-10301:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375518#comment-15375518
]
Vinitha Reddy Gankidi commented on HDFS-10301:
--
I apologize for attaching a w
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371697#comment-15371697
]
Colin P. McCabe commented on HDFS-10301:
I apologize for the delays in reviewing.
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371327#comment-15371327
]
Konstantin Shvachko commented on HDFS-10301:
[~cmccabe] this jira needs some a
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347525#comment-15347525
]
Hadoop QA commented on HDFS-10301:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347427#comment-15347427
]
Vinitha Reddy Gankidi commented on HDFS-10301:
--
Thanks for the review Colin.
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15340868#comment-15340868
]
Colin Patrick McCabe commented on HDFS-10301:
-
The "you" in that sentence was
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337302#comment-15337302
]
Konstantin Shvachko commented on HDFS-10301:
Colin, let me introduce to you [~
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335100#comment-15335100
]
Colin Patrick McCabe commented on HDFS-10301:
-
{code}
+if (context.get
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334862#comment-15334862
]
Vinitha Reddy Gankidi commented on HDFS-10301:
--
Failed tests don't seem to be
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333297#comment-15333297
]
Hadoop QA commented on HDFS-10301:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333146#comment-15333146
]
Vinitha Reddy Gankidi commented on HDFS-10301:
--
I uploaded another patch (006
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330667#comment-15330667
]
Konstantin Shvachko commented on HDFS-10301:
Colin, you seem to imply that I i
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322994#comment-15322994
]
Colin Patrick McCabe commented on HDFS-10301:
-
[~shv], comments about me "bein
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15321613#comment-15321613
]
Konstantin Shvachko commented on HDFS-10301:
Sounds like you were on -1 spree
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317644#comment-15317644
]
Colin Patrick McCabe commented on HDFS-10301:
-
Sorry for the slow reply. I wa
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313112#comment-15313112
]
Zhe Zhang commented on HDFS-10301:
--
Thanks for the discussions [~cmccabe], [~shv],[~redvi
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15308997#comment-15308997
]
Colin Patrick McCabe commented on HDFS-10301:
-
bq. Vinitha's patch adds one RP
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306941#comment-15306941
]
Konstantin Shvachko commented on HDFS-10301:
Vinitha's patch adds one RPC only
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304702#comment-15304702
]
Colin Patrick McCabe commented on HDFS-10301:
-
[~redvine], the fact that you a
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304357#comment-15304357
]
Daryn Sharp commented on HDFS-10301:
Catching up, in my sample patch I think the logic
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303287#comment-15303287
]
Vinitha Reddy Gankidi commented on HDFS-10301:
--
If we do have the check for
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303272#comment-15303272
]
Vinitha Reddy Gankidi commented on HDFS-10301:
--
I looked into why the test {{
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302426#comment-15302426
]
Colin Patrick McCabe commented on HDFS-10301:
-
I never said that patch 004 int
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299313#comment-15299313
]
Konstantin Shvachko commented on HDFS-10301:
Hey Colin, let's decide on the wa
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299255#comment-15299255
]
Vinitha Reddy Gankidi commented on HDFS-10301:
--
Thanks for your review [~cmcc
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298742#comment-15298742
]
Hadoop QA commented on HDFS-10301:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298675#comment-15298675
]
Colin Patrick McCabe commented on HDFS-10301:
-
Oh, sorry! I didn't realize we
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298604#comment-15298604
]
Zhe Zhang commented on HDFS-10301:
--
[~cmccabe] Just a quick note that it's a new JIRA rul
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298565#comment-15298565
]
Colin Patrick McCabe commented on HDFS-10301:
-
Hi [~redvine],
Thanks for your
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297592#comment-15297592
]
Hadoop QA commented on HDFS-10301:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297563#comment-15297563
]
Vinitha Reddy Gankidi commented on HDFS-10301:
--
I uploaded the patch HDFS-103
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297526#comment-15297526
]
Vinitha Reddy Gankidi commented on HDFS-10301:
--
Assigning the ticket to mysel
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271863#comment-15271863
]
Colin Patrick McCabe commented on HDFS-10301:
-
Thanks for looking at this, [~d
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271743#comment-15271743
]
Konstantin Shvachko commented on HDFS-10301:
Daryn, I also proposed throwing a
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271737#comment-15271737
]
Konstantin Shvachko commented on HDFS-10301:
??In the short term, however, I w
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270928#comment-15270928
]
Hadoop QA commented on HDFS-10301:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266715#comment-15266715
]
Daryn Sharp commented on HDFS-10301:
Still catching up and need to review patch. Firs
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264772#comment-15264772
]
Colin Patrick McCabe commented on HDFS-10301:
-
bq. You can think of it as a ne
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259688#comment-15259688
]
Konstantin Shvachko commented on HDFS-10301:
??Maybe I'm misunderstanding the
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259529#comment-15259529
]
Colin Patrick McCabe commented on HDFS-10301:
-
bq. Hey Colin, I reviewed your
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259284#comment-15259284
]
Konstantin Shvachko commented on HDFS-10301:
May be we should go with a differ
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259278#comment-15259278
]
Konstantin Shvachko commented on HDFS-10301:
Hey Colin, I reviewed your patch
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257164#comment-15257164
]
Konstantin Shvachko commented on HDFS-10301:
Yes, on trunk {{generateUniqueBlo
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256791#comment-15256791
]
Colin Patrick McCabe commented on HDFS-10301:
-
bq. [~shv] wrote: The last line
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255787#comment-15255787
]
Walter Su commented on HDFS-10301:
--
bq. BR ids are monotonically increasing.
The id value
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255772#comment-15255772
]
Walter Su commented on HDFS-10301:
--
Thank you for your explanation. I learned a lot.
> B
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254994#comment-15254994
]
Konstantin Shvachko commented on HDFS-10301:
Colin I ran your unit test and ve
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254740#comment-15254740
]
Jing Zhao commented on HDFS-10301:
--
As an optimization, maybe we can have a retry-cache s
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254673#comment-15254673
]
Konstantin Shvachko commented on HDFS-10301:
[~cmccabe] I don't think that HDF
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254668#comment-15254668
]
Konstantin Shvachko commented on HDFS-10301:
Hey [~walter.k.su], sorry let me
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254350#comment-15254350
]
Colin Patrick McCabe commented on HDFS-10301:
-
Yeah, perhaps we should file a
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253309#comment-15253309
]
Hadoop QA commented on HDFS-10301:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253236#comment-15253236
]
Walter Su commented on HDFS-10301:
--
I like your idea of counting storages with same repor
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253204#comment-15253204
]
Walter Su commented on HDFS-10301:
--
The handler threads will wait anyway, either waiting
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253181#comment-15253181
]
Walter Su commented on HDFS-10301:
--
bq. Enabling HDFS-9198 will fifo process BRs. It does
[
https://issues.apache.org/jira/browse/HDFS-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252937#comment-15252937
]
Hadoop QA commented on HDFS-10301:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
101 - 169 of 169 matches
Mail list logo