[jira] [Commented] (HDFS-10485) Fix findbugs warning in FSEditLog.java in branch-2

2016-06-06 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317607#comment-15317607 ] Arpit Agarwal commented on HDFS-10485: -- +1 thanks [~ajisakaa]. If the patch applies to trunk we

[jira] [Commented] (HDFS-10485) Fix findbugs warning in FSEditLog.java in branch-2

2016-06-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315350#comment-15315350 ] Hadoop QA commented on HDFS-10485: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-10485) Fix findbugs warning in FSEditLog.java in branch-2

2016-06-03 Thread Xiaobing Zhou (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315348#comment-15315348 ] Xiaobing Zhou commented on HDFS-10485: -- Thank you for update. The new patch looks good to me. +1

[jira] [Commented] (HDFS-10485) Fix findbugs warning in FSEditLog.java in branch-2

2016-06-03 Thread Akira AJISAKA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315293#comment-15315293 ] Akira AJISAKA commented on HDFS-10485: -- Thanks [~xiaobingo] for the review comment. bq. Can you

[jira] [Commented] (HDFS-10485) Fix findbugs warning in FSEditLog.java in branch-2

2016-06-03 Thread Xiaobing Zhou (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314946#comment-15314946 ] Xiaobing Zhou commented on HDFS-10485: -- Thank you [~ajisakaa] for the v02 patch. Can you explain why

[jira] [Commented] (HDFS-10485) Fix findbugs warning in FSEditLog.java in branch-2

2016-06-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314931#comment-15314931 ] Hadoop QA commented on HDFS-10485: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-10485) Fix findbugs warning in FSEditLog.java in branch-2

2016-06-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314665#comment-15314665 ] Hadoop QA commented on HDFS-10485: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-10485) Fix findbugs warning in FSEditLog.java in branch-2

2016-06-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314406#comment-15314406 ] Hadoop QA commented on HDFS-10485: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-10485) Fix findbugs warning in FSEditLog.java in branch-2

2016-06-03 Thread Akira AJISAKA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314384#comment-15314384 ] Akira AJISAKA commented on HDFS-10485: -- I'm thinking numTransactionBatchedInSync should be AtomicLong