[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145945#comment-16145945 ] George Huang commented on HDFS-11912: - Thank you so much [~manojg] and [~andrew.wang]

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145899#comment-16145899 ] Hudson commented on HDFS-11912: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142532#comment-16142532 ] Hadoop QA commented on HDFS-11912: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142509#comment-16142509 ] Manoj Govindassamy commented on HDFS-11912: --- LGTM. +1 pending jenkins. Thanks [~

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142397#comment-16142397 ] George Huang commented on HDFS-11912: - Thanks Manoj for the review. Change was made an

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140388#comment-16140388 ] Manoj Govindassamy commented on HDFS-11912: --- Thanks for your persistent efforts

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139551#comment-16139551 ] Hadoop QA commented on HDFS-11912: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139485#comment-16139485 ] George Huang commented on HDFS-11912: - Fixing java.util.* in previous patch. > Add a

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131669#comment-16131669 ] Hadoop QA commented on HDFS-11912: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131579#comment-16131579 ] George Huang commented on HDFS-11912: - Reducing the number of test files to be created

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130850#comment-16130850 ] George Huang commented on HDFS-11912: - Test was having a 10 min timeout. However, setu

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129881#comment-16129881 ] Manoj Govindassamy commented on HDFS-11912: --- [~ghuangups], Checkstyle issues a

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129845#comment-16129845 ] Hadoop QA commented on HDFS-11912: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129736#comment-16129736 ] George Huang commented on HDFS-11912: - Test randomly generated number of iterations fo

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127820#comment-16127820 ] Manoj Govindassamy commented on HDFS-11912: --- [~ghuangups], * The added test has

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127789#comment-16127789 ] Hadoop QA commented on HDFS-11912: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127658#comment-16127658 ] Manoj Govindassamy commented on HDFS-11912: --- [~ghuangups], Thanks for working on

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118764#comment-16118764 ] Manoj Govindassamy commented on HDFS-11912: --- Sorry for the delay. Will get back

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118752#comment-16118752 ] Andrew Wang commented on HDFS-11912: Manoj, George, do we think we can get this in? >

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077407#comment-16077407 ] Hadoop QA commented on HDFS-11912: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077305#comment-16077305 ] George Huang commented on HDFS-11912: - Hi Manoj, Thank you for the code review and gr

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048583#comment-16048583 ] Manoj Govindassamy commented on HDFS-11912: --- [~ghuangups], Thanks for working on

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039318#comment-16039318 ] Andrew Wang commented on HDFS-11912: Added George as an HDFS contributor and assigned

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038075#comment-16038075 ] Hadoop QA commented on HDFS-11912: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037913#comment-16037913 ] George Huang commented on HDFS-11912: - 1. Shouldn't the check be just (randomNum < (cu

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037867#comment-16037867 ] George Huang commented on HDFS-11912: - 3. FileSystemOperations and SnapshotOperations

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037862#comment-16037862 ] George Huang commented on HDFS-11912: - 11. Can you please print the aggregated stats a

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035663#comment-16035663 ] George Huang commented on HDFS-11912: - 10. /** Delete an existing test directory */

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035598#comment-16035598 ] George Huang commented on HDFS-11912: - 9. There is only one entry in snapshottableDire

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035593#comment-16035593 ] George Huang commented on HDFS-11912: - 8. // Get list of snapshottable directories

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035580#comment-16035580 ] George Huang commented on HDFS-11912: - 7. private String GetNewPathString(String origi

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035572#comment-16035572 ] George Huang commented on HDFS-11912: - 6. // Create files in a directory with rand

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035547#comment-16035547 ] George Huang commented on HDFS-11912: - 4. // Set Random RANDOM = new Random();

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035540#comment-16035540 ] George Huang commented on HDFS-11912: - 5. int fileLen = new Random().nextInt(MAX_N

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035535#comment-16035535 ] George Huang commented on HDFS-11912: - 2. private static MiniDFSCluster cluster; =>

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035272#comment-16035272 ] Manoj Govindassamy commented on HDFS-11912: --- continuation of my review comments.

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033920#comment-16033920 ] Hadoop QA commented on HDFS-11912: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations

[ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033821#comment-16033821 ] Manoj Govindassamy commented on HDFS-11912: --- Thanks for contributing this patch