[jira] [Commented] (HDFS-12054) FSNamesystem#addECPolicies should call checkNameNodeSafeMode() to ensure Namenode is not in safemode

2017-08-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121002#comment-16121002 ] Hadoop QA commented on HDFS-12054: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-12054) FSNamesystem#addECPolicies should call checkNameNodeSafeMode() to ensure Namenode is not in safemode

2017-08-09 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119590#comment-16119590 ] Wei-Chiu Chuang commented on HDFS-12054: Looks good to me. Would it be feasible to add tests in

[jira] [Commented] (HDFS-12054) FSNamesystem#addECPolicies should call checkNameNodeSafeMode() to ensure Namenode is not in safemode

2017-07-02 Thread lufei (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071951#comment-16071951 ] lufei commented on HDFS-12054: -- Maybe I didn't make it clear.I think this check is only useful for the kind

[jira] [Commented] (HDFS-12054) FSNamesystem#addECPolicies should call checkNameNodeSafeMode() to ensure Namenode is not in safemode

2017-06-29 Thread lufei (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067834#comment-16067834 ] lufei commented on HDFS-12054: -- [~jojochuang], thanks for your time to review.I have checked all the kind of

[jira] [Commented] (HDFS-12054) FSNamesystem#addECPolicies should call checkNameNodeSafeMode() to ensure Namenode is not in safemode

2017-06-28 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067693#comment-16067693 ] Wei-Chiu Chuang commented on HDFS-12054: Looks good to me. Would you mind to also add the same for

[jira] [Commented] (HDFS-12054) FSNamesystem#addECPolicies should call checkNameNodeSafeMode() to ensure Namenode is not in safemode

2017-06-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067661#comment-16067661 ] Hadoop QA commented on HDFS-12054: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-12054) FSNamesystem#addECPolicies should call checkNameNodeSafeMode() to ensure Namenode is not in safemode

2017-06-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067633#comment-16067633 ] Hadoop QA commented on HDFS-12054: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||