[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195539#comment-16195539
]
Hudson commented on HDFS-12273:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13045 (See
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193978#comment-16193978
]
Íñigo Goiri commented on HDFS-12273:
I just committed this. [~giovanni.fumarola] and
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193959#comment-16193959
]
Íñigo Goiri commented on HDFS-12273:
Given that the 1 second time out is mainly for the UI, we could
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193925#comment-16193925
]
Chris Douglas commented on HDFS-12273:
--
Ran the test-patch profile and skimmed the output. I don't
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193632#comment-16193632
]
Giovanni Matteo Fumarola commented on HDFS-12273:
-
+1 from my side.
The Javac warnings do
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193509#comment-16193509
]
Hadoop QA commented on HDFS-12273:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190396#comment-16190396
]
Íñigo Goiri commented on HDFS-12273:
The {{javac}} errors are consistent but don't seem related to the
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190335#comment-16190335
]
Hadoop QA commented on HDFS-12273:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190065#comment-16190065
]
Íñigo Goiri commented on HDFS-12273:
Not sure what the javac is about.
Fixed the unit tests but the
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189253#comment-16189253
]
Hadoop QA commented on HDFS-12273:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189148#comment-16189148
]
Hadoop QA commented on HDFS-12273:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189053#comment-16189053
]
Íñigo Goiri commented on HDFS-12273:
After rebase, the branch is broken because HDFS-12447 modified
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188975#comment-16188975
]
Íñigo Goiri commented on HDFS-12273:
The errors are not related to this itself.
It looks like the
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188970#comment-16188970
]
Hadoop QA commented on HDFS-12273:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188730#comment-16188730
]
Íñigo Goiri commented on HDFS-12273:
Thanks [~giovanni.fumarola], I posted a couple fixes after
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188603#comment-16188603
]
Giovanni Matteo Fumarola commented on HDFS-12273:
-
Thanks [~elgoiri] for the patch. LGTM.
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186874#comment-16186874
]
Hadoop QA commented on HDFS-12273:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186753#comment-16186753
]
Íñigo Goiri commented on HDFS-12273:
Thanks for the comments [~giovanni.fumarola]:
* I changed the
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186629#comment-16186629
]
Giovanni Matteo Fumarola commented on HDFS-12273:
-
Thanks [~elgoiri] for the patch and the
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173460#comment-16173460
]
Íñigo Goiri commented on HDFS-12273:
I created HDFS-12510 for adding security to the web server and
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172140#comment-16172140
]
Íñigo Goiri commented on HDFS-12273:
[~raviprak], sounds good.
I'll create those JIRAs outside of the
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170772#comment-16170772
]
Ravi Prakash commented on HDFS-12273:
-
I eyeballed the much smaller patch and it seems fine to me.
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168757#comment-16168757
]
Chris Douglas commented on HDFS-12273:
--
bq. one thing is missing is the WebHDFS interface. Do you
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168594#comment-16168594
]
Íñigo Goiri commented on HDFS-12273:
Thanks [~raviprak], actually, one thing is missing is the WebHDFS
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168593#comment-16168593
]
Chris Douglas commented on HDFS-12273:
--
bq. Regarding the note in the doc, I could add it here or
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168557#comment-16168557
]
Ravi Prakash commented on HDFS-12273:
-
Sorry I've since swapped out all front-end and security
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168497#comment-16168497
]
Íñigo Goiri commented on HDFS-12273:
Thanks [~chris.douglas] for the check.
I'm OK with handling
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168327#comment-16168327
]
Chris Douglas commented on HDFS-12273:
--
XSS handling could also be part of HDFS-12284. If we defer
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168325#comment-16168325
]
Chris Douglas commented on HDFS-12273:
--
Skimming the smaller patch, most of it looks straightforward.
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166643#comment-16166643
]
Íñigo Goiri commented on HDFS-12273:
The failure in {{TestNamenodeHeartbeat}} is not related to this
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165633#comment-16165633
]
Hadoop QA commented on HDFS-12273:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159447#comment-16159447
]
Íñigo Goiri commented on HDFS-12273:
The javac errors are not related to this commit; I've rebased
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159123#comment-16159123
]
Hadoop QA commented on HDFS-12273:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136101#comment-16136101
]
Íñigo Goiri commented on HDFS-12273:
[~giovanni.fumarola], thank you for the comments.
I pushed the
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136068#comment-16136068
]
Hadoop QA commented on HDFS-12273:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135948#comment-16135948
]
Giovanni Matteo Fumarola commented on HDFS-12273:
-
Thanks [~elgoiri]. Can we split this
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129575#comment-16129575
]
Giovanni Matteo Fumarola commented on HDFS-12273:
-
[~goiri], it would be great if you add
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122146#comment-16122146
]
Íñigo Goiri commented on HDFS-12273:
[~raviprak], we would appreciate feedback on the pure UI side
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122059#comment-16122059
]
Ravi Prakash commented on HDFS-12273:
-
I didn't realize this was in the Federation branch. This is way
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120389#comment-16120389
]
Ravi Prakash commented on HDFS-12273:
-
I can try to take a look but honestly I'm sorry it won't have
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119411#comment-16119411
]
Hadoop QA commented on HDFS-12273:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119258#comment-16119258
]
Hadoop QA commented on HDFS-12273:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119219#comment-16119219
]
Chris Douglas commented on HDFS-12273:
--
Really minor:
* If the comparator isn't used except for JSON
43 matches
Mail list logo