[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297315#comment-16297315
]
Nanda kumar commented on HDFS-12741:
Test failures are not related, I will commit this shortly.
> ADD
[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297100#comment-16297100
]
genericqa commented on HDFS-12741:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296917#comment-16296917
]
Nanda kumar commented on HDFS-12741:
LGTM. +1, pending Jenkins.
> ADD support for KSM
[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296543#comment-16296543
]
Nanda kumar commented on HDFS-12741:
Thanks for updating [~shashikant], the patch is almost ready.
[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292925#comment-16292925
]
genericqa commented on HDFS-12741:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290847#comment-16290847
]
genericqa commented on HDFS-12741:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289587#comment-16289587
]
genericqa commented on HDFS-12741:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289271#comment-16289271
]
Nanda kumar commented on HDFS-12741:
Thanks [~shashikant] for updating the patch, it looks pretty good
[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289270#comment-16289270
]
genericqa commented on HDFS-12741:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279303#comment-16279303
]
genericqa commented on HDFS-12741:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278994#comment-16278994
]
Nanda kumar commented on HDFS-12741:
Please also fix the checkstyle and whitespace issues.
> ADD
[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278991#comment-16278991
]
Nanda kumar commented on HDFS-12741:
Thanks [~shashikant] for updating the patch.
In
[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277496#comment-16277496
]
genericqa commented on HDFS-12741:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273046#comment-16273046
]
Nanda kumar commented on HDFS-12741:
Thanks [~shashikant] for working on this. Patch looks good to me,
[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268485#comment-16268485
]
Yiqun Lin commented on HDFS-12741:
--
Thanks for the updating, [~shashikant]. Almost looks good to me.
[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267161#comment-16267161
]
genericqa commented on HDFS-12741:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262167#comment-16262167
]
Yiqun Lin commented on HDFS-12741:
--
Thanks for working on this, [~shashikant]. Overall looks good to me
[
https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261633#comment-16261633
]
Shashikant Banerjee commented on HDFS-12741:
Removing the patch as it does not apply . Will
18 matches
Mail list logo