[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447267#comment-16447267
]
Hudson commented on HDFS-13055:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14043 (See
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408572#comment-16408572
]
genericqa commented on HDFS-13055:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408332#comment-16408332
]
Ajay Kumar commented on HDFS-13055:
---
[~bharatviswa], thanks for review. addressed your comments in v10.
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405748#comment-16405748
]
genericqa commented on HDFS-13055:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405652#comment-16405652
]
Bharat Viswanadham commented on HDFS-13055:
---
Hi [~ajayydv]
Thanks for the patch.
LGTM. with
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405646#comment-16405646
]
Ajay Kumar commented on HDFS-13055:
---
patch v9 t0 address checkstyle issues, test failures are unrelated.
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402443#comment-16402443
]
genericqa commented on HDFS-13055:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402244#comment-16402244
]
Ajay Kumar commented on HDFS-13055:
---
[~arpitagarwal] thanks for offline discussion. Updated patch v8 to
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399794#comment-16399794
]
Ajay Kumar commented on HDFS-13055:
---
[~arpitagarwal] thanks, patch v7 contains first part (i.e Generate
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397888#comment-16397888
]
Arpit Agarwal commented on HDFS-13055:
--
I think this patch will benefit from splitting into smaller
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397884#comment-16397884
]
Arpit Agarwal commented on HDFS-13055:
--
Thanks for updating the patch [~ajayydv]. I have not reviewed
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386899#comment-16386899
]
genericqa commented on HDFS-13055:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386595#comment-16386595
]
Ajay Kumar commented on HDFS-13055:
---
Failed tests pass locally. Added javdoc comment in patch v6 to new
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379314#comment-16379314
]
genericqa commented on HDFS-13055:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379046#comment-16379046
]
Ajay Kumar commented on HDFS-13055:
---
patch v5 to address checkstyle issues and fix broken test in
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375115#comment-16375115
]
genericqa commented on HDFS-13055:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374927#comment-16374927
]
Ajay Kumar commented on HDFS-13055:
---
v4 patch rebased with trunk.
> Aggregate usage statistics from
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374910#comment-16374910
]
genericqa commented on HDFS-13055:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373540#comment-16373540
]
genericqa commented on HDFS-13055:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373535#comment-16373535
]
Ajay Kumar commented on HDFS-13055:
---
[~arpitagarwal], thanks for review. Updated patch v3 makes changes
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363313#comment-16363313
]
Ajay Kumar commented on HDFS-13055:
---
[~arpitagarwal], Created new review request
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361388#comment-16361388
]
Arpit Agarwal commented on HDFS-13055:
--
Hi [~ajayydv], since this is a large change would you
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354833#comment-16354833
]
genericqa commented on HDFS-13055:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352955#comment-16352955
]
Ajay Kumar commented on HDFS-13055:
---
[~anu] all the concerns you raised are valid. I would have also
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338139#comment-16338139
]
genericqa commented on HDFS-13055:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338111#comment-16338111
]
Anu Engineer commented on HDFS-13055:
-
[~ajayydv] Thanks for the patch. It looks good overall. I have
[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336760#comment-16336760
]
Ajay Kumar commented on HDFS-13055:
---
Attaching initial patch for review. Will add test case soon.
>
27 matches
Mail list logo