[
https://issues.apache.org/jira/browse/HDFS-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370749#comment-16370749
]
Hudson commented on HDFS-13168:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13687 (See
[
https://issues.apache.org/jira/browse/HDFS-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370732#comment-16370732
]
Íñigo Goiri commented on HDFS-13168:
Thanks [~belugabehr] for the patch, committed to trunk.
>
[
https://issues.apache.org/jira/browse/HDFS-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370713#comment-16370713
]
BELUGA BEHR commented on HDFS-13168:
+ is turned into StringBuilder under the covers.
No preference,
[
https://issues.apache.org/jira/browse/HDFS-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370367#comment-16370367
]
Íñigo Goiri commented on HDFS-13168:
{{StringBuilder}} is more optimal but I'm not sure how does + in
[
https://issues.apache.org/jira/browse/HDFS-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370271#comment-16370271
]
BELUGA BEHR commented on HDFS-13168:
[~elgoiri] Using 'char' type is intentional. It's faster to add
[
https://issues.apache.org/jira/browse/HDFS-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369530#comment-16369530
]
genericqa commented on HDFS-13168:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369505#comment-16369505
]
Íñigo Goiri commented on HDFS-13168:
Keeping it as is for consistency makes sense.
Given we are not
[
https://issues.apache.org/jira/browse/HDFS-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369425#comment-16369425
]
BELUGA BEHR commented on HDFS-13168:
[~elgoiri] It was intentional.
Because the following method
[
https://issues.apache.org/jira/browse/HDFS-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369400#comment-16369400
]
Íñigo Goiri commented on HDFS-13168:
Thanks [~belugabehr] for the results, the performance
[
https://issues.apache.org/jira/browse/HDFS-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369368#comment-16369368
]
BELUGA BEHR commented on HDFS-13168:
{code}
## Current Implementation
Result
[
https://issues.apache.org/jira/browse/HDFS-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368685#comment-16368685
]
Íñigo Goiri commented on HDFS-13168:
[~belugabehr], do you have any approximate performance
[
https://issues.apache.org/jira/browse/HDFS-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368684#comment-16368684
]
genericqa commented on HDFS-13168:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
12 matches
Mail list logo
