[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-12-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728483#comment-16728483 ] Hudson commented on HDFS-13767: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #15662 (See

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-13 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578665#comment-16578665 ] Chen Liang commented on HDFS-13767: --- The failed test is unrelated, I've committed to the feature

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-09 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575707#comment-16575707 ] genericqa commented on HDFS-13767: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-09 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575582#comment-16575582 ] Konstantin Shvachko commented on HDFS-13767: +1, pending Jenkins. > Add msync server

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-09 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575532#comment-16575532 ] Chen Liang commented on HDFS-13767: --- Thanks [~shv] for the catch! Upload v004 patch. Investigated the

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-09 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575487#comment-16575487 ] Konstantin Shvachko commented on HDFS-13767: * Hey [~vagarychen], you did not incorporate my

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-06 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570565#comment-16570565 ] Chen Liang commented on HDFS-13767: --- Post v003 patch to fix the issue as [~zero45] found. The test

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-03 Thread Plamen Jeliazkov (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568879#comment-16568879 ] Plamen Jeliazkov commented on HDFS-13767: - I like the mixed strategy / optimization. Another

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-03 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568860#comment-16568860 ] Chen Liang commented on HDFS-13767: --- Thanks [~zero45]. I updated the previous comment, which I should

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-03 Thread Plamen Jeliazkov (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568851#comment-16568851 ] Plamen Jeliazkov commented on HDFS-13767: - Thanks for the responses, [~vagarychen]! Thank you I

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-03 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568843#comment-16568843 ] Chen Liang commented on HDFS-13767: --- Thanks for comments [~zero45]. bq. (2) A concern about the unit

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-03 Thread Plamen Jeliazkov (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568674#comment-16568674 ] Plamen Jeliazkov commented on HDFS-13767: - Hey Chen, Change looks pretty good so far; two

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-02 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567534#comment-16567534 ] genericqa commented on HDFS-13767: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-02 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567299#comment-16567299 ] Chen Liang commented on HDFS-13767: --- Thanks [~shv] and [~xkrogen] for the review and the comments! Post

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-02 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567060#comment-16567060 ] Erik Krogen commented on HDFS-13767: Cool, thanks for incorporating the feedback Chen! I agree with

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-01 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566196#comment-16566196 ] Konstantin Shvachko commented on HDFS-13767: Looks good. Comments are good, but look through

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-01 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566058#comment-16566058 ] genericqa commented on HDFS-13767: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-01 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565704#comment-16565704 ] Chen Liang commented on HDFS-13767: --- Post v001 patch to fix the naming of the patch... > Add msync

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-08-01 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565659#comment-16565659 ] genericqa commented on HDFS-13767: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-07-31 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564576#comment-16564576 ] Chen Liang commented on HDFS-13767: --- Post WIP.v004 patch. The main changes are: # changed to

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-07-31 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564011#comment-16564011 ] Chen Liang commented on HDFS-13767: --- Thanks for the followup discussion [~xkrogen]! Many thanks to the

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-07-31 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563928#comment-16563928 ] Erik Krogen commented on HDFS-13767: I agree with Konstantin's point that maintaining the ordering is

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-07-27 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560384#comment-16560384 ] Chen Liang commented on HDFS-13767: --- Thanks for the comments [~shv]! Updated WIP.003 patch with you

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-07-26 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559149#comment-16559149 ] Konstantin Shvachko commented on HDFS-13767: I like the approach. Don't think preserving the

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-07-26 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558934#comment-16558934 ] Chen Liang commented on HDFS-13767: --- Upload WIP.002 patch. The main difference from WIP.001 patch is

[jira] [Commented] (HDFS-13767) Add msync server implementation.

2018-07-25 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556255#comment-16556255 ] Chen Liang commented on HDFS-13767: --- Post WIP.001 patch for early reviews. Some notes to ease the