[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629333#comment-16629333
]
Chao Sun commented on HDFS-13790:
-
Thanks [~brahmareddy] for the review and commit!
> RBF: Move
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629167#comment-16629167
]
Brahma Reddy Battula commented on HDFS-13790:
-
+1, On HDFS-13790-branch-3.1.002.patch ->
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624106#comment-16624106
]
Hadoop QA commented on HDFS-13790:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624025#comment-16624025
]
Chao Sun commented on HDFS-13790:
-
[~brahmareddy]: sure - uploaded patch v2 for branch-3.1
> RBF: Move
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622343#comment-16622343
]
Brahma Reddy Battula commented on HDFS-13790:
-
[~csun] thanks uploading patch. can you please
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619960#comment-16619960
]
Hadoop QA commented on HDFS-13790:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619910#comment-16619910
]
Chao Sun commented on HDFS-13790:
-
[~brahmareddy], [~elgoiri]: sure - attached patches for branch-2 and
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619623#comment-16619623
]
Íñigo Goiri commented on HDFS-13790:
For branch-2, some of the investigation is going in
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619561#comment-16619561
]
Brahma Reddy Battula commented on HDFS-13790:
-
Yes,There is a Jira HADOOP-13951,I commented
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619261#comment-16619261
]
Íñigo Goiri commented on HDFS-13790:
I don't think yetus is working for branch-2.9 or branch-2.
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619108#comment-16619108
]
Hadoop QA commented on HDFS-13790:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619084#comment-16619084
]
Brahma Reddy Battula commented on HDFS-13790:
-
[~csun] thanks for updating the patches.
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614140#comment-16614140
]
Hadoop QA commented on HDFS-13790:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614095#comment-16614095
]
Chao Sun commented on HDFS-13790:
-
My apologies for the long delay [~brahmareddy]. Attached patches for
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589108#comment-16589108
]
Chao Sun commented on HDFS-13790:
-
bq. are you planning update patches for branch-3.1 to branch-2.9..?
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588855#comment-16588855
]
Brahma Reddy Battula commented on HDFS-13790:
-
[~csun] are you planning update patches for
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586352#comment-16586352
]
Chao Sun commented on HDFS-13790:
-
Thanks [~brahmareddy], [~elgoiri] for reviewing and committing the
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585521#comment-16585521
]
Hudson commented on HDFS-13790:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14801 (See
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585517#comment-16585517
]
Brahma Reddy Battula commented on HDFS-13790:
-
bq.[~brahmareddy]: seems you didn't include
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584149#comment-16584149
]
Hudson commented on HDFS-13790:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14794 (See
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584128#comment-16584128
]
Xiaoyu Yao commented on HDFS-13790:
---
Thanks [~csun] for the confirmation.
I just revert the commit
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584112#comment-16584112
]
Chao Sun commented on HDFS-13790:
-
[~brahmareddy]: seems you didn't include the new
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584053#comment-16584053
]
Xiaoyu Yao commented on HDFS-13790:
---
This commit seems to break the trunk build, can you confirm?
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583734#comment-16583734
]
Hudson commented on HDFS-13790:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #14793 (See
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583720#comment-16583720
]
Brahma Reddy Battula commented on HDFS-13790:
-
Committed to trunk. [~csun] thanks for
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583685#comment-16583685
]
Íñigo Goiri commented on HDFS-13790:
+1 on [^HDFS-13790.001.patch].
As pointed out, we need separate
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583557#comment-16583557
]
Brahma Reddy Battula commented on HDFS-13790:
-
latest patch lgtm.. [~elgoiri] do you've any
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578764#comment-16578764
]
genericqa commented on HDFS-13790:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578628#comment-16578628
]
Chao Sun commented on HDFS-13790:
-
[~brahmareddy]: sure, attached patch v2 for that.
> RBF: Move
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577653#comment-16577653
]
Brahma Reddy Battula commented on HDFS-13790:
-
bq.I think we need to update this after
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577613#comment-16577613
]
Íñigo Goiri commented on HDFS-13790:
I think we need to update this after HDFS-12790.
Maybe complete
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576107#comment-16576107
]
Íñigo Goiri commented on HDFS-13790:
Thanks [~csun] for [^HDFS-13790.000.patch], the refactor looks
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575643#comment-16575643
]
Brahma Reddy Battula commented on HDFS-13790:
-
Changes are LGTM,will hold for commit till
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575280#comment-16575280
]
genericqa commented on HDFS-13790:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575172#comment-16575172
]
Chao Sun commented on HDFS-13790:
-
Attached patch v0.
> RBF: Move ClientProtocol APIs to its own module
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567345#comment-16567345
]
Chao Sun commented on HDFS-13790:
-
I'll take this :)
> RBF: Move ClientProtocol APIs to its own module
>
[
https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567096#comment-16567096
]
Íñigo Goiri commented on HDFS-13790:
This is mostly refactoring of {{RouterRpcServer}}, if anybody is
37 matches
Mail list logo