[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948733#comment-16948733
]
Erik Krogen commented on HDFS-14162:
Just committed this to branch-2 based on Konstantin's +1 and
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947992#comment-16947992
]
Hadoop QA commented on HDFS-14162:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947883#comment-16947883
]
Erik Krogen commented on HDFS-14162:
Attached v005 patch fixing the 1 checkstyle warning and adding
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946158#comment-16946158
]
Hadoop QA commented on HDFS-14162:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944933#comment-16944933
]
Konstantin Shvachko commented on HDFS-14162:
+1 I think you fixed {{NameNodeProxies}} right.
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944735#comment-16944735
]
Erik Krogen commented on HDFS-14162:
Backported to branch-3.2 and branch-3.1. Attaching branch-2
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768689#comment-16768689
]
Hudson commented on HDFS-14162:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15960 (See
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768668#comment-16768668
]
Erik Krogen commented on HDFS-14162:
Just committed to trunk based off of Konstantin's +1. Thanks for
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767902#comment-16767902
]
Konstantin Shvachko commented on HDFS-14162:
Nice: 0 checkstyle warnings.
> Balancer should
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767832#comment-16767832
]
Hadoop QA commented on HDFS-14162:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767660#comment-16767660
]
Erik Krogen commented on HDFS-14162:
Attached a v004 patch addressing the checkstyle issues
>
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767590#comment-16767590
]
Konstantin Shvachko commented on HDFS-14162:
+1
Ran all Balancer tests locally. Look good.
>
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767567#comment-16767567
]
Hadoop QA commented on HDFS-14162:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767374#comment-16767374
]
Erik Krogen commented on HDFS-14162:
I ran a JMH benchmark to see about performance differences (
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766707#comment-16766707
]
Konstantin Shvachko commented on HDFS-14162:
# I guess you missed one license, in
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766671#comment-16766671
]
Hadoop QA commented on HDFS-14162:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766553#comment-16766553
]
Erik Krogen commented on HDFS-14162:
Thanks [~shv]. I just attached v002 proxy with the pluralization
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765497#comment-16765497
]
Konstantin Shvachko commented on HDFS-14162:
Hey [~xkrogen], this looks very good. I was
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764067#comment-16764067
]
Hadoop QA commented on HDFS-14162:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763971#comment-16763971
]
Erik Krogen commented on HDFS-14162:
I had some discussion offline with [~shv] and he pointed me
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740942#comment-16740942
]
Hadoop QA commented on HDFS-14162:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740829#comment-16740829
]
Konstantin Shvachko commented on HDFS-14162:
I attached testBalancerWithObserver-3.patch.
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740767#comment-16740767
]
Erik Krogen commented on HDFS-14162:
Thanks for looking [~shv]. Unfortunately, not quite. Let's take
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739920#comment-16739920
]
Konstantin Shvachko commented on HDFS-14162:
I see that {{CombinedProxyBuilder}} combines
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734754#comment-16734754
]
Hadoop QA commented on HDFS-14162:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728537#comment-16728537
]
Konstantin Shvachko commented on HDFS-14162:
Looks like [~xkrogen]'s and [~csun]'s approaches
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726395#comment-16726395
]
Erik Krogen commented on HDFS-14162:
I attached a quick-and-dirty demonstration patch
[
https://issues.apache.org/jira/browse/HDFS-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725556#comment-16725556
]
Konstantin Shvachko commented on HDFS-14162:
Attached a test, which captures this. It is
28 matches
Mail list logo