[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829710#comment-16829710
]
Íñigo Goiri commented on HDFS-14210:
I think the branch is having issues with
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829607#comment-16829607
]
Hadoop QA commented on HDFS-14210:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829547#comment-16829547
]
Hadoop QA commented on HDFS-14210:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829457#comment-16829457
]
Ayush Saxena commented on HDFS-14210:
-
Thanx [~elgoiri] for the review.
Have updated patch with the
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829420#comment-16829420
]
Íñigo Goiri commented on HDFS-14210:
Thanks [~ayushtkn] for the update.
Instead of using guava for
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829380#comment-16829380
]
Ayush Saxena commented on HDFS-14210:
-
Thanx [~shubham.dewan] for the initial work.
Have uploaded
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829374#comment-16829374
]
Shubham Dewan commented on HDFS-14210:
--
I am not working on this anymore. Anyone would like to take
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769531#comment-16769531
]
Íñigo Goiri commented on HDFS-14210:
HDFS-14226 is already committed to HDFS-13891, do you mind
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768972#comment-16768972
]
Shubham Dewan commented on HDFS-14210:
--
[~elgoiri] , sure will have a look there once
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768596#comment-16768596
]
Íñigo Goiri commented on HDFS-14210:
[~shubham.dewan], do you mind taking a look at HDFS-14226?
Once
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764018#comment-16764018
]
Íñigo Goiri commented on HDFS-14210:
We should have a test for each mount point type.
Then we should
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763224#comment-16763224
]
Ayush Saxena commented on HDFS-14210:
-
LOCAL shall be having one only. I guess. That is not a part of
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763208#comment-16763208
]
Íñigo Goiri commented on HDFS-14210:
Approaches that will have folders in all subclusters: HASH_ALL,
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763201#comment-16763201
]
Ayush Saxena commented on HDFS-14210:
-
Why we need to check for folder. A folder creation also
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763163#comment-16763163
]
Íñigo Goiri commented on HDFS-14210:
I think instead of checking if it's a mount point, we need to
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763143#comment-16763143
]
Ayush Saxena commented on HDFS-14210:
-
{quote}Anyway, my proposal is to split MountTable#isPathAll()
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762943#comment-16762943
]
Íñigo Goiri commented on HDFS-14210:
Correct, my main concern is doing unnecessary RPC calls.
Another
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762844#comment-16762844
]
Ayush Saxena commented on HDFS-14210:
-
Thanx Everyone for the discussion.
What I am getting in, from
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762020#comment-16762020
]
Íñigo Goiri commented on HDFS-14210:
Let's unify the discussion with [~ayushtkn] in HDFS-14226 here.
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761597#comment-16761597
]
Shubham Dewan commented on HDFS-14210:
--
[~elgoiri] , setOwner according to me also should be
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761100#comment-16761100
]
Íñigo Goiri commented on HDFS-14210:
[~shubham.dewan], I think this should follow the same approach
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760475#comment-16760475
]
Shubham Dewan commented on HDFS-14210:
--
Thanks [~elgoiri] for the reveiw
Changes suggested , I will
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760088#comment-16760088
]
Íñigo Goiri commented on HDFS-14210:
I'm not sure we should do this for everybody all the time.
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759680#comment-16759680
]
Hadoop QA commented on HDFS-14210:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759660#comment-16759660
]
Shubham Dewan commented on HDFS-14210:
--
[~elgoiri] taken care of the review comments.
Also,
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752598#comment-16752598
]
Íñigo Goiri commented on HDFS-14210:
I'm still not sure you need the
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751905#comment-16751905
]
Shubham Dewan commented on HDFS-14210:
--
[~elgoiri], I checked ,under relative-path
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751332#comment-16751332
]
Íñigo Goiri commented on HDFS-14210:
Don't we have any test using
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750711#comment-16750711
]
Shubham Dewan commented on HDFS-14210:
--
Thanks [~elgoiri] for a quick review.
I tried reuse
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750631#comment-16750631
]
Íñigo Goiri commented on HDFS-14210:
Thanks [~shubham.dewan] for the patch.
Do we need a new test
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749957#comment-16749957
]
Hadoop QA commented on HDFS-14210:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749857#comment-16749857
]
Shubham Dewan commented on HDFS-14210:
--
[~elgoiri] ,pls review the patch
[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744307#comment-16744307
]
Íñigo Goiri commented on HDFS-14210:
Thanks [~shubham.dewan] for [^HDFS-14210.001.patch].
I think it
33 matches
Mail list logo
