[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902659#comment-16902659
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898480#comment-16898480
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893891#comment-16893891
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888920#comment-16888920
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803811#comment-16803811
]
Hudson commented on HDFS-14295:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16298 (See
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802628#comment-16802628
]
Íñigo Goiri commented on HDFS-14295:
If nobody else has comments on this, I'll go ahead with the
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801164#comment-16801164
]
David Mollitor commented on HDFS-14295:
---
[~elgoiri] OK. Log message updated.
What is the path
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792295#comment-16792295
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790928#comment-16790928
]
Íñigo Goiri commented on HDFS-14295:
{quote}
Unfortunately, that is not how this library works. The
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790828#comment-16790828
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790787#comment-16790787
]
David Mollitor commented on HDFS-14295:
---
[~elgoiri] Yes. I completely agree. Unfortunately, that
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790776#comment-16790776
]
Íñigo Goiri commented on HDFS-14295:
Thanks [~belugabehr] for [^HDFS-14295.9.patch].
I think we need
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789863#comment-16789863
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789798#comment-16789798
]
Steve Loughran commented on HDFS-14295:
---
Looking at the changelog, all I've ever done with
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789737#comment-16789737
]
David Mollitor commented on HDFS-14295:
---
[~ste...@apache.org] I see you have worked on this class
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789735#comment-16789735
]
David Mollitor commented on HDFS-14295:
---
Just wanted to include a note:
Based on my work in
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787525#comment-16787525
]
David Mollitor commented on HDFS-14295:
---
[~elgoiri] Just checking in. Anything I can do to get
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787527#comment-16787527
]
Íñigo Goiri commented on HDFS-14295:
Try pinging some of the active people that contributed to
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779960#comment-16779960
]
BELUGA BEHR commented on HDFS-14295:
Ya that code could use some TLC. I'm working on
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779957#comment-16779957
]
Íñigo Goiri commented on HDFS-14295:
Bufff that code looks tough.
At least here we are narrowing the
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779950#comment-16779950
]
BELUGA BEHR commented on HDFS-14295:
[~elgoiri] Not sure if you saw my last comment. We submitted at
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779937#comment-16779937
]
BELUGA BEHR commented on HDFS-14295:
[~elgoiri] Unfortunately, we cannot. The running threads depend
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779943#comment-16779943
]
BELUGA BEHR commented on HDFS-14295:
Also note, that this already happens for the main thread pool.
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779942#comment-16779942
]
Íñigo Goiri commented on HDFS-14295:
Mixed feelings here... I would prefer to leave it as close as
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779747#comment-16779747
]
Íñigo Goiri commented on HDFS-14295:
Thanks for the Daemon clarification.
My only concern is to delay
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778844#comment-16778844
]
BELUGA BEHR commented on HDFS-14295:
[~elgoiri]
So, with this patch, the threads still are Daemon
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778790#comment-16778790
]
Íñigo Goiri commented on HDFS-14295:
Thanks [~belugabehr] for the clarification.
I agree that there
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778631#comment-16778631
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778627#comment-16778627
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778533#comment-16778533
]
BELUGA BEHR commented on HDFS-14295:
[~elgoiri] Thanks for the clarification. It seems to me to be
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778508#comment-16778508
]
Íñigo Goiri commented on HDFS-14295:
My proposal is to do the shutdown() towards the start of the
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778503#comment-16778503
]
BELUGA BEHR commented on HDFS-14295:
[~elgoiri] The way it is setup in the patch is the correct way
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778454#comment-16778454
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778222#comment-16778222
]
Íñigo Goiri commented on HDFS-14295:
Before the whole JVM would just take down the whole thing and
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778074#comment-16778074
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778059#comment-16778059
]
BELUGA BEHR commented on HDFS-14295:
[~elgoiri] Latest patch has logging.
The new behavior is that
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777230#comment-16777230
]
Íñigo Goiri commented on HDFS-14295:
Before this 30 seconds behavior wasn't there.
The question is
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777155#comment-16777155
]
Íñigo Goiri commented on HDFS-14295:
Thanks [~belugabehr], before closing this: thoughts on having a
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777160#comment-16777160
]
BELUGA BEHR commented on HDFS-14295:
[~elgoiri] Hello!
I'm sorry, but I don't quite follow. What is
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775153#comment-16775153
]
BELUGA BEHR commented on HDFS-14295:
[~elgoiri] - Checkstyles and FindBugs are happy again. Unit
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774784#comment-16774784
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774705#comment-16774705
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774659#comment-16774659
]
Íñigo Goiri commented on HDFS-14295:
OK let's go with the cast and let's add a supresswarning and so
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774554#comment-16774554
]
Íñigo Goiri commented on HDFS-14295:
I'm in the border with the FindBugs... I really hate this thing
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774357#comment-16774357
]
BELUGA BEHR commented on HDFS-14295:
The find-bugs is complaining that we're not waiting on the
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774098#comment-16774098
]
BELUGA BEHR commented on HDFS-14295:
[~elgoiri] Alright. I've made the requested changes. Thanks
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773663#comment-16773663
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772528#comment-16772528
]
Íñigo Goiri commented on HDFS-14295:
Currently we have:
{code}
final String xferTargetsString =
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772388#comment-16772388
]
BELUGA BEHR commented on HDFS-14295:
{{StringUtils#join}} is not the go-to option here because it
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772387#comment-16772387
]
BELUGA BEHR commented on HDFS-14295:
{{StringUtils#join}} is not the go-to option here because it
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772163#comment-16772163
]
Íñigo Goiri commented on HDFS-14295:
Thanks [~belugabehr] for the patch.
A couple comments:
* What
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772007#comment-16772007
]
BELUGA BEHR commented on HDFS-14295:
Again, it took me a few tries locally, but I did get it to pass
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771587#comment-16771587
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771426#comment-16771426
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771385#comment-16771385
]
BELUGA BEHR commented on HDFS-14295:
Also note that this means that some of these threads are being
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771376#comment-16771376
]
BELUGA BEHR commented on HDFS-14295:
One thing I'll point out that's a bit off, which I address in
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771355#comment-16771355
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771267#comment-16771267
]
Hadoop QA commented on HDFS-14295:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
58 matches
Mail list logo
