[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189992#comment-17189992
]
Fei Hui commented on HDFS-14351:
Maybe it's helpful that backport it to other 3.x branches. Thanks
>
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871611#comment-16871611
]
Hudson commented on HDFS-14351:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16813 (See
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797013#comment-16797013
]
He Xiaoqiao commented on HDFS-14351:
Thanks [~elgoiri] and [~ayushtkn] for the reviews and commit.
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796845#comment-16796845
]
Íñigo Goiri commented on HDFS-14351:
Thanks [~ayushtkn] for the review and commit.
Thanks
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796833#comment-16796833
]
Ayush Saxena commented on HDFS-14351:
-
+1, Committed!!!
Seems quite good numbers, shall be great
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796792#comment-16796792
]
He Xiaoqiao commented on HDFS-14351:
Pull [^HDFS-14351-HDFS-13891.006.patch] and test pass locally,
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796368#comment-16796368
]
Íñigo Goiri commented on HDFS-14351:
[~ayushtkn] do you mind taking a final review?
> RBF: Optimize
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793918#comment-16793918
]
Hadoop QA commented on HDFS-14351:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793833#comment-16793833
]
Íñigo Goiri commented on HDFS-14351:
I added [^HDFS-14351-HDFS-13891.006.patch] cleaning the check
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793731#comment-16793731
]
Ayush Saxena commented on HDFS-14351:
-
Thanx [~hexiaoqiao] and [~elgoiri] for the work.
Verified
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793342#comment-16793342
]
Íñigo Goiri commented on HDFS-14351:
Thanks [~hexiaoqiao], the basis is yours so I think you being
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793280#comment-16793280
]
He Xiaoqiao commented on HDFS-14351:
+1, [^HDFS-14351-HDFS-13891.005.patch].
Thanks, it's good work
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793236#comment-16793236
]
Hadoop QA commented on HDFS-14351:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793200#comment-16793200
]
Íñigo Goiri commented on HDFS-14351:
In [^HDFS-14351-HDFS-13891.005.patch], I did something I
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793085#comment-16793085
]
Íñigo Goiri commented on HDFS-14351:
These unit tests are too expensive.
Let me try to reduce the
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792745#comment-16792745
]
Hadoop QA commented on HDFS-14351:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792641#comment-16792641
]
He Xiaoqiao commented on HDFS-14351:
fix checkstyle warn in [^HDFS-14351-HDFS-13891.004.patch]
>
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792611#comment-16792611
]
Hadoop QA commented on HDFS-14351:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792563#comment-16792563
]
He Xiaoqiao commented on HDFS-14351:
[~elgoiri] Thanks, upload [^HDFS-14351-HDFS-13891.003.patch] to
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791889#comment-16791889
]
Íñigo Goiri commented on HDFS-14351:
I don't think we need a full MiniRouterDFSCluster.
Starting a
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791504#comment-16791504
]
Hadoop QA commented on HDFS-14351:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791494#comment-16791494
]
He Xiaoqiao commented on HDFS-14351:
Attached [^HDFS-14351-HDFS-13891.002.patch] following comments.
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791344#comment-16791344
]
He Xiaoqiao commented on HDFS-14351:
I will add new test to for RouterNamenodeMonitoringConfig later.
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790769#comment-16790769
]
Íñigo Goiri commented on HDFS-14351:
Thanks [~hexiaoqiao] for the rebase.
I would extend the test to
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790374#comment-16790374
]
Hadoop QA commented on HDFS-14351:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790332#comment-16790332
]
He Xiaoqiao commented on HDFS-14351:
Thanks [~elgoiri] for reviewing.
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789840#comment-16789840
]
Íñigo Goiri commented on HDFS-14351:
Thanks [~hexiaoqiao] for the patch.
Can you rebase the path to
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789669#comment-16789669
]
Hadoop QA commented on HDFS-14351:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789529#comment-16789529
]
Hadoop QA commented on HDFS-14351:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789470#comment-16789470
]
He Xiaoqiao commented on HDFS-14351:
attach another patch [^HDFS-14351.002.patch] based on branch
[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788958#comment-16788958
]
Hadoop QA commented on HDFS-14351:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
31 matches
Mail list logo
