[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879989#comment-16879989
]
hunshenshi commented on HDFS-14361:
---
[~starphin] Thanks. So it should move out from if block.
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879988#comment-16879988
]
star commented on HDFS-14361:
-
Right. isPrimaryCheckPointer will not be changed when any error/exception
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879053#comment-16879053
]
hunshenshi commented on HDFS-14361:
---
[~starphin] today I review this code. I think you don't understand
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793450#comment-16793450
]
star commented on HDFS-14361:
-
[~brahmareddy], please wait.
Maybe we should reconsider the design doc
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793444#comment-16793444
]
hunshenshi commented on HDFS-14361:
---
yes, thanks [~brahmareddy] [~starphin]
> SNN will always upload
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793413#comment-16793413
]
Brahma Reddy Battula commented on HDFS-14361:
-
{quote}If catch ExecutionException or
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793379#comment-16793379
]
hunshenshi commented on HDFS-14361:
---
Thanks [~starphin]
> SNN will always upload fsimage
>
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793366#comment-16793366
]
star commented on HDFS-14361:
-
[~hunhun], right.
> SNN will always upload fsimage
>
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793361#comment-16793361
]
hunshenshi commented on HDFS-14361:
---
Sorry [~starphin] , I get.
If catch ExecutionException or
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793345#comment-16793345
]
star commented on HDFS-14361:
-
_if another SNN send checkpoint request to ANN successfully_, current SNN will
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793337#comment-16793337
]
hunshenshi commented on HDFS-14361:
---
[~starphin] , _sendCheckpoint_ _will be set false if another SNN
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793295#comment-16793295
]
star commented on HDFS-14361:
-
[~hunhun], _gotcha._
_If there is only one SNN, it make sense for
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793282#comment-16793282
]
hunshenshi commented on HDFS-14361:
---
[~starphin], if isPrimaryCheckPointer inside the if condition,
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793276#comment-16793276
]
star commented on HDFS-14361:
-
[~hunhun], what do you mean by 'next code never work',
if sendCheckpoint =
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793264#comment-16793264
]
hunshenshi commented on HDFS-14361:
---
if isPrimaryCheckPointer inside the if condition, next code never
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793261#comment-16793261
]
star commented on HDFS-14361:
-
Let's go back to original design doc
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793254#comment-16793254
]
hunshenshi commented on HDFS-14361:
---
[~brahmareddy]
{code:java}
if (ie == null && ioe == null) {
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793255#comment-16793255
]
hunshenshi commented on HDFS-14361:
---
[~brahmareddy]
{code:java}
for (; i < uploads.size(); i++) {
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792666#comment-16792666
]
Brahma Reddy Battula commented on HDFS-14361:
-
[~hunhun] thanks for reporting this.
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790687#comment-16790687
]
Wei-Chiu Chuang commented on HDFS-14361:
Since this is related to HDFS-12248, [~brahmareddy]
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790491#comment-16790491
]
Hadoop QA commented on HDFS-14361:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790481#comment-16790481
]
Hadoop QA commented on HDFS-14361:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
22 matches
Mail list logo
